[GitHub] [ignite] ygerzhedovich commented on a diff in pull request #10458: IGNITE-18282 SQL Calcite: Improve dynamic parameters type inference

[GitBox <gi...@apache.org>]

ygerzhedovich commented on code in PR #10458:
URL: https://github.com/apache/ignite/pull/10458#discussion_r1057604489


##########
modules/calcite/src/main/java/org/apache/ignite/internal/processors/query/calcite/prepare/CacheKey.java:
##########
@@ -63,16 +71,22 @@ public CacheKey(String schemaName, String query) {
 
         if (!schemaName.equals(cacheKey.schemaName))
             return false;
+
         if (!query.equals(cacheKey.query))
             return false;
-        return Objects.equals(contextKey, cacheKey.contextKey);
+
+        if (Objects.equals(contextKey, cacheKey.contextKey))

Review Comment:
   ```suggestion
           if (!Objects.equals(contextKey, cacheKey.contextKey))
   ```



##########
modules/calcite/src/main/java/org/apache/ignite/internal/processors/query/calcite/prepare/CacheKey.java:
##########
@@ -63,16 +71,22 @@ public CacheKey(String schemaName, String query) {
 
         if (!schemaName.equals(cacheKey.schemaName))
             return false;
+
         if (!query.equals(cacheKey.query))
             return false;
-        return Objects.equals(contextKey, cacheKey.contextKey);
+
+        if (Objects.equals(contextKey, cacheKey.contextKey))

Review Comment:
   ```suggestion
           if (!Objects.equals(contextKey, cacheKey.contextKey))
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@ignite.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org