You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@perl.apache.org by Geoffrey Young <ge...@modperlcookbook.org> on 2003/04/03 19:02:45 UTC
running Apache::Test tests
I never noticed it before, but 'make test' runs mod_perl core tests and
ModPerl::Registry tests, but not Apache::Test tests. I kinda think we
should be running all available tests, especially for software we're
installing alongside mod_perl (even though it's a little backwards, testing
Apache::Test _after_ we've used it to run the other tests :)
--Geoff
Index: Makefile.PL
===================================================================
RCS file: /home/cvspublic/modperl-2.0/Makefile.PL,v
retrieving revision 1.99
diff -u -r1.99 Makefile.PL
--- Makefile.PL 27 Mar 2003 05:22:26 -0000 1.99
+++ Makefile.PL 3 Apr 2003 16:41:27 -0000
@@ -445,6 +445,7 @@
$(FULLPERL) -I$(INST_ARCHLIB) -I$(INST_LIB) \
t/TEST -verbose=$(TEST_VERBOSE) $(TEST_FILES)
cd ModPerl-Registry && $(MAKE) test
+ cd Apache-Test && $(MAKE) test
test :: pure_all run_tests test_clean
EOF
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@perl.apache.org
For additional commands, e-mail: dev-help@perl.apache.org
Re: running Apache::Test tests
Posted by Stas Bekman <st...@stason.org>.
>> So -0 here.
>
>
> that's fine. the only situation where I would be more inclined to
> include them is if we could run them first, making it easier to isolate
> errors due to broken Apache::Test libraries rather then core mod_perl.
> but, as we both agree, running the tests is really overkill.
We can always add that if we see that there is a need for that. So far, other
than a few issues with -MApache2, I don't think there were any troubles with
Apache::Test.
__________________________________________________________________
Stas Bekman JAm_pH ------> Just Another mod_perl Hacker
http://stason.org/ mod_perl Guide ---> http://perl.apache.org
mailto:stas@stason.org http://use.perl.org http://apacheweek.com
http://modperlbook.org http://apache.org http://ticketmaster.com
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@perl.apache.org
For additional commands, e-mail: dev-help@perl.apache.org
Re: running Apache::Test tests
Posted by Geoffrey Young <ge...@modperlcookbook.org>.
Stas Bekman wrote:
> Geoffrey Young wrote:
>
>> I never noticed it before, but 'make test' runs mod_perl core tests
>> and ModPerl::Registry tests, but not Apache::Test tests. I kinda
>> think we should be running all available tests, especially for
>> software we're installing alongside mod_perl (even though it's a
>> little backwards, testing Apache::Test _after_ we've used it to run
>> the other tests :)
>
>
> Do you really think we need that?
not really.
> the two test suites that we are
> running are already testing the Apache::Test itself.
yeah, that's why I said it was kinda backwards.
> In addition to
> having almost no tests in the Apache::Test suite. It seems to be just an
> unnecessary overhead, especially for threaded-mpm, which takes agest to
> start each new 'make test' and to finish it.
as it does on my pentium 120 dev box :)
>
> I'd be all for it if Apache::Test was including tests unique to it.
>
> So -0 here.
that's fine. the only situation where I would be more inclined to
include them is if we could run them first, making it easier to
isolate errors due to broken Apache::Test libraries rather then core
mod_perl. but, as we both agree, running the tests is really overkill.
--Geoff
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@perl.apache.org
For additional commands, e-mail: dev-help@perl.apache.org
Re: running Apache::Test tests
Posted by Stas Bekman <st...@stason.org>.
Geoffrey Young wrote:
> I never noticed it before, but 'make test' runs mod_perl core tests and
> ModPerl::Registry tests, but not Apache::Test tests. I kinda think we
> should be running all available tests, especially for software we're
> installing alongside mod_perl (even though it's a little backwards,
> testing Apache::Test _after_ we've used it to run the other tests :)
Do you really think we need that? the two test suites that we are running are
already testing the Apache::Test itself. In addition to having almost no tests
in the Apache::Test suite. It seems to be just an unnecessary overhead,
especially for threaded-mpm, which takes agest to start each new 'make test'
and to finish it.
I'd be all for it if Apache::Test was including tests unique to it.
So -0 here.
> Index: Makefile.PL
> ===================================================================
> RCS file: /home/cvspublic/modperl-2.0/Makefile.PL,v
> retrieving revision 1.99
> diff -u -r1.99 Makefile.PL
> --- Makefile.PL 27 Mar 2003 05:22:26 -0000 1.99
> +++ Makefile.PL 3 Apr 2003 16:41:27 -0000
> @@ -445,6 +445,7 @@
> $(FULLPERL) -I$(INST_ARCHLIB) -I$(INST_LIB) \
> t/TEST -verbose=$(TEST_VERBOSE) $(TEST_FILES)
> cd ModPerl-Registry && $(MAKE) test
> + cd Apache-Test && $(MAKE) test
>
> test :: pure_all run_tests test_clean
> EOF
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@perl.apache.org
> For additional commands, e-mail: dev-help@perl.apache.org
--
__________________________________________________________________
Stas Bekman JAm_pH ------> Just Another mod_perl Hacker
http://stason.org/ mod_perl Guide ---> http://perl.apache.org
mailto:stas@stason.org http://use.perl.org http://apacheweek.com
http://modperlbook.org http://apache.org http://ticketmaster.com
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@perl.apache.org
For additional commands, e-mail: dev-help@perl.apache.org