You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pinot.apache.org by "zhtaoxiang (via GitHub)" <gi...@apache.org> on 2023/02/15 19:46:29 UTC

[GitHub] [pinot] zhtaoxiang opened a new pull request, #10287: limit helix task result info message size to 100

zhtaoxiang opened a new pull request, #10287:
URL: https://github.com/apache/pinot/pull/10287

   Helix task framework put task result info message into Znode, we limit helix task result info message size to 100 to avoid the Znode grows too large. Too large Znode can cause communication exceptions with Zookeeper, which will crash pinot component - in this case, pinot controller.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org


[GitHub] [pinot] snleee commented on pull request #10287: limit helix task result info message size to 100

Posted by "snleee (via GitHub)" <gi...@apache.org>.
snleee commented on PR #10287:
URL: https://github.com/apache/pinot/pull/10287#issuecomment-1432068508

   please also change the pr message to 1000


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org


[GitHub] [pinot] snleee commented on pull request #10287: limit helix task result info message size to 100

Posted by "snleee (via GitHub)" <gi...@apache.org>.
snleee commented on PR #10287:
URL: https://github.com/apache/pinot/pull/10287#issuecomment-1432035518

   @Jackie-Jiang I talked with @zhtaoxiang offline. This information indeed gets read by the debug API that we have. So, cutting logs with 100 length may be too invasive for ppl who runs debug API. I think that we should try to put some more thoughts before we merge this.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org


[GitHub] [pinot] snleee merged pull request #10287: limit helix task result info message size to 1000

Posted by "snleee (via GitHub)" <gi...@apache.org>.
snleee merged PR #10287:
URL: https://github.com/apache/pinot/pull/10287


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org