You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@activemq.apache.org by cshannon <gi...@git.apache.org> on 2018/08/08 18:12:15 UTC

[GitHub] activemq-artemis pull request #2229: ARTEMIS-2018 - Add bridge events to plu...

GitHub user cshannon opened a pull request:

    https://github.com/apache/activemq-artemis/pull/2229

    ARTEMIS-2018 - Add bridge events to plugin API

    Add callbacks to handle bridge events including beforeDeliverBridge,
    afterDeliverBridge and afterAcknowledgeBridge

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/cshannon/activemq-artemis ARTEMIS-2018

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/activemq-artemis/pull/2229.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #2229
    
----
commit 95ff39f6bfae9c51e6c3c1d1ac2782f60f5d2daa
Author: Christopher L. Shannon (cshannon) <ch...@...>
Date:   2018-08-08T18:10:22Z

    ARTEMIS-2018 - Add bridge events to plugin API
    
    Add callbacks to handle bridge events including beforeDeliverBridge,
    afterDeliverBridge and afterAcknowledgeBridge

----


---

[GitHub] activemq-artemis pull request #2229: ARTEMIS-2018 - Add bridge events to plu...

Posted by asfgit <gi...@git.apache.org>.

Github user asfgit closed the pull request at:

    https://github.com/apache/activemq-artemis/pull/2229


---

[GitHub] activemq-artemis issue #2229: ARTEMIS-2018 - Add bridge events to plugin API

Posted by cshannon <gi...@git.apache.org>.

Github user cshannon commented on the issue:

    https://github.com/apache/activemq-artemis/pull/2229
  
    I like the idea of using separate interfaces and having ActiveMQServerPlugin extend them.  This way if someone doesn't care they can make it easy and just extend ActiveMQServerPlugin (as well as keep backwards compatibility) or the user can choose to pick specific interfaces for performance.


---

[GitHub] activemq-artemis issue #2229: ARTEMIS-2018 - Add bridge events to plugin API

Posted by michaelandrepearce <gi...@git.apache.org>.

Github user michaelandrepearce commented on the issue:

    https://github.com/apache/activemq-artemis/pull/2229
  
    Looks good to me. 
    
    Not to affect this PR, but a general comment that we should start thinking about, there now is a case that by having one broker plugin that it will be invoked left right and centre on every intercept, e.g. say i want to have broker plugin to capture something not on the hotpath, the plugin will still be called on the hotpath, as the checks done in the if statement are simply hasBrokerPlugins, i wonder if we could make it some time to have the "hasBrokerPlugins" to have specific types, where when the plugin is added it registers the types its applicable for, and thus later we could have "hasBrokerPluginsBridgeType" and "hasBrokerPluginsBindingType".
    



---

[GitHub] activemq-artemis issue #2229: ARTEMIS-2018 - Add bridge events to plugin API

Posted by michaelandrepearce <gi...@git.apache.org>.

Github user michaelandrepearce commented on the issue:

    https://github.com/apache/activemq-artemis/pull/2229
  
    Cool ill see if i can knock something up.
    
    Ill merge this a bit later today if no other commenta


---