[jira] Resolved: (JSPWIKI-236) Messed links on Login/Edit Help information when the target page is missing

["Janne Jalkanen (JIRA)" <ji...@apache.org>]

     [ https://issues.apache.org/jira/browse/JSPWIKI-236?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Janne Jalkanen resolved JSPWIKI-236.
------------------------------------

    Resolution: Fixed

Fixed in 2.7.0-svn-26.

I chose to fix this on the localization side - the edit link is too useful.  The problem was that some localizations were embedding {0} into the link itself, which was a bad idea.

> Messed links on Login/Edit Help information when the target page is missing
> ---------------------------------------------------------------------------
>
>                 Key: JSPWIKI-236
>                 URL: https://issues.apache.org/jira/browse/JSPWIKI-236
>             Project: JSPWiki
>          Issue Type: Bug
>          Components: Default template
>    Affects Versions: 2.6.2
>         Environment: build: JSPWiki v2.7.0-svn-6  
>            Reporter: David Gao
>             Fix For: 2.8
>
>
> Hi,
> The links about EditHelp/LoginHelp are totally messed up on Login/Edit Help information page if the LoginHelp.txt /EditHelp is missing (from the repository). 
> The tag <wiki:EditLink page="LoginPageHelp">LoginHelp</wiki:EditLink> will make the LoginHelp a link in related JSP files. The output for this will become:
> <a href="Edit.jsp?page=LoginPageHelp" accesskey="" title=""> LoginHelp</a>
> Please remove the </wiki:EditLink> tags from the following files:
> LoginContent.jsp
> CommentContent.jsp
> EditContent.jsp
> The updated text will look like below:
> [LoginContent.jsp]
>   <wiki:NoSuchPage page="LoginHelp">
>   <div class="error">
>     <fmt:message key="login.loginhelpmissing">
>        <fmt:param>LoginHelp</wiki:EditLink></fmt:param>
>     </fmt:message>
>   </div>
>   </wiki:NoSuchPage>
> =========================================
> [CommentContent.jsp]
>     <wiki:NoSuchPage page="EditPageHelp">
>       <div class="error">
>          <fmt:message key="comment.edithelpmissing">
>             <fmt:param>EditPageHelp</fmt:param>
>          </fmt:message>
>       </div>
>     </wiki:NoSuchPage>
> ==========================================
> [EditContent.jsp]
>   <wiki:NoSuchPage page="EditPageHelp">
>     <div class="error">
>       <fmt:message key="comment.edithelpmissing">
>         <fmt:param>EditPageHelp</fmt:param>
>       </fmt:message>
>     </div>
>   </wiki:NoSuchPage>  

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.