[GitHub] [iceberg] marton-bod commented on a change in pull request #1570: Run hive storage handler tests for both Parquet and ORC

[GitBox <gi...@apache.org>]

marton-bod commented on a change in pull request #1570:
URL: https://github.com/apache/iceberg/pull/1570#discussion_r502838173



##########
File path: mr/src/test/java/org/apache/iceberg/mr/hive/HiveIcebergStorageHandlerBaseTest.java
##########
@@ -136,18 +136,50 @@ public void after() throws Exception {
     }
   }
 
+  // PARQUET
+
+  @Test
+  public void testScanEmptyTableParquet() throws IOException {

Review comment:
       Hi @rdblue, thanks for taking a look! The reason I did that is because these StorageHandler tests already use a different test runner (`StandaloneHiveRunner`), therefore I couldn't use `Parameterized.class` as well. I've tried to outline this rationale in the PR description, but I'm afraid it must have gotten lost in my rather long-winded sentences... :)




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org