You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@beam.apache.org by swegner <gi...@git.apache.org> on 2016/09/30 17:07:31 UTC

[GitHub] incubator-beam pull request #1034: [BEAM-695] PipelineOptions display data n...

GitHub user swegner opened a pull request:

    https://github.com/apache/incubator-beam/pull/1034

    [BEAM-695] PipelineOptions display data needs to handle array types

    Be sure to do all of the following to help us incorporate your contribution
    quickly and easily:
    
     - [ ] Make sure the PR title is formatted like:
       `[BEAM-<Jira issue #>] Description of pull request`
     - [ ] Make sure tests pass via `mvn clean verify`. (Even better, enable
           Travis-CI on your fork and ensure the whole test matrix passes).
     - [ ] Replace `<Jira issue #>` in the title with the actual Jira issue
           number, if there is one.
     - [ ] If this contribution is large, please file an Apache
           [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.txt).
    
    ---
    
    PipelineOptions generates display data for arbitrary option types
    using #toString(). For array types, this gives an message like
    [Ljava.lang.String;@fc25934b]. Instead, we detect array types
    and use Arrays.deepString to build a string based on array values.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/swegner/incubator-beam displaydata-array-string

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/incubator-beam/pull/1034.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #1034
    
----
commit ca12648f5ce0b744c30cfa6bbcd486519ae1bf95
Author: Scott Wegner <sw...@google.com>
Date:   2016-09-30T17:05:00Z

    PipelineOptions display data needs to handle array types
    
    PipelineOptions generates display data for arbitrary option types
    using #toString(). For array types, this gives an message like
    [Ljava.lang.String;@fc25934b]. Instead, we detect array types
    and use Arrays.deepString to build a string based on array values.

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-beam pull request #1034: [BEAM-695] PipelineOptions display data n...

Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:

    https://github.com/apache/incubator-beam/pull/1034


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---