[GitHub] [arrow] nevi-me commented on a change in pull request #7261: ARROW-8907: [Rust] Implement scalar comparison operations

[GitBox <gi...@apache.org>]

nevi-me commented on a change in pull request #7261:
URL: https://github.com/apache/arrow/pull/7261#discussion_r429678616



##########
File path: rust/arrow/src/compute/kernels/comparison.rs
##########
@@ -66,6 +66,31 @@ macro_rules! compare_op {
     }};
 }
 
+macro_rules! compare_op_scalar {
+    ($left: expr, $right:expr, $op:expr) => {{
+        let null_bit_buffer =

Review comment:
       since you're comparing to a non-null scalar, you shouldn't need to compute a bitmap, you could use `$left`'s null buffer: `$left.data().null_buffer()`




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org