You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@nifi.apache.org by GitBox <gi...@apache.org> on 2020/04/23 18:41:56 UTC

[GitHub] [nifi] joewitt commented on a change in pull request #4228: NIFI-7122 Introduce new KDFs and encryption metadata attributes to EncryptContent processor

joewitt commented on a change in pull request #4228:
URL: https://github.com/apache/nifi/pull/4228#discussion_r414035894



##########
File path: nifi-api/src/main/java/org/apache/nifi/flowfile/FlowFile.java
##########
@@ -108,7 +108,7 @@
      */
     Map<String, String> getAttributes();
 
-    public static class KeyValidator {

Review comment:
       Give that this is in the nifi-api I don't believe this change is ok outside of major nifi release boundary (nifi 2.0).  The only way this change would be ok is if having this class public and static was unintentional/a bug and that we are sure someone else should not be reasonably using this. Do you think that is the case?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org