You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@iotdb.apache.org by GitBox <gi...@apache.org> on 2022/01/24 11:03:11 UTC
[GitHub] [iotdb] THUMarkLau opened a new pull request #4967: [IOTDB-2478] Try to fix `IoTDBRemovePartitionIT`
THUMarkLau opened a new pull request #4967:
URL: https://github.com/apache/iotdb/pull/4967
## Description
### Content1 ...
### Content2 ...
### Content3 ...
<!--
In each section, please describe design decisions made, including:
- Choice of algorithms
- Behavioral aspects. What configuration values are acceptable? How are corner cases and error
conditions handled, such as when there are insufficient resources?
- Class organization and design (how the logic is split between classes, inheritance, composition,
design patterns)
- Method organization and design (how the logic is split between methods, parameters and return types)
- Naming (class, method, API, configuration, HTTP endpoint, names of emitted metrics)
-->
<!-- It's good to describe an alternative design (or mention an alternative name) for every design
(or naming) decision point and compare the alternatives with the designs that you've implemented
(or the names you've chosen) to highlight the advantages of the chosen designs and names. -->
<!-- If there was a discussion of the design of the feature implemented in this PR elsewhere
(e. g. a "Proposal" issue, any other issue, or a thread in the development mailing list),
link to that discussion from this PR description and explain what have changed in your final design
compared to your original proposal or the consensus version in the end of the discussion.
If something hasn't changed since the original discussion, you can omit a detailed discussion of
those aspects of the design here, perhaps apart from brief mentioning for the sake of readability
of this PR description. -->
<!-- Some of the aspects mentioned above may be omitted for simple and small changes. -->
<hr>
This PR has:
- [ ] been self-reviewed.
- [ ] concurrent read
- [ ] concurrent write
- [ ] concurrent read and write
- [ ] added documentation for new or modified features or behaviors.
- [ ] added Javadocs for most classes and all non-trivial methods.
- [ ] added or updated version, __license__, or notice information
- [ ] added comments explaining the "why" and the intent of the code wherever would not be obvious
for an unfamiliar reader.
- [ ] added unit tests or modified existing tests to cover new code paths, ensuring the threshold
for code coverage.
- [ ] added integration tests.
- [ ] been tested in a test IoTDB cluster.
<!-- Check the items by putting "x" in the brackets for the done things. Not all of these items
apply to every PR. Remove the items which are not done or not relevant to the PR. None of the items
from the checklist above are strictly necessary, but it would be very helpful if you at least
self-review the PR. -->
<hr>
##### Key changed/added classes (or packages if there are too many classes) in this PR
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [iotdb] qiaojialin merged pull request #4967: [IOTDB-2478] Try to fix `IoTDBRemovePartitionIT` and `CompactionSchedulerTest`
Posted by GitBox <gi...@apache.org>.
qiaojialin merged pull request #4967:
URL: https://github.com/apache/iotdb/pull/4967
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [iotdb] coveralls edited a comment on pull request #4967: [IOTDB-2478] Try to fix `IoTDBRemovePartitionIT` and `CompactionSchedulerTest`
Posted by GitBox <gi...@apache.org>.
coveralls edited a comment on pull request #4967:
URL: https://github.com/apache/iotdb/pull/4967#issuecomment-1024868935
[](https://coveralls.io/builds/46063522)
Coverage increased (+0.01%) to 67.757% when pulling **ae20e2b03f220ff2bd41c9be143bf953e2d13d21 on THUMarkLau:try-to-fix-remove-partition-ci** into **ce154b8d2e1cb3d723168b8fc2b103d223c39d8d on apache:master**.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [iotdb] coveralls edited a comment on pull request #4967: [IOTDB-2478] Try to fix `IoTDBRemovePartitionIT`
Posted by GitBox <gi...@apache.org>.
coveralls edited a comment on pull request #4967:
URL: https://github.com/apache/iotdb/pull/4967#issuecomment-1024868935
[](https://coveralls.io/builds/46057754)
Coverage increased (+0.005%) to 67.751% when pulling **98bfb906512227afa7c8ac907a88b793a0f7b1b9 on THUMarkLau:try-to-fix-remove-partition-ci** into **d36ce5a9078d0e45bec62637a727fca59da9899f on apache:master**.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [iotdb] coveralls edited a comment on pull request #4967: [IOTDB-2478] Try to fix `IoTDBRemovePartitionIT`
Posted by GitBox <gi...@apache.org>.
coveralls edited a comment on pull request #4967:
URL: https://github.com/apache/iotdb/pull/4967#issuecomment-1024868935
[](https://coveralls.io/builds/46057423)
Coverage increased (+0.01%) to 67.757% when pulling **0b115aeaa2a5424974f483f8fc623b0cc90cf301 on THUMarkLau:try-to-fix-remove-partition-ci** into **d36ce5a9078d0e45bec62637a727fca59da9899f on apache:master**.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [iotdb] coveralls edited a comment on pull request #4967: [IOTDB-2478] Try to fix `IoTDBRemovePartitionIT` and `CompactionSchedulerTest`
Posted by GitBox <gi...@apache.org>.
coveralls edited a comment on pull request #4967:
URL: https://github.com/apache/iotdb/pull/4967#issuecomment-1024868935
[](https://coveralls.io/builds/46062935)
Coverage increased (+0.02%) to 67.762% when pulling **c09de67c9654a69ce5898d48d899da1b81cee5bf on THUMarkLau:try-to-fix-remove-partition-ci** into **d36ce5a9078d0e45bec62637a727fca59da9899f on apache:master**.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [iotdb] coveralls edited a comment on pull request #4967: [IOTDB-2478] Try to fix `IoTDBRemovePartitionIT` and `CompactionSchedulerTest`
Posted by GitBox <gi...@apache.org>.
coveralls edited a comment on pull request #4967:
URL: https://github.com/apache/iotdb/pull/4967#issuecomment-1024868935
[](https://coveralls.io/builds/46058014)
Coverage decreased (-0.03%) to 67.715% when pulling **d77678469bb0989c6707fdb2111b0a6b0e6f5a0a on THUMarkLau:try-to-fix-remove-partition-ci** into **d36ce5a9078d0e45bec62637a727fca59da9899f on apache:master**.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [iotdb] coveralls edited a comment on pull request #4967: [IOTDB-2478] Try to fix `IoTDBRemovePartitionIT` and `CompactionSchedulerTest`
Posted by GitBox <gi...@apache.org>.
coveralls edited a comment on pull request #4967:
URL: https://github.com/apache/iotdb/pull/4967#issuecomment-1024868935
[](https://coveralls.io/builds/46070485)
Coverage increased (+0.009%) to 67.756% when pulling **4a9ef518cc61a140d6b3deb3eb30a667d2ace0f6 on THUMarkLau:try-to-fix-remove-partition-ci** into **ce154b8d2e1cb3d723168b8fc2b103d223c39d8d on apache:master**.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [iotdb] coveralls commented on pull request #4967: [IOTDB-2478] Try to fix `IoTDBRemovePartitionIT`
Posted by GitBox <gi...@apache.org>.
coveralls commented on pull request #4967:
URL: https://github.com/apache/iotdb/pull/4967#issuecomment-1024868935
[](https://coveralls.io/builds/46057407)
Coverage decreased (-0.02%) to 67.728% when pulling **0b115aeaa2a5424974f483f8fc623b0cc90cf301 on THUMarkLau:try-to-fix-remove-partition-ci** into **d36ce5a9078d0e45bec62637a727fca59da9899f on apache:master**.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [iotdb] coveralls edited a comment on pull request #4967: [IOTDB-2478] Try to fix `IoTDBRemovePartitionIT` and `CompactionSchedulerTest`
Posted by GitBox <gi...@apache.org>.
coveralls edited a comment on pull request #4967:
URL: https://github.com/apache/iotdb/pull/4967#issuecomment-1024868935
[](https://coveralls.io/builds/46065214)
Coverage remained the same at 67.747% when pulling **2babdb4761e7338988ab25ef16eb4f65f01cc349 on THUMarkLau:try-to-fix-remove-partition-ci** into **ce154b8d2e1cb3d723168b8fc2b103d223c39d8d on apache:master**.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org