You are viewing a plain text version of this content. The canonical link for it is here.

Posted to reviews@spark.apache.org by cloud-fan <gi...@git.apache.org> on 2018/11/12 13:41:16 UTC

[GitHub] spark pull request #23015: [BUILD][2.4] Bump previousSparkVersion in MimaBui...

GitHub user cloud-fan opened a pull request:

    https://github.com/apache/spark/pull/23015

    [BUILD][2.4] Bump previousSparkVersion in MimaBuild.scala to be 2.3.0

    ## What changes were proposed in this pull request?
    
    Although it's a little late, we should still update mima for branch 2.4, to avoid future breaking changes.
    
    Note that, when merging, we should forward port to master branch, so that the excluding rules is still in `v24excludes`.
    
    ## How was this patch tested?
    
    N/A


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/cloud-fan/spark mima-2.4

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/spark/pull/23015.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #23015
    
----
commit 3d5e7b0ff8c23b51ae84d15f045a503954721d5d
Author: Wenchen Fan <we...@...>
Date:   2018-11-12T13:38:37Z

    Bump previousSparkVersion in MimaBuild.scala to be 2.3.0

----


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] spark pull request #23015: [BUILD][2.4] Bump previousSparkVersion in MimaBui...

Posted by cloud-fan <gi...@git.apache.org>.

Github user cloud-fan commented on a diff in the pull request:

    https://github.com/apache/spark/pull/23015#discussion_r232661121
  
    --- Diff: project/MimaExcludes.scala ---
    @@ -105,7 +105,50 @@ object MimaExcludes {
         ProblemFilters.exclude[InheritedNewAbstractMethodProblem]("org.apache.spark.ml.param.shared.HasValidationIndicatorCol.validationIndicatorCol"),
     
         // [SPARK-23042] Use OneHotEncoderModel to encode labels in MultilayerPerceptronClassifier
    -    ProblemFilters.exclude[MissingClassProblem]("org.apache.spark.ml.classification.LabelConverter")
    +    ProblemFilters.exclude[MissingClassProblem]("org.apache.spark.ml.classification.LabelConverter"),
    +
    +    // [SPARK-21842][MESOS] Support Kerberos ticket renewal and creation in Mesos
    +    ProblemFilters.exclude[DirectMissingMethodProblem]("org.apache.spark.deploy.SparkHadoopUtil.getDateOfNextUpdate"),
    +
    +    // [SPARK-23366] Improve hot reading path in ReadAheadInputStream
    +    ProblemFilters.exclude[DirectMissingMethodProblem]("org.apache.spark.io.ReadAheadInputStream.this"),
    +
    +    // [SPARK-22941][CORE] Do not exit JVM when submit fails with in-process launcher.
    +    ProblemFilters.exclude[DirectMissingMethodProblem]("org.apache.spark.deploy.SparkSubmit.addJarToClasspath"),
    +    ProblemFilters.exclude[DirectMissingMethodProblem]("org.apache.spark.deploy.SparkSubmit.mergeFileLists"),
    +    ProblemFilters.exclude[DirectMissingMethodProblem]("org.apache.spark.deploy.SparkSubmit.prepareSubmitEnvironment$default$2"),
    +
    +    // Data Source V2 API changes
    --- End diff --
    
    I tried to exclude them from mima check, but unfortunately the Unstable/Evolving/Stable annotations have a bug: they are not retained in the class file like `Experimental` annotation, so mima is not aware of them.
    
    I'll fix it in another PR.


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] spark issue #23015: [BUILD][2.4] Bump previousSparkVersion in MimaBuild.scal...

Posted by SparkQA <gi...@git.apache.org>.

Github user SparkQA commented on the issue:

    https://github.com/apache/spark/pull/23015
  
    **[Test build #98732 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/98732/testReport)** for PR 23015 at commit [`7fef383`](https://github.com/apache/spark/commit/7fef383b4b368d2f7cce4c58cb388ceefbf12b42).


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org