You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2021/06/24 06:13:53 UTC
[GitHub] [superset] kgabryje opened a new pull request #15349: chore: Bump @svgr/webpack to 5.5.0
kgabryje opened a new pull request #15349:
URL: https://github.com/apache/superset/pull/15349
### SUMMARY
Bumps `@svgr/webpack` from `^5.4.0` to `^5.5.0`
### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
<!--- Skip this if not applicable -->
### TESTING INSTRUCTIONS
<!--- Required! What steps can be taken to manually verify the changes? -->
### ADDITIONAL INFORMATION
<!--- Check any relevant boxes with "x" -->
<!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue -->
- [ ] Has associated issue:
- [ ] Changes UI
- [ ] Includes DB Migration (follow approval process in [SIP-59](https://github.com/apache/superset/issues/13351))
- [ ] Migration is atomic, supports rollback & is backwards-compatible
- [ ] Confirm DB migration upgrade and downgrade tested
- [ ] Runtime estimates and downtime expectations provided
- [ ] Introduces new feature or API
- [ ] Removes existing feature or API
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] rusackas merged pull request #15349: chore: Bump @svgr/webpack to 5.5.0
Posted by GitBox <gi...@apache.org>.
rusackas merged pull request #15349:
URL: https://github.com/apache/superset/pull/15349
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov[bot] commented on pull request #15349: chore: Bump @svgr/webpack to 5.5.0
Posted by GitBox <gi...@apache.org>.
codecov[bot] commented on pull request #15349:
URL: https://github.com/apache/superset/pull/15349#issuecomment-867402702
# [Codecov](https://codecov.io/gh/apache/superset/pull/15349?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#15349](https://codecov.io/gh/apache/superset/pull/15349?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (3c51ba5) into [master](https://codecov.io/gh/apache/superset/commit/b89ee0cb388b06044903a114ee04f79160098840?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (b89ee0c) will **increase** coverage by `0.00%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/superset/pull/15349?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #15349 +/- ##
=======================================
Coverage 77.23% 77.23%
=======================================
Files 973 973
Lines 50491 50487 -4
Branches 6184 6183 -1
=======================================
- Hits 38997 38996 -1
+ Misses 11288 11285 -3
Partials 206 206
```
| Flag | Coverage Δ | |
|---|---|---|
| javascript | `71.78% <ø> (+<0.01%)` | :arrow_up: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/15349?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [superset-frontend/src/views/CRUD/hooks.ts](https://codecov.io/gh/apache/superset/pull/15349/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3ZpZXdzL0NSVUQvaG9va3MudHM=) | `52.80% <0.00%> (-0.22%)` | :arrow_down: |
| [superset-frontend/src/setup/setupErrorMessages.ts](https://codecov.io/gh/apache/superset/pull/15349/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3NldHVwL3NldHVwRXJyb3JNZXNzYWdlcy50cw==) | `0.00% <0.00%> (ø)` | |
| [superset-frontend/src/components/Select/Select.tsx](https://codecov.io/gh/apache/superset/pull/15349/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvU2VsZWN0L1NlbGVjdC50c3g=) | `0.00% <0.00%> (ø)` | |
| [...et-frontend/src/components/CertifiedIcon/index.tsx](https://codecov.io/gh/apache/superset/pull/15349/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvQ2VydGlmaWVkSWNvbi9pbmRleC50c3g=) | `100.00% <0.00%> (ø)` | |
| [...et-frontend/src/dashboard/actions/dashboardInfo.ts](https://codecov.io/gh/apache/superset/pull/15349/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9hY3Rpb25zL2Rhc2hib2FyZEluZm8udHM=) | `47.05% <0.00%> (ø)` | |
| [...frontend/src/views/CRUD/alert/AlertReportModal.tsx](https://codecov.io/gh/apache/superset/pull/15349/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3ZpZXdzL0NSVUQvYWxlcnQvQWxlcnRSZXBvcnRNb2RhbC50c3g=) | `61.80% <0.00%> (ø)` | |
| [...ntend/src/views/CRUD/annotation/AnnotationList.tsx](https://codecov.io/gh/apache/superset/pull/15349/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3ZpZXdzL0NSVUQvYW5ub3RhdGlvbi9Bbm5vdGF0aW9uTGlzdC50c3g=) | `76.92% <0.00%> (ø)` | |
| [...tend/src/views/CRUD/annotation/AnnotationModal.tsx](https://codecov.io/gh/apache/superset/pull/15349/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3ZpZXdzL0NSVUQvYW5ub3RhdGlvbi9Bbm5vdGF0aW9uTW9kYWwudHN4) | `62.96% <0.00%> (ø)` | |
| [.../src/views/CRUD/data/savedquery/SavedQueryList.tsx](https://codecov.io/gh/apache/superset/pull/15349/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3ZpZXdzL0NSVUQvZGF0YS9zYXZlZHF1ZXJ5L1NhdmVkUXVlcnlMaXN0LnRzeA==) | `72.91% <0.00%> (ø)` | |
| [...src/filters/components/Range/RangeFilterPlugin.tsx](https://codecov.io/gh/apache/superset/pull/15349/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2ZpbHRlcnMvY29tcG9uZW50cy9SYW5nZS9SYW5nZUZpbHRlclBsdWdpbi50c3g=) | `90.90% <0.00%> (ø)` | |
| ... and [9 more](https://codecov.io/gh/apache/superset/pull/15349/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/15349?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/15349?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [b89ee0c...3c51ba5](https://codecov.io/gh/apache/superset/pull/15349?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] graceguo-supercat commented on pull request #15349: chore: Bump @svgr/webpack to 5.5.0
Posted by GitBox <gi...@apache.org>.
graceguo-supercat commented on pull request #15349:
URL: https://github.com/apache/superset/pull/15349#issuecomment-872559892
thank you @kgabryje @nytai and @rusackas for investigation!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] rusackas commented on pull request #15349: chore: Bump @svgr/webpack to 5.5.0
Posted by GitBox <gi...@apache.org>.
rusackas commented on pull request #15349:
URL: https://github.com/apache/superset/pull/15349#issuecomment-872412989
I agree that reverting this for now is probably the right approach if it's causing pain, and we can re-address it in a new PR or series of PRs. I fear that many issues of this type are indicating a need to upgrade to Webpack v5, which will likely be a large effort.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] rusackas commented on pull request #15349: chore: Bump @svgr/webpack to 5.5.0
Posted by GitBox <gi...@apache.org>.
rusackas commented on pull request #15349:
URL: https://github.com/apache/superset/pull/15349#issuecomment-872413907
Revert PR opened @graceguo-supercat - https://github.com/apache/superset/pull/15508
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] graceguo-supercat commented on pull request #15349: chore: Bump @svgr/webpack to 5.5.0
Posted by GitBox <gi...@apache.org>.
graceguo-supercat commented on pull request #15349:
URL: https://github.com/apache/superset/pull/15349#issuecomment-871757352
Hi @kgabryje, we saw some errors when we tried to deploy latest master branch to airbnb production. the error is like ```
[2021-06-30T01:15:09Z] [Jun 30 01:15:09] INFO ==> ERROR in ./src/showSavedQuery/index.jsx
--
| [2021-06-30T01:15:09Z] [Jun 30 01:15:09] INFO ==> Module build failed (from ./node_modules/babel-loader/lib/index.js):
| [2021-06-30T01:15:09Z] [Jun 30 01:15:09] INFO ==> Error: Cannot find module '@emotion/babel-plugin-jsx-pragmatic'
| [2021-06-30T01:15:09Z] [Jun 30 01:15:09] INFO ==> Require stack:
| [2021-06-30T01:15:09Z] [Jun 30 01:15:09] INFO ==> - /srv/superset-internal/superset-fork/superset-frontend/node_modules/@emotion/babel-preset-css-prop/dist/emotion-babel-preset-css-prop.cjs.prod.js
| [2021-06-30T01:15:09Z] [Jun 30 01:15:09] INFO ==> - /srv/superset-internal/superset-fork/superset-frontend/node_modules/@emotion/babel-preset-css-prop/dist/emotion-babel-preset-css-prop.cjs.js
| [2021-06-30T01:15:09Z] [Jun 30 01:15:09] INFO ==> - /srv/superset-internal/superset-fork/superset-frontend/node_modules/@babel/core/lib/config/files/plugins.js
| [2021-06-30T01:15:09Z] [Jun 30 01:15:09] INFO ==> - /srv/superset-internal/superset-fork/superset-frontend/node_modules/@babel/core/lib/config/files/index.js
...
```
we used npm version `7.12`. If we revert this PR then build successful. Do you know anyway to fix above error? Why do we need this webpack upgrade? thanks!
cc @michellethomas @john-bodley
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] kgabryje commented on pull request #15349: chore: Bump @svgr/webpack to 5.5.0
Posted by GitBox <gi...@apache.org>.
kgabryje commented on pull request #15349:
URL: https://github.com/apache/superset/pull/15349#issuecomment-872044041
Yes, I bumped that version to fix a vulnerability reported by dependabot. That error is surprising since the build on CI has passed... and I can't see `showSavedQuery/index.js` being used anywhere. Anyways, I opened a PR which adds the missing dependency: https://github.com/apache/superset/pull/15491. I'd appreciate it if you took a look
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] kgabryje commented on pull request #15349: chore: Bump @svgr/webpack to 5.5.0
Posted by GitBox <gi...@apache.org>.
kgabryje commented on pull request #15349:
URL: https://github.com/apache/superset/pull/15349#issuecomment-872110796
Adding `@emotion/babel-plugin-jsx-pragmatic` triggered multiple build errors on CI, which seem unrelated. I think debugging that might not be trivial, so for now I'd propose reverting this PR and revisiting the issue later.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] nytai commented on pull request #15349: chore: Bump @svgr/webpack to 5.5.0
Posted by GitBox <gi...@apache.org>.
nytai commented on pull request #15349:
URL: https://github.com/apache/superset/pull/15349#issuecomment-871765921
pretty sure this upgrade was due to a security vulnerability in the current installed version. Looks like the issue is missing dependency`@emotion/babel-plugin-jsx-pragmatic`, we can probably just add that dependency and it should work.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] graceguo-supercat edited a comment on pull request #15349: chore: Bump @svgr/webpack to 5.5.0
Posted by GitBox <gi...@apache.org>.
graceguo-supercat edited a comment on pull request #15349:
URL: https://github.com/apache/superset/pull/15349#issuecomment-871757352
Hi @kgabryje, we saw some errors when we tried to deploy latest master branch to airbnb production. the error is like
```
[2021-06-30T01:15:09Z] [Jun 30 01:15:09] INFO ==> ERROR in ./src/showSavedQuery/index.jsx
--
| [2021-06-30T01:15:09Z] [Jun 30 01:15:09] INFO ==> Module build failed (from ./node_modules/babel-loader/lib/index.js):
| [2021-06-30T01:15:09Z] [Jun 30 01:15:09] INFO ==> Error: Cannot find module '@emotion/babel-plugin-jsx-pragmatic'
| [2021-06-30T01:15:09Z] [Jun 30 01:15:09] INFO ==> Require stack:
| [2021-06-30T01:15:09Z] [Jun 30 01:15:09] INFO ==> - /srv/superset-internal/superset-fork/superset-frontend/node_modules/@emotion/babel-preset-css-prop/dist/emotion-babel-preset-css-prop.cjs.prod.js
| [2021-06-30T01:15:09Z] [Jun 30 01:15:09] INFO ==> - /srv/superset-internal/superset-fork/superset-frontend/node_modules/@emotion/babel-preset-css-prop/dist/emotion-babel-preset-css-prop.cjs.js
| [2021-06-30T01:15:09Z] [Jun 30 01:15:09] INFO ==> - /srv/superset-internal/superset-fork/superset-frontend/node_modules/@babel/core/lib/config/files/plugins.js
| [2021-06-30T01:15:09Z] [Jun 30 01:15:09] INFO ==> - /srv/superset-internal/superset-fork/superset-frontend/node_modules/@babel/core/lib/config/files/index.js
...
```
we used npm version `7.12`. If we revert this PR then build successful. Do you know anyway to fix above error? Why do we need this webpack upgrade? thanks!
cc @michellethomas @john-bodley
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org