[GitHub] [flink] StephanEwen commented on a change in pull request #8756: [FLINK-12406] [Runtime] Report BLOCKING_PERSISTENT result partition meta back to client

[GitBox <gi...@apache.org>]

StephanEwen commented on a change in pull request #8756: [FLINK-12406] [Runtime] Report BLOCKING_PERSISTENT result partition meta back to client
URL: https://github.com/apache/flink/pull/8756#discussion_r299700721
 
 

 ##########
 File path: flink-runtime/src/main/java/org/apache/flink/runtime/executiongraph/ExecutionGraph.java
 ##########
 @@ -814,6 +820,69 @@ public Executor getFutureExecutor() {
 				entry -> serializeAccumulator(entry.getKey(), entry.getValue())));
 	}
 
+	@Override
+	public BlockingPersistentResultPartitionMeta getBlockingPersistentResultPartitionMeta() {
+		Map<AbstractID, Map<AbstractID, ResultPartitionDescriptor>> resultPartitionDescriptors = new HashMap<>();
+
+		// keep record of all failed IntermediateDataSetID
+		Set<AbstractID> failedIntermediateDataSetIds = new HashSet<>();
+
+		for (ExecutionVertex executionVertex : getAllExecutionVertices()) {
+			for (IntermediateResultPartition intermediateResultPartition : executionVertex.getProducedPartitions().values()) {
+				if (intermediateResultPartition.getResultType() == ResultPartitionType.BLOCKING_PERSISTENT) {
+					try {
+						addLocation(resultPartitionDescriptors, intermediateResultPartition);
+					} catch (Throwable throwable) {
+						LOG.error("Failed to get location of ResultPartition: " + intermediateResultPartition.getPartitionId(), throwable);
+						failedIntermediateDataSetIds.add(
+							new AbstractID(intermediateResultPartition.getIntermediateResult().getId()));
+					}
+				}
+			}
+		}
+
+		return new BlockingPersistentResultPartitionMeta(resultPartitionDescriptors, failedIntermediateDataSetIds);
+	}
+
+	/**
+	 *
+	 * @param resultPartitionDescriptors
+	 * @param intermediateResultPartition
+	 * throw exception if any error occurs.
+	 */
+	public void addLocation(
 
 Review comment:
   This utility method should not be in the ExecutionGraph - it just blows up the public signature.
   It should be private static or moved to a utility class.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services