You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@lens.apache.org by Amareshwari Sriramadasu <am...@apache.org> on 2015/03/13 06:21:42 UTC

Review Request 32021: LENS-376 : Use CubeMetastoreClient instead of Hive client in JDBCDriver

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32021/
-----------------------------------------------------------

Review request for lens and Jaideep dhok.


Bugs: LENS-376
    https://issues.apache.org/jira/browse/LENS-376


Repository: lens


Description
-------

Changes include :

- replace underlying storage uses cube client
- Modified existing test to set current db differently than default to set classloader correctly, since CubeMetastoreClient is cached one per db


Diffs
-----

  lens-driver-jdbc/src/main/java/org/apache/lens/driver/jdbc/ColumnarSQLRewriter.java 28dd662 
  lens-driver-jdbc/src/test/java/org/apache/lens/driver/jdbc/TestColumnarSQLRewriter.java f62170f 

Diff: https://reviews.apache.org/r/32021/diff/


Testing
-------

Ran examples in separate db than default.

All unit tests pass.

[INFO] ------------------------------------------------------------------------
[INFO] Reactor Summary:
[INFO] 
[INFO] Lens Checkstyle Rules ............................. SUCCESS [2.349s]
[INFO] Lens .............................................. SUCCESS [2.672s]
[INFO] Lens API .......................................... SUCCESS [5.722s]
[INFO] Lens API for server and extensions ................ SUCCESS [6.393s]
[INFO] Lens Cube ......................................... SUCCESS [2:20.057s]
[INFO] Lens DB storage ................................... SUCCESS [10.359s]
[INFO] Lens Query Library ................................ SUCCESS [4.666s]
[INFO] Lens Hive Driver .................................. SUCCESS [2:36.472s]
[INFO] Lens Driver for JDBC .............................. SUCCESS [25.415s]
[INFO] Lens Server ....................................... SUCCESS [4:21.393s]
[INFO] Lens client ....................................... SUCCESS [20.829s]
[INFO] Lens CLI .......................................... SUCCESS [1:49.844s]
[INFO] Lens Examples ..................................... SUCCESS [0.876s]
[INFO] Lens Distribution ................................. SUCCESS [9.497s]
[INFO] Lens ML Lib ....................................... SUCCESS [44.923s]
[INFO] Lens Regression ................................... SUCCESS [0.436s]
[INFO] ------------------------------------------------------------------------
[INFO] BUILD SUCCESS
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 13:22.847s
[INFO] Finished at: Fri Mar 13 05:20:00 UTC 2015
[INFO] Final Memory: 113M/877M
[INFO] ------------------------------------------------------------------------


Thanks,

Amareshwari Sriramadasu


Re: Review Request 32021: LENS-376 : Use CubeMetastoreClient instead of Hive client in JDBCDriver

Posted by Jaideep dhok <ja...@inmobi.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32021/#review76524
-----------------------------------------------------------

Ship it!


Ship It!

- Jaideep dhok


On March 13, 2015, 5:21 a.m., Amareshwari Sriramadasu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/32021/
> -----------------------------------------------------------
> 
> (Updated March 13, 2015, 5:21 a.m.)
> 
> 
> Review request for lens and Jaideep dhok.
> 
> 
> Bugs: LENS-376
>     https://issues.apache.org/jira/browse/LENS-376
> 
> 
> Repository: lens
> 
> 
> Description
> -------
> 
> Changes include :
> 
> - replace underlying storage uses cube client
> - Modified existing test to set current db differently than default to set classloader correctly, since CubeMetastoreClient is cached one per db
> 
> 
> Diffs
> -----
> 
>   lens-driver-jdbc/src/main/java/org/apache/lens/driver/jdbc/ColumnarSQLRewriter.java 28dd662 
>   lens-driver-jdbc/src/test/java/org/apache/lens/driver/jdbc/TestColumnarSQLRewriter.java f62170f 
> 
> Diff: https://reviews.apache.org/r/32021/diff/
> 
> 
> Testing
> -------
> 
> Ran examples in separate db than default.
> 
> All unit tests pass.
> 
> [INFO] ------------------------------------------------------------------------
> [INFO] Reactor Summary:
> [INFO] 
> [INFO] Lens Checkstyle Rules ............................. SUCCESS [2.349s]
> [INFO] Lens .............................................. SUCCESS [2.672s]
> [INFO] Lens API .......................................... SUCCESS [5.722s]
> [INFO] Lens API for server and extensions ................ SUCCESS [6.393s]
> [INFO] Lens Cube ......................................... SUCCESS [2:20.057s]
> [INFO] Lens DB storage ................................... SUCCESS [10.359s]
> [INFO] Lens Query Library ................................ SUCCESS [4.666s]
> [INFO] Lens Hive Driver .................................. SUCCESS [2:36.472s]
> [INFO] Lens Driver for JDBC .............................. SUCCESS [25.415s]
> [INFO] Lens Server ....................................... SUCCESS [4:21.393s]
> [INFO] Lens client ....................................... SUCCESS [20.829s]
> [INFO] Lens CLI .......................................... SUCCESS [1:49.844s]
> [INFO] Lens Examples ..................................... SUCCESS [0.876s]
> [INFO] Lens Distribution ................................. SUCCESS [9.497s]
> [INFO] Lens ML Lib ....................................... SUCCESS [44.923s]
> [INFO] Lens Regression ................................... SUCCESS [0.436s]
> [INFO] ------------------------------------------------------------------------
> [INFO] BUILD SUCCESS
> [INFO] ------------------------------------------------------------------------
> [INFO] Total time: 13:22.847s
> [INFO] Finished at: Fri Mar 13 05:20:00 UTC 2015
> [INFO] Final Memory: 113M/877M
> [INFO] ------------------------------------------------------------------------
> 
> 
> Thanks,
> 
> Amareshwari Sriramadasu
> 
>