[GitHub] [activemq-artemis] meierhofer08 commented on pull request #3486: ARTEMIS-3174: Set new connection on ServerSession during reattachment

[GitBox <gi...@apache.org>]

meierhofer08 commented on pull request #3486:
URL: https://github.com/apache/activemq-artemis/pull/3486#issuecomment-797288577


   That would be good of course. The only problem is that I'm not familiar with the testing structure of Artemis/how to set up mocks for testing etc. It would help if you could point me into a direction for where to place the test and how to achieve what I want to test.
   
   The test would need to:
   - Set up an Artemis core client connection to a broker with a confirmationWindowSize != -1
   - Simulate connection loss to broker, the client has to detect the connection failure ("Connection failure to ... has been detected")
   - After less than the connectionTTL (default 60 seconds), allow connection to broker again -> client fails over
   - Client tries to reattach all the sessions, server transfers the sessions
   - Afterwards, check if the remotingConnection is set correctly (has the new connectionID) on every object connected to the session
   
   It could even be simplified to a "component test" only on the broker where you have a session with an "old" connection, and then do a "ServerSessionPacketHandler.transferConnection" suppyling a new connection. Afterwards, check if the all the objects related to the sessionHandler (itself, the channel, the serverSession) have the new connection assigned.
   
   If you provide me with enough details, I might be able to write the test. Otherwise, it would maybe be easier if you write the test as you know the code in more detail.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org