You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@sling.apache.org by "Radu Cotescu (Jira)" <ji...@apache.org> on 2019/12/06 12:06:00 UTC

[jira] [Commented] (SLING-8892) Unwrap LazyBindings.Supplier values in the RhinoJavaScriptEngine

    [ https://issues.apache.org/jira/browse/SLING-8892?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16989676#comment-16989676 ] 

Radu Cotescu commented on SLING-8892:
-------------------------------------

A first version of this enhancement was pushed in [commit e2c0d0e|https://github.com/apache/sling-org-apache-sling-scripting-javascript/commit/e2c0d0e678789e14bfd973c12e76daff71f86191], as part of SLING-8865. However, that didn't take into consideration the fact that a {{LazyBindings.Supplier}} can potentially return {{null}} and Rhino's {{ScriptContext}} cannot work with {{nulls}}.

> Unwrap LazyBindings.Supplier values in the RhinoJavaScriptEngine
> ----------------------------------------------------------------
>
>                 Key: SLING-8892
>                 URL: https://issues.apache.org/jira/browse/SLING-8892
>             Project: Sling
>          Issue Type: Improvement
>          Components: Scripting
>            Reporter: Radu Cotescu
>            Assignee: Radu Cotescu
>            Priority: Major
>             Fix For: Scripting JavaScript 3.1.2
>
>
> Starting with SLING-8737, {{BindingsValuesProviders}} can now take advantage of {{LazyBindings}} and provide values through {{LazyBindings.Supplier}} instances. The {{RhinoJavaScriptEngine}} should correctly unwrap these values when defining the scope for a JavaScript script.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)