You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@metron.apache.org by cestella <gi...@git.apache.org> on 2016/08/24 21:27:22 UTC
[GitHub] incubator-metron pull request #229: METRON-374: Add appropriate bundled 3rd ...
GitHub user cestella opened a pull request:
https://github.com/apache/incubator-metron/pull/229
METRON-374: Add appropriate bundled 3rd party licenses to NOTICE and LICENSE where appropriate
This PR ensures:
* Every place where we create a shaded jar, we must add appropriate links to a binary distribution LICENSE file in the META-INF directory to indicate we are bundling
* When new components are added, we must ensure that we have a handle on licensing to ensure they are not prohibited.
From here on, if you add a dependency, you must add a line to the `dependencies_with_url.csv`. Travis will take the transitive dependency list and check against this file to ensure that it's listed. This will make sure we track dependencies.
Also, `dependencies_with_url.csv` can be used with the `build_utils/create_bundled_licenses.sh` to generate the binary licenses that live inside of the shaded jars.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/cestella/incubator-metron METRON-374
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-metron/pull/229.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #229
----
commit c572e460d9fb1e1b24bfbc88562ba366c7a0987a
Author: cstella <ce...@gmail.com>
Date: 2016-08-24T21:22:48Z
METRON-374: Add appropriate bundled 3rd party licenses to NOTICE and LICENSE where appropriate
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-metron pull request #229: METRON-374: Add appropriate bundled 3rd ...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/incubator-metron/pull/229
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-metron issue #229: METRON-374: Add appropriate bundled 3rd party l...
Posted by james-sirota <gi...@git.apache.org>.
Github user james-sirota commented on the issue:
https://github.com/apache/incubator-metron/pull/229
+1 by inspection
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-metron issue #229: METRON-374: Add appropriate bundled 3rd party l...
Posted by cestella <gi...@git.apache.org>.
Github user cestella commented on the issue:
https://github.com/apache/incubator-metron/pull/229
Thanks @nickwallen, I added appropriate documentation and updated to current master.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-metron issue #229: METRON-374: Add appropriate bundled 3rd party l...
Posted by nickwallen <gi...@git.apache.org>.
Github user nickwallen commented on the issue:
https://github.com/apache/incubator-metron/pull/229
It would be good to add a quick README.md under `build_utils` that outlines what the scripts do and how to use them. It would also be a good place to add the guidance that you provide in this PR itself.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---