You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2020/05/27 04:01:59 UTC

[GitHub] [pulsar] Omega-Ariston opened a new pull request #7038: [website][issue7002]fixes RESTAPIs and Cli button not working.

Omega-Ariston opened a new pull request #7038:
URL: https://github.com/apache/pulsar/pull/7038


   Fixes #7002 
   
   ### Motivation
   
   the `REST APIs` and `Cli` button only work in English ver. website.
   
   ### Modifications
   
   Currently, the site retrieve user selected version by `document.querySelector('a[href="/en/versions"]')`. Therefore, when the language changes, this path will no longer exists(it will become `a[href="/zh-CN/versions"]` for Chinese ver. for example).
   So I changed another way that achieves the same goal, with the help of `logo` class.
   The downside is that this new line of code might be ambiguous. So I added another line to comment it.
   
   ### Verifying this change
   
   - [ yes ] Make sure that the change passes the CI checks.
   
   *(Please pick either of the following options)*
   
   This change is a trivial rework / code cleanup without any test coverage.
   
   ### Does this pull request potentially affect one of the following parts:
   
   *If `yes` was chosen, please highlight the changes*
   
     - Dependencies (does it add or upgrade a dependency): (no)
     - The public API: (no)
     - The schema: (no)
     - The default values of configurations: (no)
     - The wire protocol: (no)
     - The rest endpoints: (no)
     - The admin cli options: (no)
     - Anything that affects deployment: (no)
   
   ### Documentation
   
     - Does this pull request introduce a new feature? (no)
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar] sijie merged pull request #7038: [website][issue7002]fixes RESTAPIs and Cli button not working.

Posted by GitBox <gi...@apache.org>.
sijie merged pull request #7038:
URL: https://github.com/apache/pulsar/pull/7038


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org