[GitHub] [incubator-doris] yiguolei commented on a diff in pull request #9243: global dict thrift definition

[GitBox <gi...@apache.org>]

yiguolei commented on code in PR #9243:
URL: https://github.com/apache/incubator-doris/pull/9243#discussion_r859262594


##########
gensrc/thrift/PaloInternalService.thrift:
##########
@@ -274,8 +274,18 @@ struct TTxnParams {
   10: optional double max_filter_ratio
 }
 
-// ExecPlanFragment
+// Definition of global dict, global dict is used to accelerate query performance of low cardinality data
+struct TColumnDict {
+  1: optional Types.TPrimitiveType type
+  2: list<string> str_dict  // map one string to a integer, using offset as id
+}
 
+struct TGlobalDict {
+  1: optional map<i32, TColumnDict> dicts,  // map dict_id to column dict

Review Comment:
   Maybe need. Some times I find there are sql queries that have more than 10k lines, I am afraid there are many dicts. And the slot id has int32 type.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org