You are viewing a plain text version of this content. The canonical link for it is here.
Posted to log4j-dev@logging.apache.org by Remko Popma <re...@gmail.com> on 2013/08/16 03:38:26 UTC
Re: svn commit: r1514264 - /logging/log4j/log4j2/trunk/flume-ng/src/main/java/org/apache/logging/log4j/flume/appender/FlumeConfigurationBuilder.java
Gary, just FYI, that looks like tab characters instead of spaces for the
indents.
On Thu, Aug 15, 2013 at 10:32 PM, <gg...@apache.org> wrote:
> Author: ggregory
> Date: Thu Aug 15 13:32:38 2013
> New Revision: 1514264
>
> URL: http://svn.apache.org/r1514264
> Log:
> Statement unnecessarily nested within else clause.
>
> Modified:
>
> logging/log4j/log4j2/trunk/flume-ng/src/main/java/org/apache/logging/log4j/flume/appender/FlumeConfigurationBuilder.java
>
> Modified:
> logging/log4j/log4j2/trunk/flume-ng/src/main/java/org/apache/logging/log4j/flume/appender/FlumeConfigurationBuilder.java
> URL:
> http://svn.apache.org/viewvc/logging/log4j/log4j2/trunk/flume-ng/src/main/java/org/apache/logging/log4j/flume/appender/FlumeConfigurationBuilder.java?rev=1514264&r1=1514263&r2=1514264&view=diff
>
> ==============================================================================
> ---
> logging/log4j/log4j2/trunk/flume-ng/src/main/java/org/apache/logging/log4j/flume/appender/FlumeConfigurationBuilder.java
> (original)
> +++
> logging/log4j/log4j2/trunk/flume-ng/src/main/java/org/apache/logging/log4j/flume/appender/FlumeConfigurationBuilder.java
> Thu Aug 15 13:32:38 2013
> @@ -260,11 +260,10 @@ public class FlumeConfigurationBuilder {
> if (sinkUser != null) {
> throw new
> ConfigurationException(String.format(
> "Sink %s of group %s already in use by
> group %s", sink, groupName, sinkUser));
> - } else {
> - throw new
> ConfigurationException(String.format(
> - "Sink %s of group %s does not exist or is
> not properly configured", sink,
> - groupName));
> }
> + throw new
> ConfigurationException(String.format(
> + "Sink %s of group %s
> does not exist or is not properly configured", sink,
> + groupName));
> }
> groupSinks.add(s);
> usedSinks.put(sink, groupName);
>
>
>
Re: svn commit: r1514264 - /logging/log4j/log4j2/trunk/flume-ng/src/main/java/org/apache/logging/log4j/flume/appender/FlumeConfigurationBuilder.java
Posted by Remko Popma <re...@gmail.com>.
I can fix it np.
Was that an IDE setting issue?
On Fri, Aug 16, 2013 at 12:19 PM, Gary Gregory <ga...@gmail.com>wrote:
> Arg! I'll fix tomorrow unless you get to it.
>
> Gary
>
> On Aug 15, 2013, at 21:38, Remko Popma <re...@gmail.com> wrote:
>
> Gary, just FYI, that looks like tab characters instead of spaces for the
> indents.
>
>
> On Thu, Aug 15, 2013 at 10:32 PM, <gg...@apache.org> wrote:
>
>> Author: ggregory
>> Date: Thu Aug 15 13:32:38 2013
>> New Revision: 1514264
>>
>> URL: http://svn.apache.org/r1514264
>> Log:
>> Statement unnecessarily nested within else clause.
>>
>> Modified:
>>
>> logging/log4j/log4j2/trunk/flume-ng/src/main/java/org/apache/logging/log4j/flume/appender/FlumeConfigurationBuilder.java
>>
>> Modified:
>> logging/log4j/log4j2/trunk/flume-ng/src/main/java/org/apache/logging/log4j/flume/appender/FlumeConfigurationBuilder.java
>> URL:
>> http://svn.apache.org/viewvc/logging/log4j/log4j2/trunk/flume-ng/src/main/java/org/apache/logging/log4j/flume/appender/FlumeConfigurationBuilder.java?rev=1514264&r1=1514263&r2=1514264&view=diff
>>
>> ==============================================================================
>> ---
>> logging/log4j/log4j2/trunk/flume-ng/src/main/java/org/apache/logging/log4j/flume/appender/FlumeConfigurationBuilder.java
>> (original)
>> +++
>> logging/log4j/log4j2/trunk/flume-ng/src/main/java/org/apache/logging/log4j/flume/appender/FlumeConfigurationBuilder.java
>> Thu Aug 15 13:32:38 2013
>> @@ -260,11 +260,10 @@ public class FlumeConfigurationBuilder {
>> if (sinkUser != null) {
>> throw new
>> ConfigurationException(String.format(
>> "Sink %s of group %s already in use by
>> group %s", sink, groupName, sinkUser));
>> - } else {
>> - throw new
>> ConfigurationException(String.format(
>> - "Sink %s of group %s does not exist or
>> is not properly configured", sink,
>> - groupName));
>> }
>> + throw new
>> ConfigurationException(String.format(
>> + "Sink %s of group %s
>> does not exist or is not properly configured", sink,
>> + groupName));
>> }
>> groupSinks.add(s);
>> usedSinks.put(sink, groupName);
>>
>>
>>
>
Re: svn commit: r1514264 - /logging/log4j/log4j2/trunk/flume-ng/src/main/java/org/apache/logging/log4j/flume/appender/FlumeConfigurationBuilder.java
Posted by Gary Gregory <ga...@gmail.com>.
Arg! I'll fix tomorrow unless you get to it.
Gary
On Aug 15, 2013, at 21:38, Remko Popma <re...@gmail.com> wrote:
Gary, just FYI, that looks like tab characters instead of spaces for the
indents.
On Thu, Aug 15, 2013 at 10:32 PM, <gg...@apache.org> wrote:
> Author: ggregory
> Date: Thu Aug 15 13:32:38 2013
> New Revision: 1514264
>
> URL: http://svn.apache.org/r1514264
> Log:
> Statement unnecessarily nested within else clause.
>
> Modified:
>
> logging/log4j/log4j2/trunk/flume-ng/src/main/java/org/apache/logging/log4j/flume/appender/FlumeConfigurationBuilder.java
>
> Modified:
> logging/log4j/log4j2/trunk/flume-ng/src/main/java/org/apache/logging/log4j/flume/appender/FlumeConfigurationBuilder.java
> URL:
> http://svn.apache.org/viewvc/logging/log4j/log4j2/trunk/flume-ng/src/main/java/org/apache/logging/log4j/flume/appender/FlumeConfigurationBuilder.java?rev=1514264&r1=1514263&r2=1514264&view=diff
>
> ==============================================================================
> ---
> logging/log4j/log4j2/trunk/flume-ng/src/main/java/org/apache/logging/log4j/flume/appender/FlumeConfigurationBuilder.java
> (original)
> +++
> logging/log4j/log4j2/trunk/flume-ng/src/main/java/org/apache/logging/log4j/flume/appender/FlumeConfigurationBuilder.java
> Thu Aug 15 13:32:38 2013
> @@ -260,11 +260,10 @@ public class FlumeConfigurationBuilder {
> if (sinkUser != null) {
> throw new
> ConfigurationException(String.format(
> "Sink %s of group %s already in use by
> group %s", sink, groupName, sinkUser));
> - } else {
> - throw new
> ConfigurationException(String.format(
> - "Sink %s of group %s does not exist or is
> not properly configured", sink,
> - groupName));
> }
> + throw new
> ConfigurationException(String.format(
> + "Sink %s of group %s
> does not exist or is not properly configured", sink,
> + groupName));
> }
> groupSinks.add(s);
> usedSinks.put(sink, groupName);
>
>
>