[GitHub] [pulsar] codelipenghui commented on a change in pull request #12830: [broker]Optimize topicMaxMessageSize with topic local cache.

[GitBox <gi...@apache.org>]

codelipenghui commented on a change in pull request #12830:
URL: https://github.com/apache/pulsar/pull/12830#discussion_r754044291



##########
File path: pulsar-broker-common/src/main/java/org/apache/pulsar/broker/ServiceConfiguration.java
##########
@@ -986,9 +986,12 @@
     )
     private int retentionCheckIntervalInSeconds = 120;
 
+    @Deprecated
     @FieldContext(
             category = CATEGORY_SERVER,
-            doc = "Check between intervals to see if max message size of topic policy has updated. default is 60s"
+            deprecated = true,
+            doc = "Check between intervals to see if  of topic policy has updated. default is 60s."
+                + "Note: This is deprecated, max message size is updated by notification."
     )
     private int maxMessageSizeCheckIntervalInSeconds = 60;

Review comment:
       I think we can remove it directly, it will not introduce any compatibility issues after users upgrade to the new version, and please also delete the config from the broker.conf and standalone.conf




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org