You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@lucene.apache.org by ma...@apache.org on 2020/10/17 18:47:35 UTC

[lucene-solr] 04/18: @1004 Enable test method.

This is an automated email from the ASF dual-hosted git repository.

markrmiller pushed a commit to branch reference_impl_dev
in repository https://gitbox.apache.org/repos/asf/lucene-solr.git

commit cd44e39b461619bb59b7b443c067c18af96d0af4
Author: markrmiller@gmail.com <ma...@gmail.com>
AuthorDate: Sat Oct 17 10:15:51 2020 -0500

    @1004 Enable test method.
---
 solr/core/src/test/org/apache/solr/cloud/AddReplicaTest.java | 6 ++----
 1 file changed, 2 insertions(+), 4 deletions(-)

diff --git a/solr/core/src/test/org/apache/solr/cloud/AddReplicaTest.java b/solr/core/src/test/org/apache/solr/cloud/AddReplicaTest.java
index 75af698..ea03d2c 100644
--- a/solr/core/src/test/org/apache/solr/cloud/AddReplicaTest.java
+++ b/solr/core/src/test/org/apache/solr/cloud/AddReplicaTest.java
@@ -148,7 +148,7 @@ public class AddReplicaTest extends SolrCloudTestCase {
   }
 
   @Test
-  @Ignore // nocommit we were not failing on all errors in the http2 solr client - this weirdly keeps failing, saying an asyncid that should be free is already claimed.
+  //@Ignore // nocommit we were not failing on all errors in the http2 solr client - this weirdly keeps failing, saying an asyncid that should be free is already claimed.
   public void test() throws Exception {
     
     String collection = "addreplicatest_coll";
@@ -159,8 +159,6 @@ public class AddReplicaTest extends SolrCloudTestCase {
     create.setMaxShardsPerNode(2);
     cloudClient.request(create);
 
-    cluster.waitForActiveCollection(collection, 0, TimeUnit.MILLISECONDS, 2, 2);
-
     ClusterState clusterState = cloudClient.getZkStateReader().getClusterState();
     DocCollection coll = clusterState.getCollection(collection);
     String sliceName = coll.getSlices().iterator().next().getName();
@@ -194,7 +192,7 @@ public class AddReplicaTest extends SolrCloudTestCase {
     // use waitForFinalState - doesn't exist, just dont do async
    // addReplica.setWaitForFinalState(true);
     int aid2 = asyncId.incrementAndGet();
-    addReplica.process(cloudClient);
+    addReplica.processAsync(Integer.toString(aid2), cloudClient);
     requestStatus = CollectionAdminRequest.requestStatus(Integer.toString(aid2));
     rsp = requestStatus.process(cloudClient);