You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@ratis.apache.org by "adoroszlai (via GitHub)" <gi...@apache.org> on 2026/09/16 08:15:54 UTC

[PR] RATIS-2699. zizmor-action upgrade may break silently [ratis-thirdparty]

adoroszlai opened a new pull request, #195:
URL: https://github.com/apache/ratis-thirdparty/pull/195

   ## What changes were proposed in this pull request?
   
   Rules introduced by new versions of may fail silently in the [PR](https://github.com/apache/ratis-thirdparty/pull/193) that bumps zizmor-action (problem is [reported](https://github.com/apache/ratis-thirdparty/actions/runs/35067715860/job/104701697687#step:3:209) in details, but check still [passes](https://github.com/apache/ratis-thirdparty/actions/runs/35067715860)).  The failure will surface only in [forks](https://github.com/adoroszlai/ratis-thirdparty/actions/runs/35070400137) or in PRs changing the offending workflow files.
   
   With GitHub Advanced Security (the default) problems are reported in the repo's [Code scanning](https://github.com/apache/ratis-thirdparty/security/code-scanning) page.  When this feature is disabled, any problems reported cause the check to fail.
   
   This change keeps Advanced Security only for push events in Apache repo, which allows pull requests touching only `zizmor.yaml` (e.g. for version bump) to catch problems in other files.
   
   https://issues.apache.org/jira/browse/RATIS-2699
   
   ## How was this patch tested?
   
   ### With only the change in `zizmor.yaml`
   
   `zizmor` in fork still fails:
   https://github.com/adoroszlai/ratis-thirdparty/actions/runs/35071480072/job/104713786022
   
   PR run should also fail.
   
   ### After fix of zizmor problems
   
   TBD
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@ratis.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] RATIS-2699. zizmor-action upgrade may break silently [ratis-thirdparty]

Posted by "adoroszlai (via GitHub)" <gi...@apache.org>.
adoroszlai commented on PR #195:
URL: https://github.com/apache/ratis-thirdparty/pull/195#issuecomment-5726352504

   Thanks @amaliujia for reviewing and merging this.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@ratis.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] RATIS-2699. zizmor-action upgrade may break silently [ratis-thirdparty]

Posted by "amaliujia (via GitHub)" <gi...@apache.org>.
amaliujia merged PR #195:
URL: https://github.com/apache/ratis-thirdparty/pull/195


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@ratis.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org