You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@sentry.apache.org by Lei Xu <le...@cloudera.com> on 2017/03/13 21:57:12 UTC
Review Request 57570: SENTRY-1644. Partition ACLs disappear after
renaming Hive table with partitions
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57570/
-----------------------------------------------------------
Review request for sentry, Alexander Kolbasov and Hao Hao.
Bugs: SENTRY-1644
https://issues.apache.org/jira/browse/SENTRY-1644
Repository: sentry
Description
-------
After rename Hive table with partitions, ACLs on the partition paths disappear.
It is caused by the fact that renaming on sentry does not move any sub-namespace.
Diffs
-----
sentry-hdfs/sentry-hdfs-common/src/main/java/org/apache/sentry/hdfs/HMSPaths.java e4850f4ee039f011de370ca6b2618161150645de
sentry-hdfs/sentry-hdfs-common/src/test/java/org/apache/sentry/hdfs/TestHMSPaths.java 0dee1028ac852b12b109e875b2cbbb0bd2efbe03
Diff: https://reviews.apache.org/r/57570/diff/1/
Testing
-------
mvn test -Dtest=TestHMSPaths
Thanks,
Lei Xu
Re: Review Request 57570: SENTRY-1644. Partition ACLs disappear after
renaming Hive table with partitions
Posted by Lei Xu <le...@cloudera.com>.
> On March 24, 2017, 4:55 p.m., Alexander Kolbasov wrote:
> > sentry-hdfs/sentry-hdfs-common/src/main/java/org/apache/sentry/hdfs/HMSPaths.java
> > Lines 182 (patched)
> > <https://reviews.apache.org/r/57570/diff/2/?file=1672108#file1672108line184>
> >
> > What does it mean for path elements to point to the direct parent? May be you can put some example here? Also, from the code it looks like the elements are ordered in a specific way - can you document this as well and/or show example?
Okey, I added comments and one example to this function.
> On March 24, 2017, 4:55 p.m., Alexander Kolbasov wrote:
> > sentry-hdfs/sentry-hdfs-common/src/main/java/org/apache/sentry/hdfs/HMSPaths.java
> > Lines 184 (patched)
> > <https://reviews.apache.org/r/57570/diff/2/?file=1672108#file1672108line186>
> >
> > From the code it returns the parent of the *last* element
I add more comments to describe the purposed of this function. It basically acts as "mkdir -p /path/to/parent".
> On March 24, 2017, 4:55 p.m., Alexander Kolbasov wrote:
> > sentry-hdfs/sentry-hdfs-common/src/main/java/org/apache/sentry/hdfs/HMSPaths.java
> > Line 195 (original), 214 (patched)
> > <https://reviews.apache.org/r/57570/diff/2/?file=1672108#file1672108line216>
> >
> > Why do you need subList() here?
I changed the signature of `createParent()` to take all the path elemenents from the given event, and creates / returns its parent entry.
> On March 24, 2017, 4:55 p.m., Alexander Kolbasov wrote:
> > sentry-hdfs/sentry-hdfs-common/src/main/java/org/apache/sentry/hdfs/HMSPaths.java
> > Line 587 (original), 629 (patched)
> > <https://reviews.apache.org/r/57570/diff/2/?file=1672108#file1672108line650>
> >
> > Why do you need subList() here?
Ok, I will change the createParent() to take elements to the desired entry, instead of the parent entry. Hope that it can make the goal of the function clearer.
- Lei
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57570/#review170064
-----------------------------------------------------------
On March 22, 2017, 2:27 p.m., Lei Xu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/57570/
> -----------------------------------------------------------
>
> (Updated March 22, 2017, 2:27 p.m.)
>
>
> Review request for sentry, Alexander Kolbasov and Hao Hao.
>
>
> Bugs: SENTRY-1644
> https://issues.apache.org/jira/browse/SENTRY-1644
>
>
> Repository: sentry
>
>
> Description
> -------
>
> After rename Hive table with partitions, ACLs on the partition paths disappear.
>
> It is caused by the fact that renaming on sentry does not move any sub-namespace.
>
>
> Diffs
> -----
>
> sentry-hdfs/sentry-hdfs-common/src/main/java/org/apache/sentry/hdfs/HMSPaths.java 6d2ab23c3f65af5430ea02563e13c4c4c49aa1c6
> sentry-hdfs/sentry-hdfs-common/src/test/java/org/apache/sentry/hdfs/TestHMSPaths.java 0dee1028ac852b12b109e875b2cbbb0bd2efbe03
> sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/hdfs/TestHDFSIntegrationAdvanced.java d079628a0e549e3b179c7a321f82bcf6b580da43
>
>
> Diff: https://reviews.apache.org/r/57570/diff/2/
>
>
> Testing
> -------
>
> mvn test -Dtest=TestHMSPaths
>
>
> Thanks,
>
> Lei Xu
>
>
Re: Review Request 57570: SENTRY-1644. Partition ACLs disappear after
renaming Hive table with partitions
Posted by Alexander Kolbasov <ak...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57570/#review170064
-----------------------------------------------------------
sentry-hdfs/sentry-hdfs-common/src/main/java/org/apache/sentry/hdfs/HMSPaths.java
Lines 181 (patched)
<https://reviews.apache.org/r/57570/#comment242838>
There is no documentation in this class about the parent-child relationships - since you just looked at this - can you add some text either here or at the class level explaining what is a parent and what is a child?
sentry-hdfs/sentry-hdfs-common/src/main/java/org/apache/sentry/hdfs/HMSPaths.java
Lines 182 (patched)
<https://reviews.apache.org/r/57570/#comment242839>
What does it mean for path elements to point to the direct parent? May be you can put some example here? Also, from the code it looks like the elements are ordered in a specific way - can you document this as well and/or show example?
sentry-hdfs/sentry-hdfs-common/src/main/java/org/apache/sentry/hdfs/HMSPaths.java
Lines 184 (patched)
<https://reviews.apache.org/r/57570/#comment242842>
From the code it returns the parent of the *last* element
sentry-hdfs/sentry-hdfs-common/src/main/java/org/apache/sentry/hdfs/HMSPaths.java
Line 195 (original), 214 (patched)
<https://reviews.apache.org/r/57570/#comment242845>
Why do you need subList() here?
sentry-hdfs/sentry-hdfs-common/src/main/java/org/apache/sentry/hdfs/HMSPaths.java
Lines 325 (patched)
<https://reviews.apache.org/r/57570/#comment242848>
Didn't you just check for this in line 319?
sentry-hdfs/sentry-hdfs-common/src/main/java/org/apache/sentry/hdfs/HMSPaths.java
Line 298 (original), 336 (patched)
<https://reviews.apache.org/r/57570/#comment242847>
This isn't related, but since you are touching this file - why do you call remove() if you know that getChildren() is empty? Can it be that the condition is reversed here by any chance?
sentry-hdfs/sentry-hdfs-common/src/main/java/org/apache/sentry/hdfs/HMSPaths.java
Line 579 (original), 624 (patched)
<https://reviews.apache.org/r/57570/#comment242851>
formatting - space between // and text
sentry-hdfs/sentry-hdfs-common/src/main/java/org/apache/sentry/hdfs/HMSPaths.java
Line 587 (original), 629 (patched)
<https://reviews.apache.org/r/57570/#comment242853>
Why do you need subList() here?
- Alexander Kolbasov
On March 22, 2017, 9:27 p.m., Lei Xu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/57570/
> -----------------------------------------------------------
>
> (Updated March 22, 2017, 9:27 p.m.)
>
>
> Review request for sentry, Alexander Kolbasov and Hao Hao.
>
>
> Bugs: SENTRY-1644
> https://issues.apache.org/jira/browse/SENTRY-1644
>
>
> Repository: sentry
>
>
> Description
> -------
>
> After rename Hive table with partitions, ACLs on the partition paths disappear.
>
> It is caused by the fact that renaming on sentry does not move any sub-namespace.
>
>
> Diffs
> -----
>
> sentry-hdfs/sentry-hdfs-common/src/main/java/org/apache/sentry/hdfs/HMSPaths.java 6d2ab23c3f65af5430ea02563e13c4c4c49aa1c6
> sentry-hdfs/sentry-hdfs-common/src/test/java/org/apache/sentry/hdfs/TestHMSPaths.java 0dee1028ac852b12b109e875b2cbbb0bd2efbe03
> sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/hdfs/TestHDFSIntegrationAdvanced.java d079628a0e549e3b179c7a321f82bcf6b580da43
>
>
> Diff: https://reviews.apache.org/r/57570/diff/2/
>
>
> Testing
> -------
>
> mvn test -Dtest=TestHMSPaths
>
>
> Thanks,
>
> Lei Xu
>
>
Re: Review Request 57570: SENTRY-1644. Partition ACLs disappear after
renaming Hive table with partitions
Posted by Alexander Kolbasov <ak...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57570/#review171020
-----------------------------------------------------------
Fix it, then Ship it!
Ship It!
sentry-hdfs/sentry-hdfs-common/src/main/java/org/apache/sentry/hdfs/HMSPaths.java
Lines 112 (patched)
<https://reviews.apache.org/r/57570/#comment243852>
Each individual entry
sentry-hdfs/sentry-hdfs-common/src/main/java/org/apache/sentry/hdfs/HMSPaths.java
Lines 114 (patched)
<https://reviews.apache.org/r/57570/#comment243853>
Please axtend this comment to show how the tree is represented (a small example would help) - it isn't clear what is rthe relationship with Entry and the HDFS path.
That aside - the full hdfs path can contain uri prefix - is it always trimmed somewhere before it reaches here?
sentry-hdfs/sentry-hdfs-common/src/main/java/org/apache/sentry/hdfs/HMSPaths.java
Lines 339 (patched)
<https://reviews.apache.org/r/57570/#comment243851>
should it be private?
The return value is never used - is it intended?
- Alexander Kolbasov
On March 28, 2017, 12:24 a.m., Lei Xu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/57570/
> -----------------------------------------------------------
>
> (Updated March 28, 2017, 12:24 a.m.)
>
>
> Review request for sentry, Alexander Kolbasov and Hao Hao.
>
>
> Bugs: SENTRY-1644
> https://issues.apache.org/jira/browse/SENTRY-1644
>
>
> Repository: sentry
>
>
> Description
> -------
>
> After rename Hive table with partitions, ACLs on the partition paths disappear.
>
> It is caused by the fact that renaming on sentry does not move any sub-namespace.
>
>
> Diffs
> -----
>
> sentry-hdfs/sentry-hdfs-common/src/main/java/org/apache/sentry/hdfs/HMSPaths.java 6d2ab23c3f65af5430ea02563e13c4c4c49aa1c6
> sentry-hdfs/sentry-hdfs-common/src/test/java/org/apache/sentry/hdfs/TestHMSPaths.java 0dee1028ac852b12b109e875b2cbbb0bd2efbe03
> sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/hdfs/TestHDFSIntegrationAdvanced.java d079628a0e549e3b179c7a321f82bcf6b580da43
>
>
> Diff: https://reviews.apache.org/r/57570/diff/3/
>
>
> Testing
> -------
>
> mvn test -Dtest=TestHMSPaths
>
>
> File Attachments
> ----------------
>
> SENTRY-1644.003-master.patch
> https://reviews.apache.org/media/uploaded/files/2017/03/28/1b82d5bc-0267-42d3-9a9a-9515ed7cb25e__SENTRY-1644.003-master.patch
>
>
> Thanks,
>
> Lei Xu
>
>
Re: Review Request 57570: SENTRY-1644. Partition ACLs disappear after
renaming Hive table with partitions
Posted by Alexander Kolbasov <ak...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57570/#review171052
-----------------------------------------------------------
Ship it!
Ship It!
- Alexander Kolbasov
On April 4, 2017, 8:54 p.m., Lei Xu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/57570/
> -----------------------------------------------------------
>
> (Updated April 4, 2017, 8:54 p.m.)
>
>
> Review request for sentry, Alexander Kolbasov and Hao Hao.
>
>
> Bugs: SENTRY-1644
> https://issues.apache.org/jira/browse/SENTRY-1644
>
>
> Repository: sentry
>
>
> Description
> -------
>
> After rename Hive table with partitions, ACLs on the partition paths disappear.
>
> It is caused by the fact that renaming on sentry does not move any sub-namespace.
>
>
> Diffs
> -----
>
> sentry-hdfs/sentry-hdfs-common/src/main/java/org/apache/sentry/hdfs/HMSPaths.java 6d2ab23c3f65af5430ea02563e13c4c4c49aa1c6
> sentry-hdfs/sentry-hdfs-common/src/test/java/org/apache/sentry/hdfs/TestHMSPaths.java 0dee1028ac852b12b109e875b2cbbb0bd2efbe03
> sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/hdfs/TestHDFSIntegrationAdvanced.java d079628a0e549e3b179c7a321f82bcf6b580da43
>
>
> Diff: https://reviews.apache.org/r/57570/diff/4/
>
>
> Testing
> -------
>
> mvn test -Dtest=TestHMSPaths
>
>
> File Attachments
> ----------------
>
> SENTRY-1644.003-master.patch
> https://reviews.apache.org/media/uploaded/files/2017/03/28/1b82d5bc-0267-42d3-9a9a-9515ed7cb25e__SENTRY-1644.003-master.patch
>
>
> Thanks,
>
> Lei Xu
>
>
Re: Review Request 57570: SENTRY-1644. Partition ACLs disappear after
renaming Hive table with partitions
Posted by Lei Xu <le...@cloudera.com>.
> On April 6, 2017, 7:05 a.m., Na Li wrote:
> > sentry-hdfs/sentry-hdfs-common/src/main/java/org/apache/sentry/hdfs/HMSPaths.java
> > Lines 360 (patched)
> > <https://reviews.apache.org/r/57570/diff/4/?file=1684578#file1684578line382>
> >
> > comment mentioned to return false if failed, but the code does not return a value.
Good catch, Lina. I will address this in the next patch, since this one has already been committed.
Thanks.
- Lei
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57570/#review171081
-----------------------------------------------------------
On April 4, 2017, 1:54 p.m., Lei Xu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/57570/
> -----------------------------------------------------------
>
> (Updated April 4, 2017, 1:54 p.m.)
>
>
> Review request for sentry, Alexander Kolbasov and Hao Hao.
>
>
> Bugs: SENTRY-1644
> https://issues.apache.org/jira/browse/SENTRY-1644
>
>
> Repository: sentry
>
>
> Description
> -------
>
> After rename Hive table with partitions, ACLs on the partition paths disappear.
>
> It is caused by the fact that renaming on sentry does not move any sub-namespace.
>
>
> Diffs
> -----
>
> sentry-hdfs/sentry-hdfs-common/src/main/java/org/apache/sentry/hdfs/HMSPaths.java 6d2ab23c3f65af5430ea02563e13c4c4c49aa1c6
> sentry-hdfs/sentry-hdfs-common/src/test/java/org/apache/sentry/hdfs/TestHMSPaths.java 0dee1028ac852b12b109e875b2cbbb0bd2efbe03
> sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/hdfs/TestHDFSIntegrationAdvanced.java d079628a0e549e3b179c7a321f82bcf6b580da43
>
>
> Diff: https://reviews.apache.org/r/57570/diff/4/
>
>
> Testing
> -------
>
> mvn test -Dtest=TestHMSPaths
>
>
> File Attachments
> ----------------
>
> SENTRY-1644.003-master.patch
> https://reviews.apache.org/media/uploaded/files/2017/03/28/1b82d5bc-0267-42d3-9a9a-9515ed7cb25e__SENTRY-1644.003-master.patch
>
>
> Thanks,
>
> Lei Xu
>
>
Re: Review Request 57570: SENTRY-1644. Partition ACLs disappear after
renaming Hive table with partitions
Posted by Na Li <li...@cloudera.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57570/#review171081
-----------------------------------------------------------
sentry-hdfs/sentry-hdfs-common/src/main/java/org/apache/sentry/hdfs/HMSPaths.java
Lines 360 (patched)
<https://reviews.apache.org/r/57570/#comment243928>
comment mentioned to return false if failed, but the code does not return a value.
- Na Li
On April 4, 2017, 8:54 p.m., Lei Xu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/57570/
> -----------------------------------------------------------
>
> (Updated April 4, 2017, 8:54 p.m.)
>
>
> Review request for sentry, Alexander Kolbasov and Hao Hao.
>
>
> Bugs: SENTRY-1644
> https://issues.apache.org/jira/browse/SENTRY-1644
>
>
> Repository: sentry
>
>
> Description
> -------
>
> After rename Hive table with partitions, ACLs on the partition paths disappear.
>
> It is caused by the fact that renaming on sentry does not move any sub-namespace.
>
>
> Diffs
> -----
>
> sentry-hdfs/sentry-hdfs-common/src/main/java/org/apache/sentry/hdfs/HMSPaths.java 6d2ab23c3f65af5430ea02563e13c4c4c49aa1c6
> sentry-hdfs/sentry-hdfs-common/src/test/java/org/apache/sentry/hdfs/TestHMSPaths.java 0dee1028ac852b12b109e875b2cbbb0bd2efbe03
> sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/hdfs/TestHDFSIntegrationAdvanced.java d079628a0e549e3b179c7a321f82bcf6b580da43
>
>
> Diff: https://reviews.apache.org/r/57570/diff/4/
>
>
> Testing
> -------
>
> mvn test -Dtest=TestHMSPaths
>
>
> File Attachments
> ----------------
>
> SENTRY-1644.003-master.patch
> https://reviews.apache.org/media/uploaded/files/2017/03/28/1b82d5bc-0267-42d3-9a9a-9515ed7cb25e__SENTRY-1644.003-master.patch
>
>
> Thanks,
>
> Lei Xu
>
>
Re: Review Request 57570: SENTRY-1644. Partition ACLs disappear after
renaming Hive table with partitions
Posted by Lei Xu <le...@cloudera.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57570/
-----------------------------------------------------------
(Updated April 4, 2017, 1:54 p.m.)
Review request for sentry, Alexander Kolbasov and Hao Hao.
Changes
-------
Thanks for the reviews. Sasha. I addressed all your comments in the new patch.
Bugs: SENTRY-1644
https://issues.apache.org/jira/browse/SENTRY-1644
Repository: sentry
Description
-------
After rename Hive table with partitions, ACLs on the partition paths disappear.
It is caused by the fact that renaming on sentry does not move any sub-namespace.
Diffs (updated)
-----
sentry-hdfs/sentry-hdfs-common/src/main/java/org/apache/sentry/hdfs/HMSPaths.java 6d2ab23c3f65af5430ea02563e13c4c4c49aa1c6
sentry-hdfs/sentry-hdfs-common/src/test/java/org/apache/sentry/hdfs/TestHMSPaths.java 0dee1028ac852b12b109e875b2cbbb0bd2efbe03
sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/hdfs/TestHDFSIntegrationAdvanced.java d079628a0e549e3b179c7a321f82bcf6b580da43
Diff: https://reviews.apache.org/r/57570/diff/4/
Changes: https://reviews.apache.org/r/57570/diff/3-4/
Testing
-------
mvn test -Dtest=TestHMSPaths
File Attachments
----------------
SENTRY-1644.003-master.patch
https://reviews.apache.org/media/uploaded/files/2017/03/28/1b82d5bc-0267-42d3-9a9a-9515ed7cb25e__SENTRY-1644.003-master.patch
Thanks,
Lei Xu
Re: Review Request 57570: SENTRY-1644. Partition ACLs disappear after
renaming Hive table with partitions
Posted by Lei Xu <le...@cloudera.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57570/
-----------------------------------------------------------
(Updated March 27, 2017, 5:24 p.m.)
Review request for sentry, Alexander Kolbasov and Hao Hao.
Bugs: SENTRY-1644
https://issues.apache.org/jira/browse/SENTRY-1644
Repository: sentry
Description
-------
After rename Hive table with partitions, ACLs on the partition paths disappear.
It is caused by the fact that renaming on sentry does not move any sub-namespace.
Diffs (updated)
-----
sentry-hdfs/sentry-hdfs-common/src/main/java/org/apache/sentry/hdfs/HMSPaths.java 6d2ab23c3f65af5430ea02563e13c4c4c49aa1c6
sentry-hdfs/sentry-hdfs-common/src/test/java/org/apache/sentry/hdfs/TestHMSPaths.java 0dee1028ac852b12b109e875b2cbbb0bd2efbe03
sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/hdfs/TestHDFSIntegrationAdvanced.java d079628a0e549e3b179c7a321f82bcf6b580da43
Diff: https://reviews.apache.org/r/57570/diff/3/
Changes: https://reviews.apache.org/r/57570/diff/2-3/
Testing
-------
mvn test -Dtest=TestHMSPaths
File Attachments (updated)
----------------
SENTRY-1644.003-master.patch
https://reviews.apache.org/media/uploaded/files/2017/03/28/1b82d5bc-0267-42d3-9a9a-9515ed7cb25e__SENTRY-1644.003-master.patch
Thanks,
Lei Xu
Re: Review Request 57570: SENTRY-1644. Partition ACLs disappear after
renaming Hive table with partitions
Posted by Lei Xu <le...@cloudera.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57570/
-----------------------------------------------------------
(Updated March 22, 2017, 2:27 p.m.)
Review request for sentry, Alexander Kolbasov and Hao Hao.
Changes
-------
Re-work the patch against the master branch, and add integration test as Hao suggested.
Bugs: SENTRY-1644
https://issues.apache.org/jira/browse/SENTRY-1644
Repository: sentry
Description
-------
After rename Hive table with partitions, ACLs on the partition paths disappear.
It is caused by the fact that renaming on sentry does not move any sub-namespace.
Diffs (updated)
-----
sentry-hdfs/sentry-hdfs-common/src/main/java/org/apache/sentry/hdfs/HMSPaths.java 6d2ab23c3f65af5430ea02563e13c4c4c49aa1c6
sentry-hdfs/sentry-hdfs-common/src/test/java/org/apache/sentry/hdfs/TestHMSPaths.java 0dee1028ac852b12b109e875b2cbbb0bd2efbe03
sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/hdfs/TestHDFSIntegrationAdvanced.java d079628a0e549e3b179c7a321f82bcf6b580da43
Diff: https://reviews.apache.org/r/57570/diff/2/
Changes: https://reviews.apache.org/r/57570/diff/1-2/
Testing
-------
mvn test -Dtest=TestHMSPaths
Thanks,
Lei Xu
Re: Review Request 57570: SENTRY-1644. Partition ACLs disappear after
renaming Hive table with partitions
Posted by Lei Xu <le...@cloudera.com>.
> On March 14, 2017, 1:49 p.m., Hao Hao wrote:
> > Can you add test cases in the intergation test as well, TestHDFSIntegrationAdvanced. To ensure cases such as for managed/unmanaged table we get expected output.
> > Also, it looks like the tests are not all green. Would you mind take a look if anything related?
Thanks for the suggestions. I added an integration test in TestHDFSIntegrationAdvanced.
- Lei
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57570/#review168939
-----------------------------------------------------------
On March 22, 2017, 2:27 p.m., Lei Xu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/57570/
> -----------------------------------------------------------
>
> (Updated March 22, 2017, 2:27 p.m.)
>
>
> Review request for sentry, Alexander Kolbasov and Hao Hao.
>
>
> Bugs: SENTRY-1644
> https://issues.apache.org/jira/browse/SENTRY-1644
>
>
> Repository: sentry
>
>
> Description
> -------
>
> After rename Hive table with partitions, ACLs on the partition paths disappear.
>
> It is caused by the fact that renaming on sentry does not move any sub-namespace.
>
>
> Diffs
> -----
>
> sentry-hdfs/sentry-hdfs-common/src/main/java/org/apache/sentry/hdfs/HMSPaths.java 6d2ab23c3f65af5430ea02563e13c4c4c49aa1c6
> sentry-hdfs/sentry-hdfs-common/src/test/java/org/apache/sentry/hdfs/TestHMSPaths.java 0dee1028ac852b12b109e875b2cbbb0bd2efbe03
> sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/hdfs/TestHDFSIntegrationAdvanced.java d079628a0e549e3b179c7a321f82bcf6b580da43
>
>
> Diff: https://reviews.apache.org/r/57570/diff/2/
>
>
> Testing
> -------
>
> mvn test -Dtest=TestHMSPaths
>
>
> Thanks,
>
> Lei Xu
>
>
Re: Review Request 57570: SENTRY-1644. Partition ACLs disappear after
renaming Hive table with partitions
Posted by Hao Hao <ha...@cloudera.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57570/#review168939
-----------------------------------------------------------
Can you add test cases in the intergation test as well, TestHDFSIntegrationAdvanced. To ensure cases such as for managed/unmanaged table we get expected output.
Also, it looks like the tests are not all green. Would you mind take a look if anything related?
- Hao Hao
On March 13, 2017, 9:57 p.m., Lei Xu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/57570/
> -----------------------------------------------------------
>
> (Updated March 13, 2017, 9:57 p.m.)
>
>
> Review request for sentry, Alexander Kolbasov and Hao Hao.
>
>
> Bugs: SENTRY-1644
> https://issues.apache.org/jira/browse/SENTRY-1644
>
>
> Repository: sentry
>
>
> Description
> -------
>
> After rename Hive table with partitions, ACLs on the partition paths disappear.
>
> It is caused by the fact that renaming on sentry does not move any sub-namespace.
>
>
> Diffs
> -----
>
> sentry-hdfs/sentry-hdfs-common/src/main/java/org/apache/sentry/hdfs/HMSPaths.java e4850f4ee039f011de370ca6b2618161150645de
> sentry-hdfs/sentry-hdfs-common/src/test/java/org/apache/sentry/hdfs/TestHMSPaths.java 0dee1028ac852b12b109e875b2cbbb0bd2efbe03
>
>
> Diff: https://reviews.apache.org/r/57570/diff/1/
>
>
> Testing
> -------
>
> mvn test -Dtest=TestHMSPaths
>
>
> Thanks,
>
> Lei Xu
>
>