[GitHub] [iceberg] stevenzwu commented on pull request #5353: Core: Remove TestEnvironmentUtil#testEnvironmentSubstitution() as it is bui…

[GitBox <gi...@apache.org>]

stevenzwu commented on PR #5353:
URL: https://github.com/apache/iceberg/pull/5353#issuecomment-1195786021

   @rdblue I thought about sth similar to your proposal earlier. We can make the test to assert on different expected output depends on the whether the `USER` env variable exists or not. But then I looked the public `resolveAll` method and found it is so trivial and simply calls the other non-public `resolveAll` method. And the non-public `resolveAll` is already covered by the unit test. Hence, I think it is not necessary to keep this test for a trivial method.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org