You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@atlas.apache.org by Apoorv Naik <na...@gmail.com> on 2017/02/18 01:32:51 UTC

Review Request 56796: Hookup entity change listeners in the entity store

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56796/
-----------------------------------------------------------

Review request for atlas, Ashutosh Mestry, Madhan Neethiraj, Sarath Subramanian, Suma Shivaprasad, and Vimal Sharma.


Bugs: ATLAS-1563
    https://issues.apache.org/jira/browse/ATLAS-1563


Repository: atlas


Description
-------

Any entity modification should be notified to the listeners like posting the change to kafka topic and adding an audit entry.


Diffs
-----

  repository/src/main/java/org/apache/atlas/repository/converters/AtlasInstanceConverter.java 9d475bf9 
  repository/src/main/java/org/apache/atlas/repository/store/graph/v1/AtlasEntityStoreV1.java 31a5e8cb 
  repository/src/test/java/org/apache/atlas/repository/store/graph/v1/AtlasDeleteHandlerV1Test.java 492abc47 
  repository/src/test/java/org/apache/atlas/repository/store/graph/v1/AtlasEntityStoreV1Test.java dd82cb26 
  server-api/src/main/java/org/apache/atlas/listener/EntityChangeListener.java 4bf1d057 
  webapp/src/main/java/org/apache/atlas/web/rest/EntityREST.java 2f7ba20c 

Diff: https://reviews.apache.org/r/56796/diff/


Testing
-------

In progress.


Thanks,

Apoorv Naik


Re: Review Request 56796: Hookup entity change listeners in the entity store

Posted by Madhan Neethiraj <ma...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56796/#review166024
-----------------------------------------------------------


Ship it!




Ship It!

- Madhan Neethiraj


On Feb. 18, 2017, 2:56 a.m., Apoorv Naik wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/56796/
> -----------------------------------------------------------
> 
> (Updated Feb. 18, 2017, 2:56 a.m.)
> 
> 
> Review request for atlas, Ashutosh Mestry, Madhan Neethiraj, Sarath Subramanian, Suma Shivaprasad, and Vimal Sharma.
> 
> 
> Bugs: ATLAS-1563
>     https://issues.apache.org/jira/browse/ATLAS-1563
> 
> 
> Repository: atlas
> 
> 
> Description
> -------
> 
> Any entity modification should be notified to the listeners like posting the change to kafka topic and adding an audit entry.
> 
> 
> Diffs
> -----
> 
>   repository/src/main/java/org/apache/atlas/repository/converters/AtlasInstanceConverter.java 9d475bf9 
>   repository/src/main/java/org/apache/atlas/repository/store/graph/v1/AtlasEntityStoreV1.java 31a5e8cb 
>   repository/src/test/java/org/apache/atlas/repository/store/graph/v1/AtlasDeleteHandlerV1Test.java 492abc47 
>   repository/src/test/java/org/apache/atlas/repository/store/graph/v1/AtlasEntityStoreV1Test.java dd82cb26 
>   server-api/src/main/java/org/apache/atlas/listener/EntityChangeListener.java 4bf1d057 
>   webapp/src/main/java/org/apache/atlas/web/rest/EntityREST.java 2f7ba20c 
> 
> Diff: https://reviews.apache.org/r/56796/diff/
> 
> 
> Testing
> -------
> 
> Verified that Kafka topic receives the message and hbase table has an entry corresponding to the changes made to the entity.
> 
> mvn clean package executes successfully.
> 
> 
> Thanks,
> 
> Apoorv Naik
> 
>


Re: Review Request 56796: Hookup entity change listeners in the entity store

Posted by Apoorv Naik <na...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56796/
-----------------------------------------------------------

(Updated Feb. 18, 2017, 2:56 a.m.)


Review request for atlas, Ashutosh Mestry, Madhan Neethiraj, Sarath Subramanian, Suma Shivaprasad, and Vimal Sharma.


Changes
-------

Updated build results.


Bugs: ATLAS-1563
    https://issues.apache.org/jira/browse/ATLAS-1563


Repository: atlas


Description
-------

Any entity modification should be notified to the listeners like posting the change to kafka topic and adding an audit entry.


Diffs
-----

  repository/src/main/java/org/apache/atlas/repository/converters/AtlasInstanceConverter.java 9d475bf9 
  repository/src/main/java/org/apache/atlas/repository/store/graph/v1/AtlasEntityStoreV1.java 31a5e8cb 
  repository/src/test/java/org/apache/atlas/repository/store/graph/v1/AtlasDeleteHandlerV1Test.java 492abc47 
  repository/src/test/java/org/apache/atlas/repository/store/graph/v1/AtlasEntityStoreV1Test.java dd82cb26 
  server-api/src/main/java/org/apache/atlas/listener/EntityChangeListener.java 4bf1d057 
  webapp/src/main/java/org/apache/atlas/web/rest/EntityREST.java 2f7ba20c 

Diff: https://reviews.apache.org/r/56796/diff/


Testing (updated)
-------

Verified that Kafka topic receives the message and hbase table has an entry corresponding to the changes made to the entity.

mvn clean package executes successfully.


Thanks,

Apoorv Naik


Re: Review Request 56796: Hookup entity change listeners in the entity store

Posted by Apoorv Naik <na...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56796/
-----------------------------------------------------------

(Updated Feb. 18, 2017, 1:35 a.m.)


Review request for atlas, Ashutosh Mestry, Madhan Neethiraj, Sarath Subramanian, Suma Shivaprasad, and Vimal Sharma.


Bugs: ATLAS-1563
    https://issues.apache.org/jira/browse/ATLAS-1563


Repository: atlas


Description
-------

Any entity modification should be notified to the listeners like posting the change to kafka topic and adding an audit entry.


Diffs
-----

  repository/src/main/java/org/apache/atlas/repository/converters/AtlasInstanceConverter.java 9d475bf9 
  repository/src/main/java/org/apache/atlas/repository/store/graph/v1/AtlasEntityStoreV1.java 31a5e8cb 
  repository/src/test/java/org/apache/atlas/repository/store/graph/v1/AtlasDeleteHandlerV1Test.java 492abc47 
  repository/src/test/java/org/apache/atlas/repository/store/graph/v1/AtlasEntityStoreV1Test.java dd82cb26 
  server-api/src/main/java/org/apache/atlas/listener/EntityChangeListener.java 4bf1d057 
  webapp/src/main/java/org/apache/atlas/web/rest/EntityREST.java 2f7ba20c 

Diff: https://reviews.apache.org/r/56796/diff/


Testing (updated)
-------

Verified that Kafka topic receives the message and hbase table has an entry corresponding to the changes made to the entity.

mvn clean install in progress


Thanks,

Apoorv Naik