You are viewing a plain text version of this content. The canonical link for it is here.

Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2021/08/23 18:57:23 UTC

[GitHub] [superset] graceguo-supercat commented on a change in pull request #16367: fix: Disable Slack notification method if no api token

graceguo-supercat commented on a change in pull request #16367:
URL: https://github.com/apache/superset/pull/16367#discussion_r694229571



##########
File path: superset/config.py
##########
@@ -994,6 +994,8 @@ def CSV_TO_HIVE_UPLOAD_DIRECTORY_FUNC(
 # If set to true no notification is sent, the worker will just log a message.
 # Useful for debugging
 ALERT_REPORTS_NOTIFICATION_DRY_RUN = False
+# Allowed notification methods: Email, Slack
+ALERT_REPORTS_ALERTS_NOTIFICATION_METHODS = ["Email", "Slack"]

Review comment:
       Based on the new implementation, we will always has 'Email' option, so i don't handle empty case here.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org