You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@kafka.apache.org by ij...@apache.org on 2018/10/26 13:48:47 UTC
[kafka] branch trunk updated: KAFKA-7532: Clean-up controller log
when shutting down brokers (#5831)
This is an automated email from the ASF dual-hosted git repository.
ijuma pushed a commit to branch trunk
in repository https://gitbox.apache.org/repos/asf/kafka.git
The following commit(s) were added to refs/heads/trunk by this push:
new eda4a29 KAFKA-7532: Clean-up controller log when shutting down brokers (#5831)
eda4a29 is described below
commit eda4a2904a863b04f6ea511a4cf1e2bd4806ad35
Author: Stanislav Kozlovski <st...@outlook.com>
AuthorDate: Fri Oct 26 16:48:31 2018 +0300
KAFKA-7532: Clean-up controller log when shutting down brokers (#5831)
This line prints out (when empty):
```
[2018-10-23 12:19:59,977] INFO [Controller id=0] Removed ArrayBuffer() from list of shutting down brokers. (kafka.controller.KafkaController)
```
Use `mkString` to eliminate `ArrayBuffer` and only log if not empty.
Reviewers: Ismael Juma <is...@juma.me.uk>
---
core/src/main/scala/kafka/controller/KafkaController.scala | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/core/src/main/scala/kafka/controller/KafkaController.scala b/core/src/main/scala/kafka/controller/KafkaController.scala
index 379e66d..740ab7f 100644
--- a/core/src/main/scala/kafka/controller/KafkaController.scala
+++ b/core/src/main/scala/kafka/controller/KafkaController.scala
@@ -411,7 +411,8 @@ class KafkaController(val config: KafkaConfig, zkClient: KafkaZkClient, time: Ti
deadBrokers.foreach(controllerContext.replicasOnOfflineDirs.remove)
val deadBrokersThatWereShuttingDown =
deadBrokers.filter(id => controllerContext.shuttingDownBrokerIds.remove(id))
- info(s"Removed $deadBrokersThatWereShuttingDown from list of shutting down brokers.")
+ if (deadBrokersThatWereShuttingDown.nonEmpty)
+ info(s"Removed ${deadBrokersThatWereShuttingDown.mkString(",")} from list of shutting down brokers.")
val allReplicasOnDeadBrokers = controllerContext.replicasOnBrokers(deadBrokers.toSet)
onReplicasBecomeOffline(allReplicasOnDeadBrokers)