You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2021/07/13 16:55:35 UTC
[GitHub] [airflow] potiuk opened a new pull request #16975: Update alias for field_mask in Google Memmcache
potiuk opened a new pull request #16975:
URL: https://github.com/apache/airflow/pull/16975
The July 12 2021 release of google-memcache library removed
field_mask alias from the library which broke our typechecking
and made google provider unimportable. This PR fixes the import
to use the actual import.
<!--
Thank you for contributing! Please make sure that your code changes
are covered with tests. And in case of new features or big changes
remember to adjust the documentation.
Feel free to ping committers for the review!
In case of existing issue, reference it using one of the following:
closes: #ISSUE
related: #ISSUE
How to write a good git commit message:
http://chris.beams.io/posts/git-commit/
-->
---
**^ Add meaningful description above**
Read the **[Pull Request Guidelines](https://github.com/apache/airflow/blob/main/CONTRIBUTING.rst#pull-request-guidelines)** for more information.
In case of fundamental code change, Airflow Improvement Proposal ([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvements+Proposals)) is needed.
In case of a new dependency, check compliance with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x).
In case of backwards incompatible changes please leave a note in [UPDATING.md](https://github.com/apache/airflow/blob/main/UPDATING.md).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk edited a comment on pull request #16975: Update alias for field_mask in Google Memmcache
Posted by GitBox <gi...@apache.org>.
potiuk edited a comment on pull request #16975:
URL: https://github.com/apache/airflow/pull/16975#issuecomment-879300946
It's a bit worse :(, We have to
1) limit to < 1.1.0 now (so that currently released provider can install)
2) import it directly from where memcache is importing it
3) when we release the next provider for google we will be able to remove the limitation
That's all because of backwards-incompatible import :(
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] github-actions[bot] commented on pull request #16975: Update alias for field_mask in Google Memmcache
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #16975:
URL: https://github.com/apache/airflow/pull/16975#issuecomment-879260814
The PR is likely OK to be merged with just subset of tests for default Python and Database versions without running the full matrix of tests, because it does not modify the core of Airflow. If the committers decide that the full tests matrix is needed, they will add the label 'full tests needed'. Then you should rebase to the latest main or amend the last commit of the PR, and push it with --force-with-lease.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on a change in pull request #16975: Update alias for field_mask in Google Memmcache
Posted by GitBox <gi...@apache.org>.
potiuk commented on a change in pull request #16975:
URL: https://github.com/apache/airflow/pull/16975#discussion_r669022039
##########
File path: setup.py
##########
@@ -292,7 +292,9 @@ def write_version(filename: str = os.path.join(*[my_dir, "airflow", "git_version
'google-cloud-kms>=2.0.0,<3.0.0',
'google-cloud-language>=1.1.1,<2.0.0',
'google-cloud-logging>=2.1.1,<3.0.0',
- 'google-cloud-memcache>=0.2.0',
+ # 1.1.0 removed field_mask and broke import for released providers
+ # We can remove the <1.1.0 limitation after we release new Google Provider
+ 'google-cloud-memcache>=0.2.0,<1.1.0',
Review comment:
Pretty sure 1.1.0 was released yesterday (from pypi):
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk merged pull request #16975: Update alias for field_mask in Google Memmcache
Posted by GitBox <gi...@apache.org>.
potiuk merged pull request #16975:
URL: https://github.com/apache/airflow/pull/16975
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on pull request #16975: Update alias for field_mask in Google Memmcache
Posted by GitBox <gi...@apache.org>.
potiuk commented on pull request #16975:
URL: https://github.com/apache/airflow/pull/16975#issuecomment-879249392
Needs merging otherwise any PR where setup.py is changed will break (for example #16974) due to release of new google memcache library
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] github-actions[bot] commented on pull request #16975: Update alias for field_mask in Google Memmcache
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #16975:
URL: https://github.com/apache/airflow/pull/16975#issuecomment-879313919
The PR most likely needs to run full matrix of tests because it modifies parts of the core of Airflow. However, committers might decide to merge it quickly and take the risk. If they don't merge it quickly - please rebase it to the latest main at your convenience, or amend the last commit of the PR, and push it with --force-with-lease.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] mik-laj commented on a change in pull request #16975: Update alias for field_mask in Google Memmcache
Posted by GitBox <gi...@apache.org>.
mik-laj commented on a change in pull request #16975:
URL: https://github.com/apache/airflow/pull/16975#discussion_r669020251
##########
File path: setup.py
##########
@@ -292,7 +292,9 @@ def write_version(filename: str = os.path.join(*[my_dir, "airflow", "git_version
'google-cloud-kms>=2.0.0,<3.0.0',
'google-cloud-language>=1.1.1,<2.0.0',
'google-cloud-logging>=2.1.1,<3.0.0',
- 'google-cloud-memcache>=0.2.0',
+ # 1.1.0 removed field_mask and broke import for released providers
+ # We can remove the <1.1.0 limitation after we release new Google Provider
+ 'google-cloud-memcache>=0.2.0,<1.1.0',
Review comment:
The new version may have some compatibility, but not enough for the operator to be successfully executed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on pull request #16975: Update alias for field_mask in Google Memmcache
Posted by GitBox <gi...@apache.org>.
potiuk commented on pull request #16975:
URL: https://github.com/apache/airflow/pull/16975#issuecomment-879274844
seems it might be difficult-ish to make it works (I could do some conditional import) with pre and post change - but since it was non-breaking release and library used only in the memcache operators, I simply added lower bound to 1.1.0 version.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on pull request #16975: Update alias for field_mask in Google Memmcache
Posted by GitBox <gi...@apache.org>.
potiuk commented on pull request #16975:
URL: https://github.com/apache/airflow/pull/16975#issuecomment-879300946
It's a bit worse :(, We have to
1) limit to < 1.1.0 now (so that currently released provider can install)
2) add dynamic handling of either import
3) when we release the next provider for google we will be able to remove the limitation
That's all because of backwards-incompatible import :(
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] mik-laj commented on a change in pull request #16975: Update alias for field_mask in Google Memmcache
Posted by GitBox <gi...@apache.org>.
mik-laj commented on a change in pull request #16975:
URL: https://github.com/apache/airflow/pull/16975#discussion_r669018787
##########
File path: setup.py
##########
@@ -292,7 +292,9 @@ def write_version(filename: str = os.path.join(*[my_dir, "airflow", "git_version
'google-cloud-kms>=2.0.0,<3.0.0',
'google-cloud-language>=1.1.1,<2.0.0',
'google-cloud-logging>=2.1.1,<3.0.0',
- 'google-cloud-memcache>=0.2.0',
+ # 1.1.0 removed field_mask and broke import for released providers
+ # We can remove the <1.1.0 limitation after we release new Google Provider
+ 'google-cloud-memcache>=0.2.0,<1.1.0',
Review comment:
Are you sure `google-cloud-memcache v1.1.0` is compatible? These two versions were released within a short period of time.
> 1.1.0 (2021-06-30)
> 1.0.0 (2021-05-28)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org