You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@shindig.apache.org by ch...@us.ibm.com on 2011/07/05 22:13:18 UTC
Re: Review Request: Implementation of a dynamic width feature
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/982/
-----------------------------------------------------------
(Updated 2011-07-05 20:13:18.318377)
Review request for shindig, Ryan Baxter, Stanton Sievers, and Dan Dumont.
Summary
-------
This is the reference implementation for the dynamic width OpenSocial spec change:
http://code.google.com/p/opensocial-resources/issues/detail?id=1191&colspec=ID%20Type%20Container%20Stars%20Summary%20Status
This change also incorporates the change posed here: https://reviews.apache.org/r/974/
That change is necessary in order for the rpc callback in Dynamic Width to function properly.
Diffs (updated)
-----
http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/container/container.js 1141541
http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/dynamic-height.height/feature.xml 1141541
http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/dynamic-height.util/dynamic-height-util.js 1141541
http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/dynamic-height.util/feature.xml 1141541
http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/dynamic-height.util/taming.js 1141541
http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/dynamic-height/feature.xml 1141541
http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/dynamic-size.util/dynamic-size-util.js PRE-CREATION
http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/dynamic-size.util/feature.xml PRE-CREATION
http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/dynamic-size.util/taming.js PRE-CREATION
http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/dynamic-width.width/dynamic-width-width.js PRE-CREATION
http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/dynamic-width.width/feature.xml PRE-CREATION
http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/dynamic-width.width/taming.js PRE-CREATION
http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/dynamic-width/dynamic-width.js PRE-CREATION
http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/dynamic-width/feature.xml PRE-CREATION
http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/dynamic-width/taming.js PRE-CREATION
http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/features.txt 1141541
Diff: https://reviews.apache.org/r/982/diff
Testing
-------
Tested against Firefox 3.6, Chrome 12, Safari 5 in a custom container
Thanks,
cheelan
Re: Review Request: Implementation of a dynamic width feature
Posted by Ryan Baxter <rb...@gmail.com>.
> On 2011-07-20 17:19:16, Henry Saputra wrote:
> > Has this been tested in IE7 or IE8? These guys usually screw up the dimension for DOM.
>
> cheelan wrote:
> I have successfully tested it on IE 8 and 9.
Henry are you OK with the testing Chris did? If so we will deliver the patch.
- Ryan
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/982/#review1136
-----------------------------------------------------------
On 2011-08-11 13:23:16, cheelan wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/982/
> -----------------------------------------------------------
>
> (Updated 2011-08-11 13:23:16)
>
>
> Review request for shindig, Ryan Baxter, Stanton Sievers, and Dan Dumont.
>
>
> Summary
> -------
>
> This is the reference implementation for the dynamic width OpenSocial spec change:
> http://code.google.com/p/opensocial-resources/issues/detail?id=1191&colspec=ID%20Type%20Container%20Stars%20Summary%20Status
>
> This change also incorporates the change posed here: https://reviews.apache.org/r/974/
> That change is necessary in order for the rpc callback in Dynamic Width to function properly.
>
>
> This addresses bug SHINDIG-1567.
> https://issues.apache.org/jira/browse/SHINDIG-1567
>
>
> Diffs
> -----
>
> http://svn.apache.org/repos/asf/shindig/trunk/content/samplecontainer/examples/dynamicWidthTest.xml PRE-CREATION
> http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/container/container.js 1147953
> http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/dynamic-height.height/feature.xml 1147953
> http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/dynamic-height.util/dynamic-height-util.js 1147953
> http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/dynamic-height.util/feature.xml 1147953
> http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/dynamic-height.util/taming.js 1147953
> http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/dynamic-height/feature.xml 1147953
> http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/dynamic-size.util/dynamic-size-util.js PRE-CREATION
> http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/dynamic-size.util/feature.xml PRE-CREATION
> http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/dynamic-size.util/taming.js PRE-CREATION
> http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/dynamic-width.width/dynamic-width-width.js PRE-CREATION
> http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/dynamic-width.width/feature.xml PRE-CREATION
> http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/dynamic-width.width/taming.js PRE-CREATION
> http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/dynamic-width/dynamic-width.js PRE-CREATION
> http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/dynamic-width/feature.xml PRE-CREATION
> http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/dynamic-width/taming.js PRE-CREATION
> http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/features.txt 1147953
>
> Diff: https://reviews.apache.org/r/982/diff
>
>
> Testing
> -------
>
> Tested against Firefox 3.6, Chrome 12, Safari 5 in a custom container
>
>
> Thanks,
>
> cheelan
>
>
Re: Review Request: Implementation of a dynamic width feature
Posted by ch...@us.ibm.com.
> On 2011-07-20 17:19:16, Henry Saputra wrote:
> > Has this been tested in IE7 or IE8? These guys usually screw up the dimension for DOM.
I have successfully tested it on IE 8 and 9.
- cheelan
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/982/#review1136
-----------------------------------------------------------
On 2011-08-11 13:12:54, cheelan wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/982/
> -----------------------------------------------------------
>
> (Updated 2011-08-11 13:12:54)
>
>
> Review request for shindig, Ryan Baxter, Stanton Sievers, and Dan Dumont.
>
>
> Summary
> -------
>
> This is the reference implementation for the dynamic width OpenSocial spec change:
> http://code.google.com/p/opensocial-resources/issues/detail?id=1191&colspec=ID%20Type%20Container%20Stars%20Summary%20Status
>
> This change also incorporates the change posed here: https://reviews.apache.org/r/974/
> That change is necessary in order for the rpc callback in Dynamic Width to function properly.
>
>
> This addresses bug https://issues.apache.org/jira/browse/SHINDIG-1567.
> https://issues.apache.org/jira/browse/https://issues.apache.org/jira/browse/SHINDIG-1567
>
>
> Diffs
> -----
>
> http://svn.apache.org/repos/asf/shindig/trunk/content/samplecontainer/examples/dynamicWidthTest.xml PRE-CREATION
> http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/container/container.js 1147953
> http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/dynamic-height.height/feature.xml 1147953
> http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/dynamic-height.util/dynamic-height-util.js 1147953
> http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/dynamic-height.util/feature.xml 1147953
> http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/dynamic-height.util/taming.js 1147953
> http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/dynamic-height/feature.xml 1147953
> http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/dynamic-size.util/dynamic-size-util.js PRE-CREATION
> http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/dynamic-size.util/feature.xml PRE-CREATION
> http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/dynamic-size.util/taming.js PRE-CREATION
> http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/dynamic-width.width/dynamic-width-width.js PRE-CREATION
> http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/dynamic-width.width/feature.xml PRE-CREATION
> http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/dynamic-width.width/taming.js PRE-CREATION
> http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/dynamic-width/dynamic-width.js PRE-CREATION
> http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/dynamic-width/feature.xml PRE-CREATION
> http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/dynamic-width/taming.js PRE-CREATION
> http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/features.txt 1147953
>
> Diff: https://reviews.apache.org/r/982/diff
>
>
> Testing
> -------
>
> Tested against Firefox 3.6, Chrome 12, Safari 5 in a custom container
>
>
> Thanks,
>
> cheelan
>
>
Re: Review Request: Implementation of a dynamic width feature
Posted by Henry Saputra <hs...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/982/#review1136
-----------------------------------------------------------
Has this been tested in IE7 or IE8? These guys usually screw up the dimension for DOM.
- Henry
On 2011-07-18 20:13:13, cheelan wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/982/
> -----------------------------------------------------------
>
> (Updated 2011-07-18 20:13:13)
>
>
> Review request for shindig, Ryan Baxter, Stanton Sievers, and Dan Dumont.
>
>
> Summary
> -------
>
> This is the reference implementation for the dynamic width OpenSocial spec change:
> http://code.google.com/p/opensocial-resources/issues/detail?id=1191&colspec=ID%20Type%20Container%20Stars%20Summary%20Status
>
> This change also incorporates the change posed here: https://reviews.apache.org/r/974/
> That change is necessary in order for the rpc callback in Dynamic Width to function properly.
>
>
> Diffs
> -----
>
> http://svn.apache.org/repos/asf/shindig/trunk/content/samplecontainer/examples/dynamicWidthTest.xml PRE-CREATION
> http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/container/container.js 1147953
> http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/dynamic-height.height/feature.xml 1147953
> http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/dynamic-height.util/dynamic-height-util.js 1147953
> http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/dynamic-height.util/feature.xml 1147953
> http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/dynamic-height.util/taming.js 1147953
> http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/dynamic-height/feature.xml 1147953
> http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/dynamic-size.util/dynamic-size-util.js PRE-CREATION
> http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/dynamic-size.util/feature.xml PRE-CREATION
> http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/dynamic-size.util/taming.js PRE-CREATION
> http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/dynamic-width.width/dynamic-width-width.js PRE-CREATION
> http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/dynamic-width.width/feature.xml PRE-CREATION
> http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/dynamic-width.width/taming.js PRE-CREATION
> http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/dynamic-width/dynamic-width.js PRE-CREATION
> http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/dynamic-width/feature.xml PRE-CREATION
> http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/dynamic-width/taming.js PRE-CREATION
> http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/features.txt 1147953
>
> Diff: https://reviews.apache.org/r/982/diff
>
>
> Testing
> -------
>
> Tested against Firefox 3.6, Chrome 12, Safari 5 in a custom container
>
>
> Thanks,
>
> cheelan
>
>
Re: Review Request: Implementation of a dynamic width feature
Posted by Henry Saputra <hs...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/982/#review1409
-----------------------------------------------------------
Ship it!
LGTM! Thanks
- Henry
On 2011-08-11 13:23:16, cheelan wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/982/
> -----------------------------------------------------------
>
> (Updated 2011-08-11 13:23:16)
>
>
> Review request for shindig, Ryan Baxter, Stanton Sievers, and Dan Dumont.
>
>
> Summary
> -------
>
> This is the reference implementation for the dynamic width OpenSocial spec change:
> http://code.google.com/p/opensocial-resources/issues/detail?id=1191&colspec=ID%20Type%20Container%20Stars%20Summary%20Status
>
> This change also incorporates the change posed here: https://reviews.apache.org/r/974/
> That change is necessary in order for the rpc callback in Dynamic Width to function properly.
>
>
> This addresses bug SHINDIG-1567.
> https://issues.apache.org/jira/browse/SHINDIG-1567
>
>
> Diffs
> -----
>
> http://svn.apache.org/repos/asf/shindig/trunk/content/samplecontainer/examples/dynamicWidthTest.xml PRE-CREATION
> http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/container/container.js 1147953
> http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/dynamic-height.height/feature.xml 1147953
> http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/dynamic-height.util/dynamic-height-util.js 1147953
> http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/dynamic-height.util/feature.xml 1147953
> http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/dynamic-height.util/taming.js 1147953
> http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/dynamic-height/feature.xml 1147953
> http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/dynamic-size.util/dynamic-size-util.js PRE-CREATION
> http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/dynamic-size.util/feature.xml PRE-CREATION
> http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/dynamic-size.util/taming.js PRE-CREATION
> http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/dynamic-width.width/dynamic-width-width.js PRE-CREATION
> http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/dynamic-width.width/feature.xml PRE-CREATION
> http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/dynamic-width.width/taming.js PRE-CREATION
> http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/dynamic-width/dynamic-width.js PRE-CREATION
> http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/dynamic-width/feature.xml PRE-CREATION
> http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/dynamic-width/taming.js PRE-CREATION
> http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/features.txt 1147953
>
> Diff: https://reviews.apache.org/r/982/diff
>
>
> Testing
> -------
>
> Tested against Firefox 3.6, Chrome 12, Safari 5 in a custom container
>
>
> Thanks,
>
> cheelan
>
>
Re: Review Request: Implementation of a dynamic width feature
Posted by Ryan Baxter <rb...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/982/#review1426
-----------------------------------------------------------
Ship it!
Committed thanks
- Ryan
On 2011-08-11 13:23:16, cheelan wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/982/
> -----------------------------------------------------------
>
> (Updated 2011-08-11 13:23:16)
>
>
> Review request for shindig, Ryan Baxter, Stanton Sievers, and Dan Dumont.
>
>
> Summary
> -------
>
> This is the reference implementation for the dynamic width OpenSocial spec change:
> http://code.google.com/p/opensocial-resources/issues/detail?id=1191&colspec=ID%20Type%20Container%20Stars%20Summary%20Status
>
> This change also incorporates the change posed here: https://reviews.apache.org/r/974/
> That change is necessary in order for the rpc callback in Dynamic Width to function properly.
>
>
> This addresses bug SHINDIG-1567.
> https://issues.apache.org/jira/browse/SHINDIG-1567
>
>
> Diffs
> -----
>
> http://svn.apache.org/repos/asf/shindig/trunk/content/samplecontainer/examples/dynamicWidthTest.xml PRE-CREATION
> http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/container/container.js 1147953
> http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/dynamic-height.height/feature.xml 1147953
> http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/dynamic-height.util/dynamic-height-util.js 1147953
> http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/dynamic-height.util/feature.xml 1147953
> http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/dynamic-height.util/taming.js 1147953
> http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/dynamic-height/feature.xml 1147953
> http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/dynamic-size.util/dynamic-size-util.js PRE-CREATION
> http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/dynamic-size.util/feature.xml PRE-CREATION
> http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/dynamic-size.util/taming.js PRE-CREATION
> http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/dynamic-width.width/dynamic-width-width.js PRE-CREATION
> http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/dynamic-width.width/feature.xml PRE-CREATION
> http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/dynamic-width.width/taming.js PRE-CREATION
> http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/dynamic-width/dynamic-width.js PRE-CREATION
> http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/dynamic-width/feature.xml PRE-CREATION
> http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/dynamic-width/taming.js PRE-CREATION
> http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/features.txt 1147953
>
> Diff: https://reviews.apache.org/r/982/diff
>
>
> Testing
> -------
>
> Tested against Firefox 3.6, Chrome 12, Safari 5 in a custom container
>
>
> Thanks,
>
> cheelan
>
>
Re: Review Request: Implementation of a dynamic width feature
Posted by ch...@us.ibm.com.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/982/
-----------------------------------------------------------
(Updated 2011-08-11 13:23:16.416079)
Review request for shindig, Ryan Baxter, Stanton Sievers, and Dan Dumont.
Summary
-------
This is the reference implementation for the dynamic width OpenSocial spec change:
http://code.google.com/p/opensocial-resources/issues/detail?id=1191&colspec=ID%20Type%20Container%20Stars%20Summary%20Status
This change also incorporates the change posed here: https://reviews.apache.org/r/974/
That change is necessary in order for the rpc callback in Dynamic Width to function properly.
This addresses bug SHINDIG-1567.
https://issues.apache.org/jira/browse/SHINDIG-1567
Diffs
-----
http://svn.apache.org/repos/asf/shindig/trunk/content/samplecontainer/examples/dynamicWidthTest.xml PRE-CREATION
http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/container/container.js 1147953
http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/dynamic-height.height/feature.xml 1147953
http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/dynamic-height.util/dynamic-height-util.js 1147953
http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/dynamic-height.util/feature.xml 1147953
http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/dynamic-height.util/taming.js 1147953
http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/dynamic-height/feature.xml 1147953
http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/dynamic-size.util/dynamic-size-util.js PRE-CREATION
http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/dynamic-size.util/feature.xml PRE-CREATION
http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/dynamic-size.util/taming.js PRE-CREATION
http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/dynamic-width.width/dynamic-width-width.js PRE-CREATION
http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/dynamic-width.width/feature.xml PRE-CREATION
http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/dynamic-width.width/taming.js PRE-CREATION
http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/dynamic-width/dynamic-width.js PRE-CREATION
http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/dynamic-width/feature.xml PRE-CREATION
http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/dynamic-width/taming.js PRE-CREATION
http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/features.txt 1147953
Diff: https://reviews.apache.org/r/982/diff
Testing
-------
Tested against Firefox 3.6, Chrome 12, Safari 5 in a custom container
Thanks,
cheelan
Re: Review Request: Implementation of a dynamic width feature
Posted by ch...@us.ibm.com.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/982/
-----------------------------------------------------------
(Updated 2011-08-11 13:12:54.774163)
Review request for shindig, Ryan Baxter, Stanton Sievers, and Dan Dumont.
Summary
-------
This is the reference implementation for the dynamic width OpenSocial spec change:
http://code.google.com/p/opensocial-resources/issues/detail?id=1191&colspec=ID%20Type%20Container%20Stars%20Summary%20Status
This change also incorporates the change posed here: https://reviews.apache.org/r/974/
That change is necessary in order for the rpc callback in Dynamic Width to function properly.
This addresses bug https://issues.apache.org/jira/browse/SHINDIG-1567.
https://issues.apache.org/jira/browse/https://issues.apache.org/jira/browse/SHINDIG-1567
Diffs
-----
http://svn.apache.org/repos/asf/shindig/trunk/content/samplecontainer/examples/dynamicWidthTest.xml PRE-CREATION
http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/container/container.js 1147953
http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/dynamic-height.height/feature.xml 1147953
http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/dynamic-height.util/dynamic-height-util.js 1147953
http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/dynamic-height.util/feature.xml 1147953
http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/dynamic-height.util/taming.js 1147953
http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/dynamic-height/feature.xml 1147953
http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/dynamic-size.util/dynamic-size-util.js PRE-CREATION
http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/dynamic-size.util/feature.xml PRE-CREATION
http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/dynamic-size.util/taming.js PRE-CREATION
http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/dynamic-width.width/dynamic-width-width.js PRE-CREATION
http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/dynamic-width.width/feature.xml PRE-CREATION
http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/dynamic-width.width/taming.js PRE-CREATION
http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/dynamic-width/dynamic-width.js PRE-CREATION
http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/dynamic-width/feature.xml PRE-CREATION
http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/dynamic-width/taming.js PRE-CREATION
http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/features.txt 1147953
Diff: https://reviews.apache.org/r/982/diff
Testing
-------
Tested against Firefox 3.6, Chrome 12, Safari 5 in a custom container
Thanks,
cheelan
Re: Review Request: Implementation of a dynamic width feature
Posted by ch...@us.ibm.com.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/982/
-----------------------------------------------------------
(Updated 2011-07-18 20:13:13.170550)
Review request for shindig, Ryan Baxter, Stanton Sievers, and Dan Dumont.
Changes
-------
New patch addresses issues and contains a sample gadget called dynamicWidthTest.xml located under samplecontainer/examples
As far as I could tell, var _IG_AdjustIFrameWidth isn't used anywhere, but a similarly unused variable was kept in the dynamic-height feature so I left it for consistency.
Summary
-------
This is the reference implementation for the dynamic width OpenSocial spec change:
http://code.google.com/p/opensocial-resources/issues/detail?id=1191&colspec=ID%20Type%20Container%20Stars%20Summary%20Status
This change also incorporates the change posed here: https://reviews.apache.org/r/974/
That change is necessary in order for the rpc callback in Dynamic Width to function properly.
Diffs (updated)
-----
http://svn.apache.org/repos/asf/shindig/trunk/content/samplecontainer/examples/dynamicWidthTest.xml PRE-CREATION
http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/container/container.js 1147953
http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/dynamic-height.height/feature.xml 1147953
http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/dynamic-height.util/dynamic-height-util.js 1147953
http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/dynamic-height.util/feature.xml 1147953
http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/dynamic-height.util/taming.js 1147953
http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/dynamic-height/feature.xml 1147953
http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/dynamic-size.util/dynamic-size-util.js PRE-CREATION
http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/dynamic-size.util/feature.xml PRE-CREATION
http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/dynamic-size.util/taming.js PRE-CREATION
http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/dynamic-width.width/dynamic-width-width.js PRE-CREATION
http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/dynamic-width.width/feature.xml PRE-CREATION
http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/dynamic-width.width/taming.js PRE-CREATION
http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/dynamic-width/dynamic-width.js PRE-CREATION
http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/dynamic-width/feature.xml PRE-CREATION
http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/dynamic-width/taming.js PRE-CREATION
http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/features.txt 1147953
Diff: https://reviews.apache.org/r/982/diff
Testing
-------
Tested against Firefox 3.6, Chrome 12, Safari 5 in a custom container
Thanks,
cheelan
Re: Review Request: Implementation of a dynamic width feature
Posted by Henry Saputra <hs...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/982/#review1100
-----------------------------------------------------------
Can you add gadget example that uses this new feature?
http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/dynamic-width/dynamic-width.js
<https://reviews.apache.org/r/982/#comment2231>
Not used anywhere?
http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/dynamic-width/dynamic-width.js
<https://reviews.apache.org/r/982/#comment2232>
not being used?
- Henry
On 2011-07-18 18:36:11, cheelan wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/982/
> -----------------------------------------------------------
>
> (Updated 2011-07-18 18:36:11)
>
>
> Review request for shindig, Ryan Baxter, Stanton Sievers, and Dan Dumont.
>
>
> Summary
> -------
>
> This is the reference implementation for the dynamic width OpenSocial spec change:
> http://code.google.com/p/opensocial-resources/issues/detail?id=1191&colspec=ID%20Type%20Container%20Stars%20Summary%20Status
>
> This change also incorporates the change posed here: https://reviews.apache.org/r/974/
> That change is necessary in order for the rpc callback in Dynamic Width to function properly.
>
>
> Diffs
> -----
>
> http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/dynamic-width/taming.js PRE-CREATION
> http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/features.txt 1147953
> http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/dynamic-width/feature.xml PRE-CREATION
> http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/dynamic-width.width/feature.xml PRE-CREATION
> http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/dynamic-width.width/taming.js PRE-CREATION
> http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/dynamic-width/dynamic-width.js PRE-CREATION
> http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/dynamic-height.util/taming.js 1147953
> http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/dynamic-height/feature.xml 1147953
> http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/dynamic-size.util/dynamic-size-util.js PRE-CREATION
> http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/dynamic-size.util/feature.xml PRE-CREATION
> http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/dynamic-size.util/taming.js PRE-CREATION
> http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/dynamic-width.width/dynamic-width-width.js PRE-CREATION
> http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/dynamic-height.height/feature.xml 1147953
> http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/dynamic-height.util/dynamic-height-util.js 1147953
> http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/dynamic-height.util/feature.xml 1147953
> http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/container/container.js 1147953
>
> Diff: https://reviews.apache.org/r/982/diff
>
>
> Testing
> -------
>
> Tested against Firefox 3.6, Chrome 12, Safari 5 in a custom container
>
>
> Thanks,
>
> cheelan
>
>
Re: Review Request: Implementation of a dynamic width feature
Posted by ch...@us.ibm.com.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/982/
-----------------------------------------------------------
(Updated 2011-07-18 18:36:11.367786)
Review request for shindig, Ryan Baxter, Stanton Sievers, and Dan Dumont.
Changes
-------
Above issues addressed.
Summary
-------
This is the reference implementation for the dynamic width OpenSocial spec change:
http://code.google.com/p/opensocial-resources/issues/detail?id=1191&colspec=ID%20Type%20Container%20Stars%20Summary%20Status
This change also incorporates the change posed here: https://reviews.apache.org/r/974/
That change is necessary in order for the rpc callback in Dynamic Width to function properly.
Diffs (updated)
-----
http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/dynamic-width/taming.js PRE-CREATION
http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/features.txt 1147953
http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/dynamic-width/feature.xml PRE-CREATION
http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/dynamic-width.width/feature.xml PRE-CREATION
http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/dynamic-width.width/taming.js PRE-CREATION
http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/dynamic-width/dynamic-width.js PRE-CREATION
http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/dynamic-height.util/taming.js 1147953
http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/dynamic-height/feature.xml 1147953
http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/dynamic-size.util/dynamic-size-util.js PRE-CREATION
http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/dynamic-size.util/feature.xml PRE-CREATION
http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/dynamic-size.util/taming.js PRE-CREATION
http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/dynamic-width.width/dynamic-width-width.js PRE-CREATION
http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/dynamic-height.height/feature.xml 1147953
http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/dynamic-height.util/dynamic-height-util.js 1147953
http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/dynamic-height.util/feature.xml 1147953
http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/container/container.js 1147953
Diff: https://reviews.apache.org/r/982/diff
Testing
-------
Tested against Firefox 3.6, Chrome 12, Safari 5 in a custom container
Thanks,
cheelan
Re: Review Request: Implementation of a dynamic width feature
Posted by Henry Saputra <hs...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/982/#review1098
-----------------------------------------------------------
http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/dynamic-size.util/feature.xml
<https://reviews.apache.org/r/982/#comment2227>
Change to dynamic-size.viewport
http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/dynamic-width.width/dynamic-width-width.js
<https://reviews.apache.org/r/982/#comment2229>
Where is the "vw" defined? Do you mean viewportWidth?
http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/features.txt
<https://reviews.apache.org/r/982/#comment2228>
Where is this alert/feature.xml file coming from?
- Henry
On 2011-07-18 17:39:23, cheelan wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/982/
> -----------------------------------------------------------
>
> (Updated 2011-07-18 17:39:23)
>
>
> Review request for shindig, Ryan Baxter, Stanton Sievers, and Dan Dumont.
>
>
> Summary
> -------
>
> This is the reference implementation for the dynamic width OpenSocial spec change:
> http://code.google.com/p/opensocial-resources/issues/detail?id=1191&colspec=ID%20Type%20Container%20Stars%20Summary%20Status
>
> This change also incorporates the change posed here: https://reviews.apache.org/r/974/
> That change is necessary in order for the rpc callback in Dynamic Width to function properly.
>
>
> Diffs
> -----
>
> http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/dynamic-height.util/dynamic-height-util.js 1147953
> http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/dynamic-height.util/feature.xml 1147953
> http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/dynamic-height.util/taming.js 1147953
> http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/dynamic-height/feature.xml 1147953
> http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/dynamic-size.util/dynamic-size-util.js PRE-CREATION
> http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/dynamic-size.util/feature.xml PRE-CREATION
> http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/dynamic-size.util/taming.js PRE-CREATION
> http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/dynamic-width.width/dynamic-width-width.js PRE-CREATION
> http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/dynamic-width.width/feature.xml PRE-CREATION
> http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/dynamic-width.width/taming.js PRE-CREATION
> http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/dynamic-width/dynamic-width.js PRE-CREATION
> http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/dynamic-width/feature.xml PRE-CREATION
> http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/dynamic-width/taming.js PRE-CREATION
> http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/features.txt 1147953
> http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/container/container.js 1147953
> http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/dynamic-height.height/feature.xml 1147953
>
> Diff: https://reviews.apache.org/r/982/diff
>
>
> Testing
> -------
>
> Tested against Firefox 3.6, Chrome 12, Safari 5 in a custom container
>
>
> Thanks,
>
> cheelan
>
>
Re: Review Request: Implementation of a dynamic width feature
Posted by ch...@us.ibm.com.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/982/
-----------------------------------------------------------
(Updated 2011-07-18 17:39:23.248799)
Review request for shindig, Ryan Baxter, Stanton Sievers, and Dan Dumont.
Summary
-------
This is the reference implementation for the dynamic width OpenSocial spec change:
http://code.google.com/p/opensocial-resources/issues/detail?id=1191&colspec=ID%20Type%20Container%20Stars%20Summary%20Status
This change also incorporates the change posed here: https://reviews.apache.org/r/974/
That change is necessary in order for the rpc callback in Dynamic Width to function properly.
Diffs (updated)
-----
http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/dynamic-height.util/dynamic-height-util.js 1147953
http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/dynamic-height.util/feature.xml 1147953
http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/dynamic-height.util/taming.js 1147953
http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/dynamic-height/feature.xml 1147953
http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/dynamic-size.util/dynamic-size-util.js PRE-CREATION
http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/dynamic-size.util/feature.xml PRE-CREATION
http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/dynamic-size.util/taming.js PRE-CREATION
http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/dynamic-width.width/dynamic-width-width.js PRE-CREATION
http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/dynamic-width.width/feature.xml PRE-CREATION
http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/dynamic-width.width/taming.js PRE-CREATION
http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/dynamic-width/dynamic-width.js PRE-CREATION
http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/dynamic-width/feature.xml PRE-CREATION
http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/dynamic-width/taming.js PRE-CREATION
http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/features.txt 1147953
http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/container/container.js 1147953
http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/dynamic-height.height/feature.xml 1147953
Diff: https://reviews.apache.org/r/982/diff
Testing
-------
Tested against Firefox 3.6, Chrome 12, Safari 5 in a custom container
Thanks,
cheelan