You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@netbeans.apache.org by GitBox <gi...@apache.org> on 2022/07/22 21:24:07 UTC
[GitHub] [netbeans] mbien opened a new pull request, #4429: remove usages of deprecated junit.framework.Assert.
mbien opened a new pull request, #4429:
URL: https://github.com/apache/netbeans/pull/4429
project wide cleanup which should get rid of a bunch of build warnings.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] mbien merged pull request #4429: remove usages of deprecated junit.framework.Assert.
Posted by GitBox <gi...@apache.org>.
mbien merged PR #4429:
URL: https://github.com/apache/netbeans/pull/4429
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] BradWalker commented on pull request #4429: remove usages of deprecated junit.framework.Assert.
Posted by GitBox <gi...@apache.org>.
BradWalker commented on PR #4429:
URL: https://github.com/apache/netbeans/pull/4429#issuecomment-1242630511
Looks good to me..
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] matthiasblaesing commented on a diff in pull request #4429: remove usages of deprecated junit.framework.Assert.
Posted by GitBox <gi...@apache.org>.
matthiasblaesing commented on code in PR #4429:
URL: https://github.com/apache/netbeans/pull/4429#discussion_r941751068
##########
ide/html.editor/test/unit/src/org/netbeans/modules/html/editor/completion/HtmlCompletionTestSupport.java:
##########
@@ -114,7 +113,7 @@ public void run() {
try {
assertCompletionItemNames(expectedItemsNames, items, type);
- } catch (AssertionFailedError e) {
+ } catch (AssertionError e) {
Review Comment:
I won't go into discussion over this and feel free to ignore this.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] mbien commented on pull request #4429: remove usages of deprecated junit.framework.Assert.
Posted by GitBox <gi...@apache.org>.
mbien commented on PR #4429:
URL: https://github.com/apache/netbeans/pull/4429#issuecomment-1243116683
squashing the commits and preparing for merge
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] matthiasblaesing commented on a diff in pull request #4429: remove usages of deprecated junit.framework.Assert.
Posted by GitBox <gi...@apache.org>.
matthiasblaesing commented on code in PR #4429:
URL: https://github.com/apache/netbeans/pull/4429#discussion_r940500555
##########
ide/html.editor/test/unit/src/org/netbeans/modules/html/editor/completion/HtmlCompletionTestSupport.java:
##########
@@ -114,7 +113,7 @@ public void run() {
try {
assertCompletionItemNames(expectedItemsNames, items, type);
- } catch (AssertionFailedError e) {
+ } catch (AssertionError e) {
Review Comment:
Wouldn't it be easier to create this output in `assertCompletionItemNames`, add a sensible info in front of it and use it as the message of the delegated `assert*` calls there?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] mbien commented on a diff in pull request #4429: remove usages of deprecated junit.framework.Assert.
Posted by GitBox <gi...@apache.org>.
mbien commented on code in PR #4429:
URL: https://github.com/apache/netbeans/pull/4429#discussion_r940636621
##########
ide/html.editor/test/unit/src/org/netbeans/modules/html/editor/completion/HtmlCompletionTestSupport.java:
##########
@@ -114,7 +113,7 @@ public void run() {
try {
assertCompletionItemNames(expectedItemsNames, items, type);
- } catch (AssertionFailedError e) {
+ } catch (AssertionError e) {
Review Comment:
the problem is that this is a public utility method with several usages. I didn't want to rewrite too much and make this PR even larger. Simply catching `AssertionError` seemed like the easiest solution.
It would have been dangerous if the utility method would call into NB code which has java assert statements and the test would expect a junit assert failure. If NB code would fail for the wrong reason, the test would pass instead of fail. But this here should be safe.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists