You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@ignite.apache.org by "Nikolay Izhikov (JIRA)" <ji...@apache.org> on 2017/07/31 13:08:00 UTC
[jira] [Comment Edited] (IGNITE-5866)
JettyRestProcessorUnsignedSelfTest and JettyRestProcessorSignedSelfTest
fails on master
[ https://issues.apache.org/jira/browse/IGNITE-5866?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16107224#comment-16107224 ]
Nikolay Izhikov edited comment on IGNITE-5866 at 7/31/17 1:07 PM:
------------------------------------------------------------------
Results of investigation of this issue.
Problem for both test-cases the same.
{{cache.context().queries().sqlMetadata()}} returns information about cache for storing atomic data structures - "ignite-sys-atomic-cache@default-ds-group". Cache for atomic created in {{testIncrement}} or {{testDecrement}} test-case.
ignite-sys-atomic-cache@default-ds-group created in
{code:java}
//DataStructuresProcessor.java:494
if (type.isVolatile())
grpName = DEFAULT_VOLATILE_DS_GROUP_NAME;
else if (cfg.getGroupName() != null)
grpName = cfg.getGroupName();
else
grpName = DEFAULT_DS_GROUP_NAME;
String cacheName = ATOMICS_CACHE_NAME + "@" + grpName;
IgniteInternalCache<GridCacheInternalKey, AtomicDataStructureValue> cache0 = ctx.cache().cache(cacheName);
{code}
List of cache collected by sqlMetadata method is filtered in GridCacheQueryManager$MetadataJob#call
{code:java}
// GridCacheQueryManager.java:2068
new P1<IgniteInternalCache<?, ?>>() {
@Override public boolean apply(IgniteInternalCache<?, ?> c) {
return !CU.UTILITY_CACHE_NAME.equals(c.name());
}
}
/** System cache name. */
public static final String UTILITY_CACHE_NAME = "ignite-sys-cache";
{code}
As far as I can see MetadataJob filter was modified by commit 804ce8243a8d19c3d5b4ca96b905ec18ee0139cf by Ilya Lantukh.
Should I fix MetadataJob filter? Or I just need to fix asserts in test-cases?
was (Author: nizhikov):
Results of investigation of this issue.
Problem with test-cases the same - {{cache.context().queries().sqlMetadata()}} returns information about cache for storing atomic data structures - "ignite-sys-atomic-cache@default-ds-group". Cache for atomic created in {{testIncrement}} or {{testDecrement}} test-case.
ignite-sys-atomic-cache@default-ds-group created in
{code:java}
//DataStructuresProcessor.java:494
if (type.isVolatile())
grpName = DEFAULT_VOLATILE_DS_GROUP_NAME;
else if (cfg.getGroupName() != null)
grpName = cfg.getGroupName();
else
grpName = DEFAULT_DS_GROUP_NAME;
String cacheName = ATOMICS_CACHE_NAME + "@" + grpName;
IgniteInternalCache<GridCacheInternalKey, AtomicDataStructureValue> cache0 = ctx.cache().cache(cacheName);
{code}
List of cache collected by sqlMetadata method is filtered in GridCacheQueryManager$MetadataJob#call
{code:java}
// GridCacheQueryManager.java:2068
new P1<IgniteInternalCache<?, ?>>() {
@Override public boolean apply(IgniteInternalCache<?, ?> c) {
return !CU.UTILITY_CACHE_NAME.equals(c.name());
}
}
/** System cache name. */
public static final String UTILITY_CACHE_NAME = "ignite-sys-cache";
{code}
As far as I can see MetadataJob filter was modified by commit 804ce8243a8d19c3d5b4ca96b905ec18ee0139cf by Ilya Lantukh.
Should I fix MetadataJob filter? Or I just need to fix asserts in test-cases?
> JettyRestProcessorUnsignedSelfTest and JettyRestProcessorSignedSelfTest fails on master
> ---------------------------------------------------------------------------------------
>
> Key: IGNITE-5866
> URL: https://issues.apache.org/jira/browse/IGNITE-5866
> Project: Ignite
> Issue Type: Bug
> Components: clients
> Affects Versions: 2.1
> Reporter: Nikolay Izhikov
> Assignee: Nikolay Izhikov
> Priority: Minor
> Labels: MakeTeamcityGreenAgain
> Fix For: 2.2
>
>
> JettyRestProcessorSignedSelfTest and JettyRestProcessorUnsignedSelfTest fails on master
> when run whole test class.
> If run single method both tests succeed.
> testMetadataLocal:
> {noformat}
> junit.framework.AssertionFailedError: expected:<5> but was:<6>
> at junit.framework.Assert.fail(Assert.java:57)
> at junit.framework.Assert.failNotEquals(Assert.java:329)
> at junit.framework.Assert.assertEquals(Assert.java:78)
> at junit.framework.Assert.assertEquals(Assert.java:234)
> at junit.framework.Assert.assertEquals(Assert.java:241)
> at junit.framework.TestCase.assertEquals(TestCase.java:409)
> at org.apache.ignite.internal.processors.rest.JettyRestProcessorAbstractSelfTest.testMetadataLocal(JettyRestProcessorAbstractSelfTest.java:1127)
> {noformat}
> testMetadataRemote
> {noformat}
> junit.framework.AssertionFailedError: expected:<6> but was:<7>
> at junit.framework.Assert.fail(Assert.java:57)
> at junit.framework.Assert.failNotEquals(Assert.java:329)
> at junit.framework.Assert.assertEquals(Assert.java:78)
> at junit.framework.Assert.assertEquals(Assert.java:234)
> at junit.framework.Assert.assertEquals(Assert.java:241)
> at junit.framework.TestCase.assertEquals(TestCase.java:409)
> at org.apache.ignite.internal.processors.rest.JettyRestProcessorAbstractSelfTest.testMetadataRemote(JettyRestProcessorAbstractSelfTest.java:1174)
> {noformat}
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)