[GitHub] [incubator-gobblin] sv2000 commented on a change in pull request #2647: [GOBBLIN-781] Skeleton for GaaS DR mode clean transition

[GitBox <gi...@apache.org>]

sv2000 commented on a change in pull request #2647: [GOBBLIN-781] Skeleton for GaaS DR mode clean transition
URL: https://github.com/apache/incubator-gobblin/pull/2647#discussion_r289201334
 
 

 ##########
 File path: gobblin-service/src/main/java/org/apache/gobblin/service/modules/scheduler/GobblinServiceJobScheduler.java
 ##########
 @@ -135,28 +158,30 @@ public void run() {
    * Load all {@link FlowSpec}s from {@link FlowCatalog} as one of the initialization step,
    * and make schedulers be aware of that.
    *
+   * If it is newly brought up as the DR handler, will load additional FlowSpecs and handle transition properly.
    */
   private void scheduleSpecsFromCatalog() {
     Iterator<URI> specUris = null;
     long startTime = System.currentTimeMillis();
 
     try {
       specUris = this.flowCatalog.get().getSpecURIs();
+
+      // If current instances nominated as DR handler, will take additional URIS from FlowCatalog.
+      if (isNominatedDRHanlder) {
 
 Review comment:
   isNominatedDRHandler?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services