You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@sdap.apache.org by GitBox <gi...@apache.org> on 2022/06/20 15:04:52 UTC

[GitHub] [incubator-sdap-nexus] JordanGethers opened a new pull request, #166: CDMS - 150 NETCDF Reader Updates

JordanGethers opened a new pull request, #166:
URL: https://github.com/apache/incubator-sdap-nexus/pull/166

   cdms_reader.py is the original doms_reader.py code with additional functionality provided for the user to make each run of the program more customizable. The user may now select, with option flags, whether or whether not they would like to create a CSV, log, or text (holds global attributes) files associated with their original NETCDF file.
   
   The ReadMe associated with this file has also been updated to reflect changes in the program.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@sdap.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-sdap-nexus] ngachung closed pull request #166: CDMS - 150 NETCDF Reader Updates

Posted by GitBox <gi...@apache.org>.
ngachung closed pull request #166: CDMS - 150 NETCDF Reader Updates
URL: https://github.com/apache/incubator-sdap-nexus/pull/166


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@sdap.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-sdap-nexus] JordanGethers commented on pull request #166: CDMS - 150 NETCDF Reader Updates

Posted by GitBox <gi...@apache.org>.
JordanGethers commented on PR #166:
URL: https://github.com/apache/incubator-sdap-nexus/pull/166#issuecomment-1181826386

   Hello Nga,
   
   I made the adjustments you mentioned for SDAP-390, but I don't exactly understand where to put the code since you say that JIRA is private and not public. Do I still push to the GitHub like I did last time? The GitHub seems to be public, and I don't see an obvious place to put the code on the Apache website.
   
   Best,
   
   Jordan Gethers
   Florida State University | MS Computer Science
   ***@***.***
   ________________________________
   From: Nga Chung ***@***.***>
   Sent: Friday, July 8, 2022 12:43 PM
   To: apache/incubator-sdap-nexus ***@***.***>
   Cc: Jordan Gethers ***@***.***>; Mention ***@***.***>
   Subject: Re: [apache/incubator-sdap-nexus] CDMS - 150 NETCDF Reader Updates (PR #166)
   
   
   Thank you, @JordanGethers<https://urldefense.com/v3/__https://github.com/JordanGethers__;!!Epnw_ITfSMW4!u7HnazB1d2fBcAXfhyA1gI6ziH03WGfqUdqnKQ_jAdavz2ajGROBkEUTEtl5eICvZZ7ime6YjzF8CkgPhkXx_NvpgkHt$>!
   
   Please reference https://issues.apache.org/jira/projects/SDAP/issues/SDAP-390<https://urldefense.com/v3/__https://issues.apache.org/jira/projects/SDAP/issues/SDAP-390__;!!Epnw_ITfSMW4!u7HnazB1d2fBcAXfhyA1gI6ziH03WGfqUdqnKQ_jAdavz2ajGROBkEUTEtl5eICvZZ7ime6YjzF8CkgPhkXx_CVlzTDx$> as CDMS Jira is restricted and not public.
   Please also update CHANGELOG.md
   It's great that the dependent libraries are provided in the readme, but please also include requirements.txt or conda-requirements.txt so that users can easily set up env for using the reader.
   
   —
   Reply to this email directly, view it on GitHub<https://urldefense.com/v3/__https://github.com/apache/incubator-sdap-nexus/pull/166*issuecomment-1179182763__;Iw!!Epnw_ITfSMW4!u7HnazB1d2fBcAXfhyA1gI6ziH03WGfqUdqnKQ_jAdavz2ajGROBkEUTEtl5eICvZZ7ime6YjzF8CkgPhkXx_E1ej30n$>, or unsubscribe<https://urldefense.com/v3/__https://github.com/notifications/unsubscribe-auth/ALJMXGT3NYTZZIK3MHZYX4TVTBLDFANCNFSM5ZJHUTLA__;!!Epnw_ITfSMW4!u7HnazB1d2fBcAXfhyA1gI6ziH03WGfqUdqnKQ_jAdavz2ajGROBkEUTEtl5eICvZZ7ime6YjzF8CkgPhkXx_C_l6323$>.
   You are receiving this because you were mentioned.Message ID: ***@***.***>
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@sdap.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-sdap-nexus] ngachung commented on pull request #166: CDMS - 150 NETCDF Reader Updates

Posted by GitBox <gi...@apache.org>.
ngachung commented on PR #166:
URL: https://github.com/apache/incubator-sdap-nexus/pull/166#issuecomment-1181956713

   Sorry for the confusion @JordanGethers. Yes, the github repository is public, but the CDMS JIRA is restricted. Please push all your changes to your forked repo, but where you've referenced CDMS - 150, e.g. in the pull request title, please replace with SDAP-390: Match up NETCDF Reader Updates. Branch name of SDAP-XXX should be SDAP-390. Thank you!


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@sdap.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-sdap-nexus] ngachung commented on pull request #166: CDMS - 150 NETCDF Reader Updates

Posted by GitBox <gi...@apache.org>.
ngachung commented on PR #166:
URL: https://github.com/apache/incubator-sdap-nexus/pull/166#issuecomment-1179182763

   Thank you, @JordanGethers!
   
   Please reference https://issues.apache.org/jira/projects/SDAP/issues/SDAP-390 as CDMS Jira is restricted and not public.
   Please also update CHANGELOG.md
   It's great that the dependent libraries are provided in the readme, but please also include requirements.txt or conda-requirements.txt so that users can easily set up env for using the reader.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@sdap.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-sdap-nexus] ngachung commented on pull request #166: CDMS - 150 NETCDF Reader Updates

Posted by GitBox <gi...@apache.org>.
ngachung commented on PR #166:
URL: https://github.com/apache/incubator-sdap-nexus/pull/166#issuecomment-1202991601

   This PR has been superseded by https://github.com/apache/incubator-sdap-nexus/pull/178 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@sdap.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-sdap-nexus] JordanGethers commented on pull request #166: CDMS - 150 NETCDF Reader Updates

Posted by GitBox <gi...@apache.org>.
JordanGethers commented on PR #166:
URL: https://github.com/apache/incubator-sdap-nexus/pull/166#issuecomment-1160567896

   When I run the code in my linux environment, there are some harmless warning messages (pertaining to numPy and occasionally variable conversion) I wanted to ask for approval or suggestions before suppressing any warning messages (if at all).


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@sdap.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org