You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@submarine.apache.org by GitBox <gi...@apache.org> on 2020/08/13 15:59:43 UTC
[GitHub] [submarine] manirajv06 commented on a change in pull request #374: SUBMARINE-598. Support get environment list from database
manirajv06 commented on a change in pull request #374:
URL: https://github.com/apache/submarine/pull/374#discussion_r470058266
##########
File path: submarine-server/server-core/src/main/java/org/apache/submarine/server/rest/EnvironmentRestApi.java
##########
@@ -159,6 +159,30 @@ public Response listEnvironment(@QueryParam("status") String status) {
}
}
+ /**
+ * List all environments from database.
+ * @return environment list
+ */
+ @GET
+ @Path("/list")
+ @Operation(summary = "List of Environments from database",
+ tags = {"environments"},
+ responses = {
+ @ApiResponse(description = "successful operation",
+ content = @Content(
+ schema = @Schema(
+ implementation = Environment.class)))})
+ public Response listAllEnvironments() {
Review comment:
@kobe860219 Thanks for working on this. Even from API end point perspective, I don't see a need for "list". Just typing "/v1/environment" should return the list of environments. Change is required only in model layer.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org