[GitHub] [nifi] bbende commented on a change in pull request #3404: NIFI-5176 Java 11 Build Compatibilty

[GitBox <gi...@apache.org>]

bbende commented on a change in pull request #3404: NIFI-5176 Java 11 Build Compatibilty
URL: https://github.com/apache/nifi/pull/3404#discussion_r308329036
 
 

 ##########
 File path: nifi-commons/nifi-site-to-site-client/pom.xml
 ##########
 @@ -61,14 +61,14 @@
             <version>1.10.0-SNAPSHOT</version>
         </dependency>
         <dependency>
-            <groupId>org.apache.httpcomponents</groupId>
-            <artifactId>httpclient</artifactId>
-            <version>4.5.5</version>
+            <groupId>org.apache.httpcomponents.client5</groupId>
+            <artifactId>httpclient5</artifactId>
+            <version>5.0-beta4</version>
 
 Review comment:
   Not totally sure if this would work, but can the dependency use all properties like:
   
   ```
           <dependency>
               <groupId>${httpclient.group}</groupId>
               <artifactId>${httpclient.artifact}</artifactId>
               <version>${httpclient.versopm}</version>
           </dependency>
   ```
   
   The default properties would be:
   ```
   <httpclient.group>org.apache.httpcomponents</httpclient.group> 
   <httpclient.artifact>httpclient</httpclient.artifact> 
   <httpclient.version>4.5.5</httpclient.version> 
   ```
   and then in the jigsaw profile it would override them to:
   ```
   <httpclient.group>org.apache.httpcomponents.client5</httpclient.group> 
   <httpclient.artifact>httpclient5</httpclient.artifact> 
   <httpclient.version>5.0-beta4</httpclient.version> 
   ```

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services