[GitHub] [maven] slachiewicz commented on a change in pull request #301: [MNG-6819] Fix NullPointerException in StringVisitorModelInterpolator$ModelVisitor

[GitBox <gi...@apache.org>]

slachiewicz commented on a change in pull request #301:
URL: https://github.com/apache/maven/pull/301#discussion_r427882396



##########
File path: maven-model-builder/src/main/java/org/apache/maven/model/interpolation/StringVisitorModelInterpolator.java
##########
@@ -1424,7 +1424,7 @@ private void visit( Properties properties )
                     {
                         String value = (String) v;
                         String inter = interpolate( value );
-                        if ( value != inter )
+                        if ( value != inter && inter != null )

Review comment:
       there is no need to log any - null is the normal value returned from `interpolate()` function




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org