[GitHub] [pulsar] codelipenghui commented on a diff in pull request #16617: [improve] [txn] [PIP-160] Make transactions work more efficiently by aggregation operation for transaction log and pending ack store

[GitBox <gi...@apache.org>]

codelipenghui commented on code in PR #16617:
URL: https://github.com/apache/pulsar/pull/16617#discussion_r921911428


##########
conf/broker.conf:
##########
@@ -1535,4 +1535,28 @@ managedLedgerMaxUnackedRangesToPersistInZooKeeper=-1
 
 # If enabled, the maximum "acknowledgment holes" will not be limited and "acknowledgment holes" are stored in
 # multiple entries.
-persistentUnackedRangesWithMultipleEntriesEnabled=false
\ No newline at end of file
+persistentUnackedRangesWithMultipleEntriesEnabled=false
+
+# Provide a mechanism allowing the Transaction Log Store to aggregate multiple records into a batched record and
+# persist into a single BK entry. This will make Pulsar transactions work more  efficiently, aka batched log.
+# see: https://github.com/apache/pulsar/issues/15370
+transactionLogBatchedWriteEnabled = false;

Review Comment:
   ```suggestion
   transactionLogBatchedWriteEnabled=false;
   ```
   
   Please check all.



##########
conf/broker.conf:
##########
@@ -1535,4 +1535,28 @@ managedLedgerMaxUnackedRangesToPersistInZooKeeper=-1
 
 # If enabled, the maximum "acknowledgment holes" will not be limited and "acknowledgment holes" are stored in
 # multiple entries.
-persistentUnackedRangesWithMultipleEntriesEnabled=false
\ No newline at end of file
+persistentUnackedRangesWithMultipleEntriesEnabled=false
+
+# Provide a mechanism allowing the Transaction Log Store to aggregate multiple records into a batched record and
+# persist into a single BK entry. This will make Pulsar transactions work more  efficiently, aka batched log.
+# see: https://github.com/apache/pulsar/issues/15370
+transactionLogBatchedWriteEnabled = false;
+# If enabled the feature that transaction log batch, this attribute means maximum log records count in a batch.
+transactionLogBatchedWriteMaxRecords= 512;
+# If enabled the feature that transaction log batch, this attribute means bytes size in a batch.
+transactionLogBatchedWriteMaxSize= 1024 * 1024 * 4;

Review Comment:
   I think we can't user `1024 * 1024 * 4` here?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org