You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@lenya.apache.org by bu...@apache.org on 2007/11/14 22:18:41 UTC

DO NOT REPLY [Bug 43861] New: - Restoring from archive can create ghost nodes

DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG�
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
<http://issues.apache.org/bugzilla/show_bug.cgi?id=43861>.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND�
INSERTED IN THE BUG DATABASE.

http://issues.apache.org/bugzilla/show_bug.cgi?id=43861

           Summary: Restoring from archive can create ghost nodes
           Product: Lenya
           Version: Trunk
          Platform: PC
        OS/Version: Windows XP
            Status: NEW
          Severity: normal
          Priority: P2
         Component: Site Management
        AssignedTo: dev@lenya.apache.org
        ReportedBy: mangst@inventec.ch


If you restore a subtree from archive, you can create a "ghost" node. Steps to
reproduce:
- build clean / build
- import example content
- go to site tab
- select subtree "Tutorials"
- create a new document called "World" with file / new xhtml document
- copy subtree "Resource type examples"
- select subtree "World"
- paste subtree "Resource type examples"
- archive subtree "Resource type examples"
- delete subtree "World" with edit / delete
- go to archive, select subtree "Resource type examples" and restore it
- you get a "ghost" entry between "Tutorials" and "Resource type examples"
  called "World" that is greyed out and thus can't be selected / modified

-- 
Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lenya.apache.org
For additional commands, e-mail: dev-help@lenya.apache.org


DO NOT REPLY [Bug 43861] - Restoring from archive can create ghost nodes

Posted by bu...@apache.org.
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG�
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
<http://issues.apache.org/bugzilla/show_bug.cgi?id=43861>.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND�
INSERTED IN THE BUG DATABASE.

http://issues.apache.org/bugzilla/show_bug.cgi?id=43861





------- Additional Comments From andreas@apache.org  2007-11-19 04:43 -------
(In reply to comment #6)
> > AFAIK the workflow is not triggered with cut&paste. This operation should
> > actually not be allowed, if it is, it's certainly a bug.
> 
> You are right. Cut & paste out of the archive does not work. Well, cutting out
> of the archive *seems* to work (menu entry black and no error message after
> cut)

Cut/copy from any area but authoring is now disabled.

-- 
Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lenya.apache.org
For additional commands, e-mail: dev-help@lenya.apache.org


DO NOT REPLY [Bug 43861] - Restoring from archive can create ghost nodes

Posted by bu...@apache.org.
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG�
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
<http://issues.apache.org/bugzilla/show_bug.cgi?id=43861>.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND�
INSERTED IN THE BUG DATABASE.

http://issues.apache.org/bugzilla/show_bug.cgi?id=43861


mangst@inventec.ch changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Target Milestone|2.0.1                       |2.0




-- 
Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lenya.apache.org
For additional commands, e-mail: dev-help@lenya.apache.org


DO NOT REPLY [Bug 43861] - Restoring from archive can create ghost nodes

Posted by bu...@apache.org.
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG�
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
<http://issues.apache.org/bugzilla/show_bug.cgi?id=43861>.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND�
INSERTED IN THE BUG DATABASE.

http://issues.apache.org/bugzilla/show_bug.cgi?id=43861





------- Additional Comments From rfrovarp@apache.org  2007-11-27 13:14 -------
(In reply to comment #1)
> What should we do about this?
> 
> a) don't allow to restore if parent doesn't exist

I would do this. I've done some testing and since the parent is determined by
path instead of UUID, a new parent can be created and restored content will go
back under it. 

-- 
Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lenya.apache.org
For additional commands, e-mail: dev-help@lenya.apache.org


DO NOT REPLY [Bug 43861] - Restoring from archive can create ghost nodes

Posted by bu...@apache.org.
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG�
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
<http://issues.apache.org/bugzilla/show_bug.cgi?id=43861>.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND�
INSERTED IN THE BUG DATABASE.

http://issues.apache.org/bugzilla/show_bug.cgi?id=43861





------- Additional Comments From andreas@apache.org  2007-11-15 09:24 -------
(In reply to comment #4)
> > OK, whereas we have to be careful with cut&paste because of the workflow.
> 
> Does a restore atm work different from cut&paste concerning workflow?

AFAIK the workflow is not triggered with cut&paste. This operation should
actually not be allowed, if it is, it's certainly a bug.

-- 
Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lenya.apache.org
For additional commands, e-mail: dev-help@lenya.apache.org


DO NOT REPLY [Bug 43861] - Restoring from archive can create ghost nodes

Posted by bu...@apache.org.
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG�
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
<http://issues.apache.org/bugzilla/show_bug.cgi?id=43861>.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND�
INSERTED IN THE BUG DATABASE.

http://issues.apache.org/bugzilla/show_bug.cgi?id=43861





------- Additional Comments From mangst@inventec.ch  2007-11-15 09:03 -------
> OK, whereas we have to be careful with cut&paste because of the workflow.

Does a restore atm work different from cut&paste concerning workflow?



-- 
Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lenya.apache.org
For additional commands, e-mail: dev-help@lenya.apache.org


DO NOT REPLY [Bug 43861] - Restoring from archive can create ghost nodes

Posted by bu...@apache.org.
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG�
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
<http://issues.apache.org/bugzilla/show_bug.cgi?id=43861>.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND�
INSERTED IN THE BUG DATABASE.

http://issues.apache.org/bugzilla/show_bug.cgi?id=43861





------- Additional Comments From mangst@inventec.ch  2007-11-15 07:50 -------
> What should we do about this?
> 
> a) don't allow to restore if parent doesn't exist

Yes, and show a message like "The node or subtree cannot be restored to its
original position. Use cut and paste instead to move the node out of the archve
to the desired position." or something like that.

> b) allow to manipulate (delete) "ghost" nodes

I think this should only be done if it is necessary for other situations, too.

> c) ... ?

Automatically skip dead nodes while restoring. This will most probably lead to
unexpected/unwanted results (like name conflicts).

-- 
Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lenya.apache.org
For additional commands, e-mail: dev-help@lenya.apache.org


DO NOT REPLY [Bug 43861] - Restoring from archive can create ghost nodes

Posted by bu...@apache.org.
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG�
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
<http://issues.apache.org/bugzilla/show_bug.cgi?id=43861>.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND�
INSERTED IN THE BUG DATABASE.

http://issues.apache.org/bugzilla/show_bug.cgi?id=43861


rfrovarp@apache.org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Target Milestone|2.0                         |2.0.1




------- Additional Comments From rfrovarp@apache.org  2007-11-27 14:32 -------
(In reply to comment #8)
> (In reply to comment #1)
> > What should we do about this?
> > 
> > a) don't allow to restore if parent doesn't exist
> 
> I would do this. I've done some testing and since the parent is determined by
> path instead of UUID, a new parent can be created and restored content will go
> back under it. 

This is what I've done. It's in r598789. Users can now no longer restore if
ghost nodes will be created. User must recreate the parent nodes, then they can
restore. 

I'm not saying this should be the final solution, but I do think it allows us to
defer the issue until 2.0.1.

-- 
Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lenya.apache.org
For additional commands, e-mail: dev-help@lenya.apache.org


DO NOT REPLY [Bug 43861] - Restoring from archive can create ghost nodes

Posted by bu...@apache.org.
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG�
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
<http://issues.apache.org/bugzilla/show_bug.cgi?id=43861>.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND�
INSERTED IN THE BUG DATABASE.

http://issues.apache.org/bugzilla/show_bug.cgi?id=43861





------- Additional Comments From andreas@apache.org  2007-11-15 07:29 -------
What should we do about this?

a) don't allow to restore if parent doesn't exist
b) allow to manipulate (delete) "ghost" nodes
c) ... ?

-- 
Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lenya.apache.org
For additional commands, e-mail: dev-help@lenya.apache.org


DO NOT REPLY [Bug 43861] - Restoring from archive can create ghost nodes

Posted by bu...@apache.org.
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG�
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
<http://issues.apache.org/bugzilla/show_bug.cgi?id=43861>.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND�
INSERTED IN THE BUG DATABASE.

http://issues.apache.org/bugzilla/show_bug.cgi?id=43861





------- Additional Comments From mangst@inventec.ch  2007-11-15 12:14 -------
> AFAIK the workflow is not triggered with cut&paste. This operation should
> actually not be allowed, if it is, it's certainly a bug.

You are right. Cut & paste out of the archive does not work. Well, cutting out
of the archive *seems* to work (menu entry black and no error message after
cut), but pasting does not (menu entry black, but error message after paste: "An
error occured. Please contact your system administrator."). Hmm.

Maybe we could allow deleting ghost nodes in the archive? :-\ How do other CMS
handle this? Maybe ghost nodes should be reanimated on restore?

-- 
Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lenya.apache.org
For additional commands, e-mail: dev-help@lenya.apache.org


DO NOT REPLY [Bug 43861] - Restoring from archive can create ghost nodes

Posted by bu...@apache.org.
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG�
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
<http://issues.apache.org/bugzilla/show_bug.cgi?id=43861>.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND�
INSERTED IN THE BUG DATABASE.

http://issues.apache.org/bugzilla/show_bug.cgi?id=43861





------- Additional Comments From andreas@apache.org  2007-11-15 07:57 -------
(In reply to comment #2)
> > What should we do about this?
> > 
> > a) don't allow to restore if parent doesn't exist
> 
> Yes, and show a message like "The node or subtree cannot be restored to its
> original position. Use cut and paste instead to move the node out of the archve
> to the desired position." or something like that.

OK, whereas we have to be careful with cut&paste because of the workflow.



-- 
Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lenya.apache.org
For additional commands, e-mail: dev-help@lenya.apache.org