You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cloudstack.apache.org by karuturi <gi...@git.apache.org> on 2015/08/31 11:49:51 UTC
[GitHub] cloudstack pull request: Fix findbugs issue: 76, DM_DEFAULT_ENCODI...
GitHub user karuturi opened a pull request:
https://github.com/apache/cloudstack/pull/764
Fix findbugs issue: 76, DM_DEFAULT_ENCODING, Priority: High
ex.printStacktrace prints to System.err by default. Used it and removed
the printwriter which was causing the findbugs issue.
Also, I do not see a reason to write the stacktrace both to stdout and
stderr. But, keeping it as is for now
This fixes the findbugs issues which is reported as new in http://jenkins.buildacloud.org/job/build-master-slowbuild/2191/findbugsResult/new/
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/karuturi/cloudstack findbugs-cglib
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/cloudstack/pull/764.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #764
----
commit 398bbf46de391d95164b5ffec4cd2593dcb6608e
Author: Rajani Karuturi <ra...@citrix.com>
Date: 2015-08-31T09:36:16Z
Fix findbugs issue: 76, DM_DEFAULT_ENCODING, Priority: High
ex.printStacktrace prints to System.err by default. Used it and removed
the printwriter which was causing the findbugs issue.
Also, I do not see a reason to write the stacktrace both to stdout and
stderr. But, keeping it as is for now
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request: Fix findbugs issue: 76, DM_DEFAULT_ENCODI...
Posted by karuturi <gi...@git.apache.org>.
Github user karuturi closed the pull request at:
https://github.com/apache/cloudstack/pull/764
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request: Fix findbugs issue: 76, DM_DEFAULT_ENCODI...
Posted by DaanHoogland <gi...@git.apache.org>.
Github user DaanHoogland commented on the pull request:
https://github.com/apache/cloudstack/pull/764#issuecomment-136332126
@karuturi please have a look at https://github.com/apache/cloudstack/pull/762/files Your solution will work but I like the other one as well.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request: Fix findbugs issue: 76, DM_DEFAULT_ENCODI...
Posted by karuturi <gi...@git.apache.org>.
Github user karuturi commented on the pull request:
https://github.com/apache/cloudstack/pull/764#issuecomment-136590200
closing in favor of a better fix @ #762
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---