You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by "aehanno (via GitHub)" <gi...@apache.org> on 2024/05/10 19:00:42 UTC
[PR] Correction translation [superset]
aehanno opened a new pull request, #28434:
URL: https://github.com/apache/superset/pull/28434
Correction french translation
### SUMMARY
Remove to fuzzy to add the right translation
### BEFORE
### TESTING INSTRUCTIONS
Check that after we got the new translation
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] fix: Correction translation [superset]
Posted by "rusackas (via GitHub)" <gi...@apache.org>.
rusackas commented on PR #28434:
URL: https://github.com/apache/superset/pull/28434#issuecomment-2110461983
Actually @aehanno, in looking at the PR files, there are a whole lot of changed files that look like they have nothing to do with translations. Maybe a rebase is needed?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] fix: Correction translation [superset]
Posted by "mistercrunch (via GitHub)" <gi...@apache.org>.
mistercrunch commented on PR #28434:
URL: https://github.com/apache/superset/pull/28434#issuecomment-2108460290
We really need to pull the `.json` files out of the repository. @rusackas any blockers on removing those files?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] fix: Correction translation [superset]
Posted by "aehanno (via GitHub)" <gi...@apache.org>.
aehanno commented on PR #28434:
URL: https://github.com/apache/superset/pull/28434#issuecomment-2110496170
> Actually @aehanno, in looking at the PR files, there are a whole lot of changed files that look like they have nothing to do with translations. Maybe the rebase didn't work right?
I did another merge and rebase but I still got those change
I don't know why
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] fix: Correction translation [superset]
Posted by "mistercrunch (via GitHub)" <gi...@apache.org>.
mistercrunch commented on PR #28434:
URL: https://github.com/apache/superset/pull/28434#issuecomment-2108799364
Assuming we would:
- add to docker build
- add to official pypi release process
- adapt docs/build instructions
I guess that leaves people building from the repo directly out
From the perspective of pypi/docker it's not a breaking change. For the rest, maybe a note in `UPDATING.md` suffice?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] fix: Correction translation [superset]
Posted by "aehanno (via GitHub)" <gi...@apache.org>.
aehanno commented on PR #28434:
URL: https://github.com/apache/superset/pull/28434#issuecomment-2110593492
@rusackas Can be a solution to create a new branch then the pull request ? Instead of did the correction on this one
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] fix: Correction translation [superset]
Posted by "aehanno (via GitHub)" <gi...@apache.org>.
aehanno commented on PR #28434:
URL: https://github.com/apache/superset/pull/28434#issuecomment-2108659816
> @aehanno regarding the Docker issue, would you mind rebasing?
I merge master and did the rebase
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] Correction translation [superset]
Posted by "codecov[bot] (via GitHub)" <gi...@apache.org>.
codecov[bot] commented on PR #28434:
URL: https://github.com/apache/superset/pull/28434#issuecomment-2105132002
## [Codecov](https://app.codecov.io/gh/apache/superset/pull/28434?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
All modified and coverable lines are covered by tests :white_check_mark:
> Project coverage is 64.38%. Comparing base [(`76d897e`)](https://app.codecov.io/gh/apache/superset/commit/76d897eaa2f9e137102bc194c2e3109c29d0348f?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) to head [(`7f803e2`)](https://app.codecov.io/gh/apache/superset/pull/28434?dropdown=coverage&src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
> Report is 85 commits behind head on master.
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #28434 +/- ##
==========================================
+ Coverage 60.48% 64.38% +3.89%
==========================================
Files 1931 521 -1410
Lines 76236 37401 -38835
Branches 8568 0 -8568
==========================================
- Hits 46114 24080 -22034
+ Misses 28017 13321 -14696
+ Partials 2105 0 -2105
```
| [Flag](https://app.codecov.io/gh/apache/superset/pull/28434/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [hive](https://app.codecov.io/gh/apache/superset/pull/28434/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `49.03% <ø> (-0.14%)` | :arrow_down: |
| [javascript](https://app.codecov.io/gh/apache/superset/pull/28434/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
| [presto](https://app.codecov.io/gh/apache/superset/pull/28434/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `53.59% <ø> (-0.21%)` | :arrow_down: |
| [python](https://app.codecov.io/gh/apache/superset/pull/28434/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `64.38% <ø> (+0.89%)` | :arrow_up: |
| [unit](https://app.codecov.io/gh/apache/superset/pull/28434/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `58.75% <ø> (+1.13%)` | :arrow_up: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
</details>
[:umbrella: View full report in Codecov by Sentry](https://app.codecov.io/gh/apache/superset/pull/28434?dropdown=coverage&src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
:loudspeaker: Have feedback on the report? [Share it here](https://about.codecov.io/codecov-pr-comment-feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] fix: Correction translation [superset]
Posted by "rusackas (via GitHub)" <gi...@apache.org>.
rusackas commented on PR #28434:
URL: https://github.com/apache/superset/pull/28434#issuecomment-2110553009
Yeah, something here isn't right. I suspect you're merging `master` onto your feature branch rather than rebasing. @mistercrunch might have the git-fu to get us out of this mess, but here's a [randomly-slected article](https://www.atlassian.com/git/tutorials/merging-vs-rebasing) on the difference that _miiiight_ help.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] fix: Correction translation [superset]
Posted by "aehanno (via GitHub)" <gi...@apache.org>.
aehanno commented on PR #28434:
URL: https://github.com/apache/superset/pull/28434#issuecomment-2110795441
New PR here https://github.com/apache/superset/pull/28497
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] fix: Correction translation [superset]
Posted by "rusackas (via GitHub)" <gi...@apache.org>.
rusackas commented on PR #28434:
URL: https://github.com/apache/superset/pull/28434#issuecomment-2110457519
@aehanno I think your PR is OK... we're just trying to figure out what to do with the json files, and it's just kind of happening on this thread randomly.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] fix: Correction translation [superset]
Posted by "john-bodley (via GitHub)" <gi...@apache.org>.
john-bodley commented on PR #28434:
URL: https://github.com/apache/superset/pull/28434#issuecomment-2108208852
@aehanno regarding the Docker issue, would you mind rebasing?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] fix: Correction translation [superset]
Posted by "rusackas (via GitHub)" <gi...@apache.org>.
rusackas commented on PR #28434:
URL: https://github.com/apache/superset/pull/28434#issuecomment-2108836246
For others' context, there's a somewhat parallel discussion happening here:
https://github.com/apache/superset/issues/25988
I think it's fair to remove the .mo/.json files if the're auto-generated at a time that supports as many use cases as possible. I'm not sure if dockery/pypi cover all the bases one would expect.
If this were to be done at start time, I think it's pretty quick, but it might be possible to even do it conditionally depending on configuration... then those who have translations enabled always run the freshest translations, no matter how they install/run Superset.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] fix: Correction translation [superset]
Posted by "aehanno (via GitHub)" <gi...@apache.org>.
aehanno commented on PR #28434:
URL: https://github.com/apache/superset/pull/28434#issuecomment-2107571381
As it is link to this issue https://github.com/apache/superset/issues/28431
@rusackas, Do you know what I can do about the Docker error? I didn't modify that part, so I don't understand why I'm getting this error
Thanks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] fix: Correction translation [superset]
Posted by "rusackas (via GitHub)" <gi...@apache.org>.
rusackas commented on PR #28434:
URL: https://github.com/apache/superset/pull/28434#issuecomment-2108788482
> We really need to pull the .json files out of the repository. @rusackas any blockers on removing those files?
Just that people won't have translations anymore... I think you can expect a lot of Issues if that happens. That can be considered as a "breaking change" for 5.0 inclusion if you want to add it to the [5.0 Kanban](https://github.com/orgs/apache/projects/345).
On a related note, there was just an issue where people made a case for bringing the .mo files back. I agree we shouldn't have to include the .json and .mo files in the code base, but to remove them I would hope/expect that they're auto-generated (and gitignored) when installing/starting Superset.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] fix: Correction translation [superset]
Posted by "rusackas (via GitHub)" <gi...@apache.org>.
rusackas commented on PR #28434:
URL: https://github.com/apache/superset/pull/28434#issuecomment-2110636391
@aehanno absolutely. I've definitely done it several times :D
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] fix: Correction translation [superset]
Posted by "aehanno (via GitHub)" <gi...@apache.org>.
aehanno closed pull request #28434: fix: Correction translation
URL: https://github.com/apache/superset/pull/28434
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] fix: Correction translation [superset]
Posted by "aehanno (via GitHub)" <gi...@apache.org>.
aehanno commented on PR #28434:
URL: https://github.com/apache/superset/pull/28434#issuecomment-2110187878
@rusackas It will impact what I did ?
Do I need to change something on my PR
Because I change the mo files then with the po2json I generated the json file
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org