[jira] [Commented] (GEODE-2191) Add more randomized tests for PDX string serialization/deserialization.

["ASF GitHub Bot (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/GEODE-2191?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15733106#comment-15733106 ] 

ASF GitHub Bot commented on GEODE-2191:
---------------------------------------

GitHub user galen-pivotal opened a pull request:

    https://github.com/apache/geode/pull/306

    [GEODE-2191] Test randomized string serialization/deserialization.

    I added this test partly as an exercise in getting used to the Geode codebase, and partly because I'd like to see more randomized testing. The random string generator isn't perfect (I don't think all codepoints in that range are valid), but for our purposes it should be fine.


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/galen-pivotal/incubator-geode feature/GEODE-2191

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/geode/pull/306.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #306
    
----
commit 5cd44dd929545552ad0df1bca3219cd9d80d51cc
Author: Galen O'Sullivan <go...@pivotal.io>
Date:   2016-12-08T18:43:55Z

    [GEODE-2191] Test randomized string serialization/deserialization.

----


> Add more randomized tests for PDX string serialization/deserialization.
> -----------------------------------------------------------------------
>
>                 Key: GEODE-2191
>                 URL: https://issues.apache.org/jira/browse/GEODE-2191
>             Project: Geode
>          Issue Type: Test
>            Reporter: Galen O'Sullivan
>            Assignee: Mark Bretl
>
> There are currently a number of tests for `DataSerializer.writeString` and `DataSerializer.readString`, which cover many of the corner cases we expect for string serialization/deserialization, but it would be nice to have randomized testing that generated Unicode strings and verified that they were the same after being serialized and deserialized.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)