You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@skywalking.apache.org by GitBox <gi...@apache.org> on 2019/09/09 10:46:15 UTC
[GitHub] [skywalking] zhaoyuguang opened a new pull request #3445: Gateway
compatible with downstream loss
zhaoyuguang opened a new pull request #3445: Gateway compatible with downstream loss
URL: https://github.com/apache/skywalking/pull/3445
Please answer these questions before submitting pull request
- Why submit this pull request?
- [x] Bug fix
- [ ] New feature provided
- [ ] Improve performance
- Related issues
https://github.com/apache/skywalking/issues/3428
___
### Bug fix
- Bug description.
When the downstream is lost, the reactor-netty interceptor won't work, but the NettyRoutingFilterInterceptor has do `prepareForAsync` and `stopSpan`
- How to fix?
At `AbstractServerResponseMethodInterceptor` if ServerWebExchange has span and ContextManager get == null, use span.asyncFinish() to report it to backend
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services