You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2020/09/15 13:04:43 UTC

[GitHub] [pulsar] 315157973 opened a new pull request #8068: WebSocket API: support unsubscribing from a topic

315157973 opened a new pull request #8068:
URL: https://github.com/apache/pulsar/pull/8068


   
   Fixes #5005
   
   ### Motivation
   Websocket API doesn't support unsubscribing from a topic, which leaves many subscriptions around that need to be cleaned up by pulsar-admin.
   
   ### Modifications
   add unsubscribe API
   
   ### Verifying this change
   unit test
   org.apache.pulsar.websocket.proxy.ProxyPublishConsumeTest#unsubscribeTest
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [pulsar] 315157973 commented on pull request #8068: WebSocket API: support unsubscribing from a topic

Posted by GitBox <gi...@apache.org>.
315157973 commented on pull request #8068:
URL: https://github.com/apache/pulsar/pull/8068#issuecomment-693155482


   /pulsarbot run-failure-checks


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [pulsar] codelipenghui merged pull request #8068: [Issue 5005] WebSocket API: support unsubscribing from a topic

Posted by GitBox <gi...@apache.org>.
codelipenghui merged pull request #8068:
URL: https://github.com/apache/pulsar/pull/8068


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [pulsar] 315157973 commented on pull request #8068: [Issue 5005] WebSocket API: support unsubscribing from a topic

Posted by GitBox <gi...@apache.org>.
315157973 commented on pull request #8068:
URL: https://github.com/apache/pulsar/pull/8068#issuecomment-693963006


   /pulsarbot run-failure-checks
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [pulsar] codelipenghui merged pull request #8068: [Issue 5005] WebSocket API: support unsubscribing from a topic

Posted by GitBox <gi...@apache.org>.
codelipenghui merged pull request #8068:
URL: https://github.com/apache/pulsar/pull/8068


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [pulsar] Jennifer88huang commented on pull request #8068: WebSocket API: support unsubscribing from a topic

Posted by GitBox <gi...@apache.org>.
Jennifer88huang commented on pull request #8068:
URL: https://github.com/apache/pulsar/pull/8068#issuecomment-693207028


   /pulsarbot run-failure-checks


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [pulsar] 315157973 commented on pull request #8068: [Issue 5005] WebSocket API: support unsubscribing from a topic

Posted by GitBox <gi...@apache.org>.
315157973 commented on pull request #8068:
URL: https://github.com/apache/pulsar/pull/8068#issuecomment-693796255


   /pulsarbot run-failure-checks
   
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [pulsar] 315157973 commented on pull request #8068: WebSocket API: support unsubscribing from a topic

Posted by GitBox <gi...@apache.org>.
315157973 commented on pull request #8068:
URL: https://github.com/apache/pulsar/pull/8068#issuecomment-693133127


   /pulsarbot run-failure-checks


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [pulsar] 315157973 commented on pull request #8068: [Issue 5005] WebSocket API: support unsubscribing from a topic

Posted by GitBox <gi...@apache.org>.
315157973 commented on pull request #8068:
URL: https://github.com/apache/pulsar/pull/8068#issuecomment-694040708


   /pulsarbot run-failure-checks


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [pulsar] 315157973 commented on pull request #8068: [Issue 5005] WebSocket API: support unsubscribing from a topic

Posted by GitBox <gi...@apache.org>.
315157973 commented on pull request #8068:
URL: https://github.com/apache/pulsar/pull/8068#issuecomment-693834867


   /pulsarbot run-failure-checks


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [pulsar] 315157973 commented on pull request #8068: WebSocket API: support unsubscribing from a topic

Posted by GitBox <gi...@apache.org>.
315157973 commented on pull request #8068:
URL: https://github.com/apache/pulsar/pull/8068#issuecomment-693195798


   /pulsarbot run-failure-checks


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org