Re: Patch for FOP: FONode.java

[Arved Sandstrom <Ar...@chebucto.ns.ca>]

On Wednesday 28 March 2001 23:34, Jeff Linwood wrote:
> Hi,
>
> I ran into a problem processing my FO file with the column layout, where it
> was throwing an ArrayOutOfBoundsException in rollback() at
> elementAt(this.marker).
>
> this.marker wasn't being checked after the resetMarker() was called, so I
> added a check to return out of the code if the maker was invalid, so
> elementAt didn't get an invalid value.
>
> Unfortunately, I have no idea how this relates to what this code actually
> does - I don't understand the purpose of this code, so it's quite likely
> I'm breaking something else here.  My XSL-FO stuff now gives the expected
> output though.
>
> Thanks,
> -jeff

Hi, Jeff

I'll evaluate your patch. It looks like you ran into a condition that my 
testing never reproduced, and the odds are that your fix doesn't break 
anything else.

Can you maybe supply a small FO file that reproduces this breakage if your 
patch is _not_ applied. I will add this as a test case. Thanks.

Regards,
Arved Sandstrom

---------------------------------------------------------------------
To unsubscribe, e-mail: fop-dev-unsubscribe@xml.apache.org
For additional commands, email: fop-dev-help@xml.apache.org

RE: Patch for FOP: FONode.java

[Jeff Linwood <jl...@Mediaprise.com>]

Here is a .fo file that replicates the broken behavior under the unpatched
build.

For those of you listening in, this bug is related to columns and spanning.

<?xml version="1.0" encoding="UTF-8"?>
<?cocoon-format
      type="text/xslfo"
    ?>
<fo:root xmlns:fo="http://www.w3.org/1999/XSL/Format">
<fo:layout-master-set>
<fo:simple-page-master margin-right="50pt"
margin-left="50pt" margin-bottom="25pt"
margin-top="75pt" page-width="8.5in"
page-height="11in" master-name="main">
<fo:region-body column-gap="1in" column-count="2"
margin-bottom="50pt"/><fo:region-after extent="25pt"/>
</fo:simple-page-master>
</fo:layout-master-set>
<fo:page-sequence master-name="main">
<fo:flow flow-name="xsl-region-body">
<fo:block span="all">
</fo:block>
<fo:block space-before.optimum="24pt" span="all"
text-align-last="start" line-height="27pt" font-size="24pt">
stuff</fo:block>
<fo:block space-after.optimum="6pt"
space-before.optimum="18pt" span="all"
text-align-last="start" line-height="18pt"
font-family="serif" font-size="16pt">lots of text goes here.</fo:block>
<fo:block space-after.optimum="18pt" span="all">

<fo:leader leader-length="6in" leader-pattern="rule"/>
</fo:block>
<fo:block span="none"></fo:block>
<fo:block span="none">
<fo:table break-after="page" space-after.optimum="18pt"
space-before.optimum="6pt"><fo:table-column
column-width="70pt"/>
<fo:table-column column-width="70pt"/>
<fo:table-column column-width="60pt"/>
<fo:table-body>
<fo:table-row space-before.optimum="10pt">
<fo:table-cell>
<fo:block font-family="serif" font-weight="bold"
font-size="10pt">ggg1</fo:block>
</fo:table-cell>
<fo:table-cell>
<fo:block font-family="serif" font-weight="bold"
font-size="8pt">
ggggg</fo:block></fo:table-cell>
<fo:table-cell>
<fo:block font-family="serif" text-align="end" font-size="8pt">No
</fo:block>
</fo:table-cell>
</fo:table-row>
</fo:table-body>
</fo:table>
</fo:block>
<fo:block span="all">
</fo:block>
<fo:block space-before.optimum="24pt" span="all"
text-align-last="start" line-height="27pt"
font-size="24pt">stuff
</fo:block>
<fo:block space-after.optimum="6pt" space-before.optimum="18pt"
span="all" text-align-last="start" line-height="18pt"
font-family="serif" font-size="16pt">lots of text goes here</fo:block>
<fo:block space-after.optimum="18pt" span="all">
<fo:leader leader-length="6in" leader-pattern="rule"/>
</fo:block>
<fo:block span="none">
</fo:block>
<fo:block span="none">
<fo:table break-after="page" space-after.optimum="18pt"
space-before.optimum="6pt">
<fo:table-column column-width="70pt"/>
<fo:table-column column-width="70pt"/>
<fo:table-column column-width="60pt"/>
<fo:table-body>
<fo:table-row space-before.optimum="10pt">
<fo:table-cell><fo:block font-family="serif" font-weight="bold"
font-size="10pt">fff</fo:block></fo:table-cell>
<fo:table-cell><fo:block font-family="serif" font-weight="bold"
font-size="8pt">fff</fo:block></fo:table-cell>
<fo:table-cell><fo:block font-family="serif" text-align="end"
font-size="8pt">kkkk</fo:block></fo:table-cell>
</fo:table-row>
</fo:table-body>
</fo:table></fo:block><fo:block span="all">
</fo:block></fo:flow></fo:page-sequence></fo:root

-----Original Message-----
From: Arved Sandstrom [mailto:Arved_37@chebucto.ns.ca]
Sent: Wednesday, March 28, 2001 4:22 PM
To: fop-dev@xml.apache.org
Subject: Re: Patch for FOP: FONode.java


On Wednesday 28 March 2001 23:34, Jeff Linwood wrote:
> Hi,
>
> I ran into a problem processing my FO file with the column layout, where
it
> was throwing an ArrayOutOfBoundsException in rollback() at
> elementAt(this.marker).
>
> this.marker wasn't being checked after the resetMarker() was called, so I
> added a check to return out of the code if the maker was invalid, so
> elementAt didn't get an invalid value.
>
> Unfortunately, I have no idea how this relates to what this code actually
> does - I don't understand the purpose of this code, so it's quite likely
> I'm breaking something else here.  My XSL-FO stuff now gives the expected
> output though.
>
> Thanks,
> -jeff

Hi, Jeff

I'll evaluate your patch. It looks like you ran into a condition that my
testing never reproduced, and the odds are that your fix doesn't break
anything else.

Can you maybe supply a small FO file that reproduces this breakage if your
patch is _not_ applied. I will add this as a test case. Thanks.

Regards,
Arved Sandstrom

---------------------------------------------------------------------
To unsubscribe, e-mail: fop-dev-unsubscribe@xml.apache.org
For additional commands, email: fop-dev-help@xml.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: fop-dev-unsubscribe@xml.apache.org
For additional commands, email: fop-dev-help@xml.apache.org