[jira] Issue Comment Edited: (DERBY-3037) Language ResultSet.finish() is called even when the ResultSet is going to be re-used.

["Mamta A. Satoor (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/DERBY-3037?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12548302 ] 

mamtas edited comment on DERBY-3037 at 12/4/07 9:13 AM:
-----------------------------------------------------------------

I made a simple one line change in EmbedResultSet.close() so that it calls language ResultSet.close rather than finish and of course, it is causing test failures. I will investigate the failures but just wanted to share the simple code change that I made in EmbedResultSet.close()

$ svn diff
Index: java/engine/org/apache/derby/impl/jdbc/EmbedResultSet.java
===================================================================
--- java/engine/org/apache/derby/impl/jdbc/EmbedResultSet.java  (revision 599587)
+++ java/engine/org/apache/derby/impl/jdbc/EmbedResultSet.java  (working copy)
@@ -567,7 +567,8 @@

                        try     {
                                try     {
-                                       theResults.finish(); // release the result set, don't just close it
+//                                     theResults.finish(); // release the result set, don't just close it
+                                       theResults.close();

                                    if (this.singleUseActivation != null)
                                    {

      was (Author: mamtas):
    I made a simple one line change in EmbedResultSet so that it calls language ResultSet.close rather than finish and of course, it is causing test failures. I will investigate the failures but just wanted to share the simple code change that I made in EmbedResultSet

$ svn diff
Index: java/engine/org/apache/derby/impl/jdbc/EmbedResultSet.java
===================================================================
--- java/engine/org/apache/derby/impl/jdbc/EmbedResultSet.java  (revision 599587)
+++ java/engine/org/apache/derby/impl/jdbc/EmbedResultSet.java  (working copy)
@@ -567,7 +567,8 @@

                        try     {
                                try     {
-                                       theResults.finish(); // release the result set, don't just close it
+//                                     theResults.finish(); // release the result set, don't just close it
+                                       theResults.close();

                                    if (this.singleUseActivation != null)
                                    {
  
> Language ResultSet.finish() is called even when the ResultSet is going to be re-used.
> -------------------------------------------------------------------------------------
>
>                 Key: DERBY-3037
>                 URL: https://issues.apache.org/jira/browse/DERBY-3037
>             Project: Derby
>          Issue Type: Bug
>          Components: SQL
>    Affects Versions: 10.4.0.0
>            Reporter: Daniel John Debrunner
>
> DERBY-827 (correctly) changed the lifetime of the language ResultSet tree to be the lifetime of the activation, but did not fix up the correct calls to ResultSet.close() and ResultSet.finish().
> A language ResultSet's lifetime should be driven by the activation, so activation.close() should call finish() on its ResultSet.
> EmbedResultSet should call close on its language ResultSet (theResults field) when the JDBC ResultSet is closed, it should not be calling finish() on its ResultSet.
> See comments in DERBY-827 for some more details and issues.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.