You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@helix.apache.org by GitBox <gi...@apache.org> on 2020/09/08 20:30:37 UTC
[GitHub] [helix] alirezazamani opened a new pull request #1351: Change error message to reset partitons
alirezazamani opened a new pull request #1351:
URL: https://github.com/apache/helix/pull/1351
### Issues
- [X] My PR addresses the following Helix issues and references them in the PR description:
Fixes #1350
### Description
- [x] Here are some details about my PR, including screenshots of any UI changes:
In this PR, if partition is not in ERROR state, Helix prints appropriate error message.
### Tests
- [x] The following is the result of the "mvn test" command on the appropriate module:
```
[INFO] Results:
[INFO]
[ERROR] Failures:
[ERROR] TestPartitionLevelTransitionConstraint.test:177 expected:<7> but was:<5>
[ERROR] TestRecurringJobQueue.stopDeleteJobAndResumeRecurrentQueue:123 ยป Helix Failed ...
[INFO]
[ERROR] Tests run: 1200, Failures: 2, Errors: 0, Skipped: 0
[INFO]
[INFO] ------------------------------------------------------------------------
[INFO] BUILD FAILURE
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 01:11 h
[INFO] Finished at: 2020-09-08T11:46:11-07:00
[INFO] ------------------------------------------------------------------------
```
The failed test passed when run individually.
mvn test -Dtest="TestPartitionLevelTransitionConstraint,TestRecurringJobQueue"
```
[INFO] Tests run: 7, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 106.971 s - in TestSuite
[INFO]
[INFO] Results:
[INFO]
[INFO] Tests run: 7, Failures: 0, Errors: 0, Skipped: 0
[INFO]
[INFO] ------------------------------------------------------------------------
[INFO] BUILD SUCCESS
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 01:53 min
[INFO] Finished at: 2020-09-08T13:24:05-07:00
[INFO] ------------------------------------------------------------------------
```
### Commits
- My commits all reference appropriate Apache Helix GitHub issues in their subject lines. In addition, my commits follow the guidelines from "[How to write a good git commit message](http://chris.beams.io/posts/git-commit/)":
1. Subject is separated from body by a blank line
1. Subject is limited to 50 characters (not including Jira issue reference)
1. Subject does not end with a period
1. Subject uses the imperative mood ("add", not "adding")
1. Body wraps at 72 characters
1. Body explains "what" and "why", not "how"
### Code Quality
- My diff has been formatted using helix-style.xml
(helix-style-intellij.xml if IntelliJ IDE is used)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For additional commands, e-mail: reviews-help@helix.apache.org
[GitHub] [helix] kaisun2000 commented on pull request #1351: Change error message to reset partitons
Posted by GitBox <gi...@apache.org>.
kaisun2000 commented on pull request #1351:
URL: https://github.com/apache/helix/pull/1351#issuecomment-689898062
Do we know why this task test fails? TestRecurringJobQueue.stopDeleteJobAndResumeRecurrentQueue
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For additional commands, e-mail: reviews-help@helix.apache.org
[GitHub] [helix] alirezazamani commented on pull request #1351: Change error message for reseting the partitions not in ERROR state
Posted by GitBox <gi...@apache.org>.
alirezazamani commented on pull request #1351:
URL: https://github.com/apache/helix/pull/1351#issuecomment-689915528
> Do we know why this task test fails? TestRecurringJobQueue.stopDeleteJobAndResumeRecurrentQueue
No, I don't know. It can be investigated. I think this test might be unstable.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For additional commands, e-mail: reviews-help@helix.apache.org
[GitHub] [helix] alirezazamani commented on pull request #1351: Change error message for reseting the partitions not in ERROR state
Posted by GitBox <gi...@apache.org>.
alirezazamani commented on pull request #1351:
URL: https://github.com/apache/helix/pull/1351#issuecomment-689914790
This PR is ready to be merged.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For additional commands, e-mail: reviews-help@helix.apache.org
[GitHub] [helix] alirezazamani merged pull request #1351: Change error message for reseting the partitions not in ERROR state
Posted by GitBox <gi...@apache.org>.
alirezazamani merged pull request #1351:
URL: https://github.com/apache/helix/pull/1351
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For additional commands, e-mail: reviews-help@helix.apache.org