You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2022/11/25 19:33:45 UTC
[GitHub] [arrow-rs] alamb opened a new pull request, #3196: Include integration tests in arrow crate
alamb opened a new pull request, #3196:
URL: https://github.com/apache/arrow-rs/pull/3196
# Which issue does this PR close?
re #3118
# Rationale for this change
When I published version 27, I got
```
error: failed to verify package tarball
Caused by:
failed to parse manifest at `/Users/alamb/Downloads/apache-arrow-rs-27.0.0/arrow/target/package/arrow-27.0.0/Cargo.toml`
Caused by:
can't find `ipc` test at `tests/ipc.rs` or `tests/ipc/main.rs`. Please specify test.path if you want to use a non-default path.
error: failed to verify package tarball
Caused by:
failed to parse manifest at `/Users/alamb/Downloads/apache-arrow-rs-27.0.0/arrow/target/package/arrow-27.0.0/Cargo.toml`
Caused by:
can't find `csv` test at `tests/csv.rs` or `tests/csv/main.rs`. Please specify test.path if you want to use a non-default path.
```
I had to delete some entries in the Cargo.toml fil.
# What changes are included in this PR?
Include tests directory in the list of files to publish as suggested by @tustvold at https://github.com/apache/arrow-rs/pull/3112#issuecomment-1314608674
# Testing
You can see the failure by checking out `27.0.0` and running `cargo publish --dry-run`:
```shell
(arrow_dev) alamb@MacBook-Pro-8:~/Software/arrow-rs/arrow$ cargo publish --dry-run
Updating crates.io index
Packaging arrow v27.0.0 (/Users/alamb/Software/arrow-rs/arrow)
Verifying arrow v27.0.0 (/Users/alamb/Software/arrow-rs/arrow)
error: failed to verify package tarball
Caused by:
failed to parse manifest at `/Users/alamb/Software/arrow-rs/target/package/arrow-27.0.0/Cargo.toml`
Caused by:
can't find `ipc` test at `tests/ipc.rs` or `tests/ipc/main.rs`. Please specify test.path if you want to use a non-default path.
```
With this patch:
```
# Are there any user-facing changes?
No
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-rs] tustvold merged pull request #3196: Include integration tests in arrow crate
Posted by GitBox <gi...@apache.org>.
tustvold merged PR #3196:
URL: https://github.com/apache/arrow-rs/pull/3196
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-rs] ursabot commented on pull request #3196: Include integration tests in arrow crate
Posted by GitBox <gi...@apache.org>.
ursabot commented on PR #3196:
URL: https://github.com/apache/arrow-rs/pull/3196#issuecomment-1328007201
Benchmark runs are scheduled for baseline = ddaab1dbab2bf776348dd974a21965e6753bf4c2 and contender = fd08c31a2cd37342d261f67e999b2be2d5a4ba6b. fd08c31a2cd37342d261f67e999b2be2d5a4ba6b is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Skipped :warning: Benchmarking of arrow-rs-commits is not supported on ec2-t3-xlarge-us-east-2] [ec2-t3-xlarge-us-east-2](https://conbench.ursa.dev/compare/runs/a21561a8143945749b56c24edf1f9949...d1c5613fb6ee4e6ca21f803849010677/)
[Skipped :warning: Benchmarking of arrow-rs-commits is not supported on test-mac-arm] [test-mac-arm](https://conbench.ursa.dev/compare/runs/68755e53c1014355aa85789c73a7c3b4...3c6a5691ecb6419788821c75a7d1f557/)
[Skipped :warning: Benchmarking of arrow-rs-commits is not supported on ursa-i9-9960x] [ursa-i9-9960x](https://conbench.ursa.dev/compare/runs/baa5367f19f0449d8b52faf86158c226...9567e98644a34310bd33ec4ab7c285a7/)
[Skipped :warning: Benchmarking of arrow-rs-commits is not supported on ursa-thinkcentre-m75q] [ursa-thinkcentre-m75q](https://conbench.ursa.dev/compare/runs/ecc0d6c4ddd045bcbf629961760f9162...83be2c572af54f8ab51ce52be8b60324/)
Buildkite builds:
Supported benchmarks:
ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python, R. Runs only benchmarks with cloud = True
test-mac-arm: Supported benchmark langs: C++, Python, R
ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org