You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@whimsical.apache.org by cl...@apache.org on 2016/08/21 23:31:56 UTC
[whimsy] branch incomplete-unsigned updated: Change names for
incomplete and unsigned
This is an automated email from the ASF dual-hosted git repository.
clr pushed a commit to branch incomplete-unsigned
in repository https://git-dual.apache.org/repos/asf/whimsy.git
The following commit(s) were added to refs/heads/incomplete-unsigned by this push:
new d186820 Change names for incomplete and unsigned
d186820 is described below
commit d186820f9d2e61ae81bd406b2fae8feca17c4d69
Author: Craig L Russell <cr...@oracle.com>
AuthorDate: Sun Aug 21 16:31:33 2016 -0700
Change names for incomplete and unsigned
---
www/secretary/workbench/file.cgi | 5 ++---
www/secretary/workbench/worklist.cgi | 24 ++++++++++++------------
2 files changed, 14 insertions(+), 15 deletions(-)
diff --git a/www/secretary/workbench/file.cgi b/www/secretary/workbench/file.cgi
index cf70e1f..d27e8d6 100755
--- a/www/secretary/workbench/file.cgi
+++ b/www/secretary/workbench/file.cgi
@@ -611,11 +611,10 @@ _html do
update_pending params, dest
when 'incomplete'
- _.system "whoami"
@realname ||= @iname
dest = "incomplete"
- _h1 "Incomplete from #{@iname}"
+ _h1 "Incomplete document received from #{@iname}"
_.move @source, dest
update_pending params, dest
@@ -624,7 +623,7 @@ _html do
@realname ||= @nname
dest = "unsigned"
- _h1 "Unsigned from #{@uname}"
+ _h1 "Unsigned document received from #{@uname}"
_.move @source, dest
update_pending params, dest
diff --git a/www/secretary/workbench/worklist.cgi b/www/secretary/workbench/worklist.cgi
index 7e01e81..f911239 100755
--- a/www/secretary/workbench/worklist.cgi
+++ b/www/secretary/workbench/worklist.cgi
@@ -76,9 +76,9 @@ _html do
elsif pending['doctype'] == 'nda'
message = "NDA for #{pending['realname']}"
elsif pending['doctype'] == 'incomplete'
- message = "Incomplete for #{pending['nname']}"
+ message = "Incomplete document received from #{pending['iname']}"
elsif pending['doctype'] == 'unsigned'
- message = "Unsigned for #{pending['nname']}"
+ message = "Unsigned document received from #{pending['uname']}"
end
end
end
@@ -215,17 +215,17 @@ _html do
_table do
_tr do
_td do
- _label 'Name', for: 'nname'
+ _label 'Name', for: 'iname'
end
_td do
- _input type: :text, name: 'nname', id: 'nname'
+ _input type: :text, name: 'iname', id: 'iname'
end
end
_tr do
_td.label 'EMail'
_td.input do
- _input name: 'nemail', id: 'nemail', type: 'email'
+ _input name: 'iemail', id: 'iemail', type: 'email'
end
end
end
@@ -235,17 +235,17 @@ _html do
_table do
_tr do
_td do
- _label 'Name', for: 'nname'
+ _label 'Name', for: 'uname'
end
_td do
- _input type: :text, name: 'nname', id: 'nname'
+ _input type: :text, name: 'uname', id: 'uname'
end
end
_tr do
_td.label 'EMail'
_td.input do
- _input name: 'nemail', id: 'nemail', type: 'email'
+ _input name: 'uemail', id: 'uemail', type: 'email'
end
end
@@ -503,13 +503,13 @@ _html do
_tr do
_td.label 'PMC'
_td.input do
- _input name: 'cpmc', id: 'cpmc', type: 'text'
+ _input name: 'ipmc', id: 'ipmc', type: 'text'
end
end
_tr do
_td.label 'Podling'
_td.input do
- _input name: 'cpodling', id: 'cpodling', type: 'text'
+ _input name: 'ipodling', id: 'ipodling', type: 'text'
end
end
end
@@ -517,13 +517,13 @@ _html do
_tr do
_td.label 'PMC'
_td.input do
- _input name: 'cpmc', id: 'cpmc', type: 'text'
+ _input name: 'upmc', id: 'upmc', type: 'text'
end
end
_tr do
_td.label 'Podling'
_td.input do
- _input name: 'cpodling', id: 'cpodling', type: 'text'
+ _input name: 'upodling', id: 'upodling', type: 'text'
end
end
end
--
To stop receiving notification emails like this one, please contact
['"commits@whimsical.apache.org" <co...@whimsical.apache.org>'].
Re: Work still to do on incomplete and unsigned
Posted by Craig Russell <cr...@oracle.com>.
I’ll try to find the logs and see what happened in my local environment.
Thanks,
Craig
> On Aug 22, 2016, at 6:51 PM, Sam Ruby <ru...@intertwingly.net> wrote:
>
> On Mon, Aug 22, 2016 at 9:42 PM, Craig Russell <cr...@oracle.com> wrote:
>> I sent the pending.yml file to the secretary and it’s sitting in the received area. • Craig-Russell-craig.russell-oracle.com—pending.yml
>>
>> I thought you could copy that to received/pending.yml in your local debug environment and commit, thereby sending email. I didn’t find a [RESULT][VOTE] but the pmc is ambari.
>
> Got it. Done.
>
>> Thanks,
>>
>> Craig
>
> - Sam Ruby
>
>>> On Aug 22, 2016, at 6:27 PM, Sam Ruby <ru...@intertwingly.net> wrote:
>>>
>>> On Mon, Aug 22, 2016 at 9:18 PM, Craig Russell <cr...@oracle.com> wrote:
>>>> Hi Sam,
>>>>
>>>> 1. Could you do me a big favor? There is a file from me to secretary with the pending.yml that I can’t send from here until I debug the send-mail part. Could you please send it?
>>>
>>> I'm not clear what you are asking of me. That pending.yml is on your
>>> machine only - it isn't on either mine or whimsy-vm3. If you like,
>>> you can make it go away with a "rm" command.
>>>
>>>> 2. Do you see anything wrong with this which is my ~/.secmail file:
>>>
>>> Nothing wrong that I can spot.
>>>
>>> - Sam Ruby
>>>
>>>> require 'mail'
>>>>
>>>> Mail.defaults do
>>>> delivery_method :smtp,
>>>> address: "smtp.gmail.com",
>>>> port: 587,
>>>> domain: "apache.org",
>>>> authentication: "plain",
>>>> user_name: "papajdo@gmail.com",
>>>> password: “noydb",
>>>> enable_starttls_auto: true
>>>>
>>>>
>>>> if $USER == 'clr'
>>>>
>>>> @from = 'Craig L Russell <cl...@apache.org>'
>>>> @sig = %{
>>>> -- Craig L Russell
>>>> Secretary, Apache Software Foundation
>>>> }
>>>>
>>>> elsif $USER == 'jcarman'
>>>>
>>>> @from = 'James Carman <jc...@apache.org>'
>>>> @sig = %{
>>>> -- James Carman
>>>> Apache Software Foundation Secretarial Team
>>>> }
>>>>
>>>> elsif $USER == 'rubys'
>>>>
>>>> @from = 'Sam Ruby <ru...@apache.org>'
>>>> @sig = %{
>>>> -- Sam Ruby
>>>> Apache Software Foundation Secretarial Team
>>>> }
>>>>
>>>> elsif $USER == 'jim'
>>>>
>>>> @from = 'Jim Jagielski <ji...@apache.org>'
>>>> @sig = %{
>>>> -- Jim Jagielski
>>>> Apache Software Foundation Secretarial Team
>>>> }
>>>>
>>>> elsif $USER == 'mnour'
>>>>
>>>> @from = 'Mohammad Nour El-Din <mn...@apache.org>'
>>>> @sig = %{
>>>> -- Mohammad Nour El-Din
>>>> Apache Software Foundation Secretarial Team
>>>> }
>>>> end
>>>> end
>>>>
>>>>
>>>>>
>>>>>
>>>>>
>>>>
>>>> Craig L Russell
>>>> Architect
>>>> craig.russell@oracle.com
>>>> P.S. A good JDO? O, Gasp!
>>>>
>>>>
>>>>
>>>>
>>>>
>>
>> Craig L Russell
>> Architect
>> craig.russell@oracle.com
>> P.S. A good JDO? O, Gasp!
>>
>>
>>
>>
>>
Craig L Russell
Architect
craig.russell@oracle.com
P.S. A good JDO? O, Gasp!
Re: Work still to do on incomplete and unsigned
Posted by Sam Ruby <ru...@intertwingly.net>.
On Mon, Aug 22, 2016 at 9:42 PM, Craig Russell <cr...@oracle.com> wrote:
> I sent the pending.yml file to the secretary and it’s sitting in the received area. • Craig-Russell-craig.russell-oracle.com—pending.yml
>
> I thought you could copy that to received/pending.yml in your local debug environment and commit, thereby sending email. I didn’t find a [RESULT][VOTE] but the pmc is ambari.
Got it. Done.
> Thanks,
>
> Craig
- Sam Ruby
>> On Aug 22, 2016, at 6:27 PM, Sam Ruby <ru...@intertwingly.net> wrote:
>>
>> On Mon, Aug 22, 2016 at 9:18 PM, Craig Russell <cr...@oracle.com> wrote:
>>> Hi Sam,
>>>
>>> 1. Could you do me a big favor? There is a file from me to secretary with the pending.yml that I can’t send from here until I debug the send-mail part. Could you please send it?
>>
>> I'm not clear what you are asking of me. That pending.yml is on your
>> machine only - it isn't on either mine or whimsy-vm3. If you like,
>> you can make it go away with a "rm" command.
>>
>>> 2. Do you see anything wrong with this which is my ~/.secmail file:
>>
>> Nothing wrong that I can spot.
>>
>> - Sam Ruby
>>
>>> require 'mail'
>>>
>>> Mail.defaults do
>>> delivery_method :smtp,
>>> address: "smtp.gmail.com",
>>> port: 587,
>>> domain: "apache.org",
>>> authentication: "plain",
>>> user_name: "papajdo@gmail.com",
>>> password: “noydb",
>>> enable_starttls_auto: true
>>>
>>>
>>> if $USER == 'clr'
>>>
>>> @from = 'Craig L Russell <cl...@apache.org>'
>>> @sig = %{
>>> -- Craig L Russell
>>> Secretary, Apache Software Foundation
>>> }
>>>
>>> elsif $USER == 'jcarman'
>>>
>>> @from = 'James Carman <jc...@apache.org>'
>>> @sig = %{
>>> -- James Carman
>>> Apache Software Foundation Secretarial Team
>>> }
>>>
>>> elsif $USER == 'rubys'
>>>
>>> @from = 'Sam Ruby <ru...@apache.org>'
>>> @sig = %{
>>> -- Sam Ruby
>>> Apache Software Foundation Secretarial Team
>>> }
>>>
>>> elsif $USER == 'jim'
>>>
>>> @from = 'Jim Jagielski <ji...@apache.org>'
>>> @sig = %{
>>> -- Jim Jagielski
>>> Apache Software Foundation Secretarial Team
>>> }
>>>
>>> elsif $USER == 'mnour'
>>>
>>> @from = 'Mohammad Nour El-Din <mn...@apache.org>'
>>> @sig = %{
>>> -- Mohammad Nour El-Din
>>> Apache Software Foundation Secretarial Team
>>> }
>>> end
>>> end
>>>
>>>
>>>>
>>>>
>>>>
>>>
>>> Craig L Russell
>>> Architect
>>> craig.russell@oracle.com
>>> P.S. A good JDO? O, Gasp!
>>>
>>>
>>>
>>>
>>>
>
> Craig L Russell
> Architect
> craig.russell@oracle.com
> P.S. A good JDO? O, Gasp!
>
>
>
>
>
Re: Work still to do on incomplete and unsigned
Posted by Craig Russell <cr...@oracle.com>.
I sent the pending.yml file to the secretary and it’s sitting in the received area. • Craig-Russell-craig.russell-oracle.com—pending.yml
I thought you could copy that to received/pending.yml in your local debug environment and commit, thereby sending email. I didn’t find a [RESULT][VOTE] but the pmc is ambari.
Thanks,
Craig
> On Aug 22, 2016, at 6:27 PM, Sam Ruby <ru...@intertwingly.net> wrote:
>
> On Mon, Aug 22, 2016 at 9:18 PM, Craig Russell <cr...@oracle.com> wrote:
>> Hi Sam,
>>
>> 1. Could you do me a big favor? There is a file from me to secretary with the pending.yml that I can’t send from here until I debug the send-mail part. Could you please send it?
>
> I'm not clear what you are asking of me. That pending.yml is on your
> machine only - it isn't on either mine or whimsy-vm3. If you like,
> you can make it go away with a "rm" command.
>
>> 2. Do you see anything wrong with this which is my ~/.secmail file:
>
> Nothing wrong that I can spot.
>
> - Sam Ruby
>
>> require 'mail'
>>
>> Mail.defaults do
>> delivery_method :smtp,
>> address: "smtp.gmail.com",
>> port: 587,
>> domain: "apache.org",
>> authentication: "plain",
>> user_name: "papajdo@gmail.com",
>> password: “noydb",
>> enable_starttls_auto: true
>>
>>
>> if $USER == 'clr'
>>
>> @from = 'Craig L Russell <cl...@apache.org>'
>> @sig = %{
>> -- Craig L Russell
>> Secretary, Apache Software Foundation
>> }
>>
>> elsif $USER == 'jcarman'
>>
>> @from = 'James Carman <jc...@apache.org>'
>> @sig = %{
>> -- James Carman
>> Apache Software Foundation Secretarial Team
>> }
>>
>> elsif $USER == 'rubys'
>>
>> @from = 'Sam Ruby <ru...@apache.org>'
>> @sig = %{
>> -- Sam Ruby
>> Apache Software Foundation Secretarial Team
>> }
>>
>> elsif $USER == 'jim'
>>
>> @from = 'Jim Jagielski <ji...@apache.org>'
>> @sig = %{
>> -- Jim Jagielski
>> Apache Software Foundation Secretarial Team
>> }
>>
>> elsif $USER == 'mnour'
>>
>> @from = 'Mohammad Nour El-Din <mn...@apache.org>'
>> @sig = %{
>> -- Mohammad Nour El-Din
>> Apache Software Foundation Secretarial Team
>> }
>> end
>> end
>>
>>
>>>
>>>
>>>
>>
>> Craig L Russell
>> Architect
>> craig.russell@oracle.com
>> P.S. A good JDO? O, Gasp!
>>
>>
>>
>>
>>
Craig L Russell
Architect
craig.russell@oracle.com
P.S. A good JDO? O, Gasp!
Re: Work still to do on incomplete and unsigned
Posted by Sam Ruby <ru...@intertwingly.net>.
On Mon, Aug 22, 2016 at 9:18 PM, Craig Russell <cr...@oracle.com> wrote:
> Hi Sam,
>
> 1. Could you do me a big favor? There is a file from me to secretary with the pending.yml that I can’t send from here until I debug the send-mail part. Could you please send it?
I'm not clear what you are asking of me. That pending.yml is on your
machine only - it isn't on either mine or whimsy-vm3. If you like,
you can make it go away with a "rm" command.
> 2. Do you see anything wrong with this which is my ~/.secmail file:
Nothing wrong that I can spot.
- Sam Ruby
> require 'mail'
>
> Mail.defaults do
> delivery_method :smtp,
> address: "smtp.gmail.com",
> port: 587,
> domain: "apache.org",
> authentication: "plain",
> user_name: "papajdo@gmail.com",
> password: “noydb",
> enable_starttls_auto: true
>
>
> if $USER == 'clr'
>
> @from = 'Craig L Russell <cl...@apache.org>'
> @sig = %{
> -- Craig L Russell
> Secretary, Apache Software Foundation
> }
>
> elsif $USER == 'jcarman'
>
> @from = 'James Carman <jc...@apache.org>'
> @sig = %{
> -- James Carman
> Apache Software Foundation Secretarial Team
> }
>
> elsif $USER == 'rubys'
>
> @from = 'Sam Ruby <ru...@apache.org>'
> @sig = %{
> -- Sam Ruby
> Apache Software Foundation Secretarial Team
> }
>
> elsif $USER == 'jim'
>
> @from = 'Jim Jagielski <ji...@apache.org>'
> @sig = %{
> -- Jim Jagielski
> Apache Software Foundation Secretarial Team
> }
>
> elsif $USER == 'mnour'
>
> @from = 'Mohammad Nour El-Din <mn...@apache.org>'
> @sig = %{
> -- Mohammad Nour El-Din
> Apache Software Foundation Secretarial Team
> }
> end
> end
>
>
>>
>>
>>
>
> Craig L Russell
> Architect
> craig.russell@oracle.com
> P.S. A good JDO? O, Gasp!
>
>
>
>
>
Re: Work still to do on incomplete and unsigned
Posted by Craig Russell <cr...@oracle.com>.
Hi Sam,
1. Could you do me a big favor? There is a file from me to secretary with the pending.yml that I can’t send from here until I debug the send-mail part. Could you please send it?
2. Do you see anything wrong with this which is my ~/.secmail file:
require 'mail'
Mail.defaults do
delivery_method :smtp,
address: "smtp.gmail.com",
port: 587,
domain: "apache.org",
authentication: "plain",
user_name: "papajdo@gmail.com",
password: “noydb",
enable_starttls_auto: true
if $USER == 'clr'
@from = 'Craig L Russell <cl...@apache.org>'
@sig = %{
-- Craig L Russell
Secretary, Apache Software Foundation
}
elsif $USER == 'jcarman'
@from = 'James Carman <jc...@apache.org>'
@sig = %{
-- James Carman
Apache Software Foundation Secretarial Team
}
elsif $USER == 'rubys'
@from = 'Sam Ruby <ru...@apache.org>'
@sig = %{
-- Sam Ruby
Apache Software Foundation Secretarial Team
}
elsif $USER == 'jim'
@from = 'Jim Jagielski <ji...@apache.org>'
@sig = %{
-- Jim Jagielski
Apache Software Foundation Secretarial Team
}
elsif $USER == 'mnour'
@from = 'Mohammad Nour El-Din <mn...@apache.org>'
@sig = %{
-- Mohammad Nour El-Din
Apache Software Foundation Secretarial Team
}
end
end
>
>
>
Craig L Russell
Architect
craig.russell@oracle.com
P.S. A good JDO? O, Gasp!
Re: Work still to do on incomplete and unsigned
Posted by Sam Ruby <ru...@intertwingly.net>.
On Tue, Aug 23, 2016 at 11:20 AM, Craig Russell
<cr...@oracle.com> wrote:
> Hi Sam,
>
> When I file via icla, pending.yml has fields for all of the file types. Is this expected? This is master branch.
Short answer: yes.
Longer answer: worklist.js will set all of them:
https://github.com/apache/whimsy/blob/master/www/secretary/workbench/worklist.js#L113
There is a single form that has all of these fields, where much if not
all of that form is hidden from view depending on what document type
you select.
When you submit the form, all of the fields are sent to the server.
All of the fields are available to all of the code, but the assumption
is that the code that processes (for example) ICLAs only looks at the
values that would have been shown on the client.
Processing an ICLA is done in a number of steps, pending.yml keeps
track of the information provided with the original request.
The secmail rewrite cleans this up... to start with there isn't a
single form that needs to handle all of the possible requests, instead
there is a separate form for each document type. Similarly, there
isn't a single "file.cgi" that handles all forms, but rather a
separate scripts per type of request.
We can discuss the schedule for trying to migrate to the new tool; or
even if it is worth doing. Ultimately as the primary customer for
this specific tool that's entirely up to you.
Meanwhile, my attention over the next few days is going to return to
documenting how to get more whimsy tools up and running on the Mac.
At the moment, you not only have a single tool up and running, you
have it running under Apache httpd in the context of a site that has
most of the necessary stuff already configured. Mostly what is left
is installing more gems and pointing to svn checkouts that you
probably already have.
I would expect that, for example, getting the new acreq tool up and
running locally would be of interest to you as
http://whimsy.local/secretary/workbench is rather incomplete without
it.
- Sam Ruby
> cat pending.yml
> ---
> - doctype: icla
> source: Craig-Russell-papajdo-gmail.com--Incomplete.pdf
> realname: Craig l Russell
> pubname: Craig l Russell
> email: papajdo@gmail.com
> filename: craig-l-russell.pdf
> nname: Craig Russell
> nemail: papajdo@gmail.com
> memail: papajdo@gmail.com
> gname: Craig Russell
> gemail: papajdo@gmail.com
> contact: Craig Russell
> cemail: papajdo@gmail.com
> pmc: whimsy
> podling: none
> email:addr: papajdo@gmail.com
> email:cc: Sam Ruby <ru...@intertwingly.net>
> email:id: "<D9...@gmail.com>"
> email:name: Craig Russell
> email:subject: 'Re: A better test file'
> svn:mime-type: application/pdf
>
>> On Aug 23, 2016, at 7:14 AM, Craig Russell <cr...@oracle.com> wrote:
>>
>> _ERROR #<Net::SMTPAuthenticationError: 534-5.7.14 <https://accounts.google.com/signin/continue?sarp=1&scc=1&plt=AKgnsbsw: /Users/clr/apache/git/whimsy/www/secretary/workbench/file.cgi, referer: http://whimsy.local/secretary/workbench/file.cgi
>>
>> ---
>> :svn:
>> - /Users/clr/apache/foundation
>> - /Users/clr/apache/documents
>> - /Users/clr/apache/committers
>>
>> :sendmail:
>> delivery_method: smtp
>> address: smtp.gmail.com
>> port: 587
>> domain: apache.org
>> user_name: 'papajdo@gmail.com'
>> password: ’noyb'
>> authentication: plain
>> enable_starttls_auto: true
>>
>>
>>> On Aug 23, 2016, at 4:36 AM, Sam Ruby <ru...@intertwingly.net> wrote:
>>>
>>> On Mon, Aug 22, 2016 at 11:20 PM, Craig Russell
>>> <cr...@oracle.com> wrote:
>>>> I don’t understand why it’s trying localhost 25 when I specifically asked for smtp.gmail.com 587.
>>>
>>> Sorry about that. I know what is going on.
>>>
>>> Create a ~/.whimsy file and put in it:
>>>
>>> :sendmail:
>>> delivery_method: smtp
>>> address: smtp.gmail.com
>>> port: 587
>>> domain: apache.org
>>> user_name: username
>>> password: password
>>> authentication: plain
>>> enable_starttls_auto: true
>>>
>>> Background: secretary/workbench is the oldest whimsy tool and has its
>>> own configuration (~/.secassist, ~/.secmail). Over time, I saw a lot
>>> of commonality in configuration and made that common (~/.whimsy) but
>>> didn't update secretary/workbench. Then when mail wasn't working on
>>> whimsy-vm3, I made a fix to the common code and instead of making a
>>> separate fix to the workbench, I updated it to use the common mail
>>> configuration.
>>>
>>> So: same information, different place, slightly different format; but
>>> on the brighter side this same information will be used by all of the
>>> whimsy tools that send email.
>>>
>>> - Sam Ruby
>>
>> Craig L Russell
>> Architect
>> craig.russell@oracle.com
>> P.S. A good JDO? O, Gasp!
>>
>>
>>
>>
>>
>
> Craig L Russell
> Architect
> craig.russell@oracle.com
> P.S. A good JDO? O, Gasp!
>
>
>
>
>
Re: Work still to do on incomplete and unsigned
Posted by Craig Russell <cr...@oracle.com>.
Hi Sam,
When I file via icla, pending.yml has fields for all of the file types. Is this expected? This is master branch.
cat pending.yml
---
- doctype: icla
source: Craig-Russell-papajdo-gmail.com--Incomplete.pdf
realname: Craig l Russell
pubname: Craig l Russell
email: papajdo@gmail.com
filename: craig-l-russell.pdf
nname: Craig Russell
nemail: papajdo@gmail.com
memail: papajdo@gmail.com
gname: Craig Russell
gemail: papajdo@gmail.com
contact: Craig Russell
cemail: papajdo@gmail.com
pmc: whimsy
podling: none
email:addr: papajdo@gmail.com
email:cc: Sam Ruby <ru...@intertwingly.net>
email:id: "<D9...@gmail.com>"
email:name: Craig Russell
email:subject: 'Re: A better test file'
svn:mime-type: application/pdf
> On Aug 23, 2016, at 7:14 AM, Craig Russell <cr...@oracle.com> wrote:
>
> _ERROR #<Net::SMTPAuthenticationError: 534-5.7.14 <https://accounts.google.com/signin/continue?sarp=1&scc=1&plt=AKgnsbsw: /Users/clr/apache/git/whimsy/www/secretary/workbench/file.cgi, referer: http://whimsy.local/secretary/workbench/file.cgi
>
> ---
> :svn:
> - /Users/clr/apache/foundation
> - /Users/clr/apache/documents
> - /Users/clr/apache/committers
>
> :sendmail:
> delivery_method: smtp
> address: smtp.gmail.com
> port: 587
> domain: apache.org
> user_name: 'papajdo@gmail.com'
> password: ’noyb'
> authentication: plain
> enable_starttls_auto: true
>
>
>> On Aug 23, 2016, at 4:36 AM, Sam Ruby <ru...@intertwingly.net> wrote:
>>
>> On Mon, Aug 22, 2016 at 11:20 PM, Craig Russell
>> <cr...@oracle.com> wrote:
>>> I don’t understand why it’s trying localhost 25 when I specifically asked for smtp.gmail.com 587.
>>
>> Sorry about that. I know what is going on.
>>
>> Create a ~/.whimsy file and put in it:
>>
>> :sendmail:
>> delivery_method: smtp
>> address: smtp.gmail.com
>> port: 587
>> domain: apache.org
>> user_name: username
>> password: password
>> authentication: plain
>> enable_starttls_auto: true
>>
>> Background: secretary/workbench is the oldest whimsy tool and has its
>> own configuration (~/.secassist, ~/.secmail). Over time, I saw a lot
>> of commonality in configuration and made that common (~/.whimsy) but
>> didn't update secretary/workbench. Then when mail wasn't working on
>> whimsy-vm3, I made a fix to the common code and instead of making a
>> separate fix to the workbench, I updated it to use the common mail
>> configuration.
>>
>> So: same information, different place, slightly different format; but
>> on the brighter side this same information will be used by all of the
>> whimsy tools that send email.
>>
>> - Sam Ruby
>
> Craig L Russell
> Architect
> craig.russell@oracle.com
> P.S. A good JDO? O, Gasp!
>
>
>
>
>
Craig L Russell
Architect
craig.russell@oracle.com
P.S. A good JDO? O, Gasp!
Re: Work still to do on incomplete and unsigned
Posted by Craig Russell <cr...@oracle.com>.
Mostly working as I like it.
Except I can’t find where the email stuff is filled for icla handling. When I do ‘incomplete’ I don’t get any of the email: fields in pending.
[MacBook-Pro:~/apache/documents/received] clr% cat pending.yml
---
- doctype: incomplete
source: Craig-Russell-papajdo-gmail.com--Incomplete.pdf
realname: Craig Russell
email: papajdo@gmail.com
nname: Craig Russell
nemail: papajdo@gmail.com
iname: Craig Russell
iemail: papajdo@gmail.com
uname: Craig Russell
uemail: papajdo@gmail.com
pname: Craig Russell
pemail: papajdo@gmail.com
memail: papajdo@gmail.com
gname: Craig Russell
gemail: papajdo@gmail.com
contact: Craig Russell
cemail: papajdo@gmail.com
ipodling: " "
[MacBook-Pro:~/apache/documents/received] clr% cat pending.yml
cat: pending.yml: No such file or directory
[MacBook-Pro:~/apache/documents/received] clr% cat pending.yml
---
- doctype: icla
source: Craig-Russell-papajdo-gmail.com--Incomplete.pdf
realname: Craig Russell
pubname: Craig Russell
email: papajdo@gmail.com
filename: craig-l-russell.pdf
nname: Craig Russell
nemail: papajdo@gmail.com
iname: Craig Russell
iemail: papajdo@gmail.com
uname: Craig Russell
uemail: papajdo@gmail.com
pname: Craig Russell
pemail: papajdo@gmail.com
memail: papajdo@gmail.com
gname: Craig Russell
gemail: papajdo@gmail.com
contact: Craig Russell
cemail: papajdo@gmail.com
ipodling: " "
email:addr: papajdo@gmail.com
email:cc: Sam Ruby <ru...@intertwingly.net>
email:id: "<D9...@gmail.com>"
email:name: Craig Russell
email:subject: 'Re: A better test file'
svn:mime-type: application/pdf
> On Aug 23, 2016, at 8:51 AM, Sam Ruby <ru...@intertwingly.net> wrote:
>
> On Tue, Aug 23, 2016 at 10:18 AM, Craig Russell
> <cr...@oracle.com> wrote:
>> Working now. Google second level security wanted me to approve “less secure application”.
>>
>> Seems to work now.
>>
>> W00t.
>
> Cool. I'd lick to rip out some dead code then. You might want to
> delete ~/.secmail ... it will fall back to secmail.rb, meaning that
> any changes to signatures and the like will get checked in and remain
> consistent
>
>> Craig
>
> - Sam Ruby
>
>>> On Aug 23, 2016, at 7:14 AM, Craig Russell <cr...@oracle.com> wrote:
>>>
>>> _ERROR #<Net::SMTPAuthenticationError: 534-5.7.14 <https://accounts.google.com/signin/continue?sarp=1&scc=1&plt=AKgnsbsw: /Users/clr/apache/git/whimsy/www/secretary/workbench/file.cgi, referer: http://whimsy.local/secretary/workbench/file.cgi
>>>
>>> ---
>>> :svn:
>>> - /Users/clr/apache/foundation
>>> - /Users/clr/apache/documents
>>> - /Users/clr/apache/committers
>>>
>>> :sendmail:
>>> delivery_method: smtp
>>> address: smtp.gmail.com
>>> port: 587
>>> domain: apache.org
>>> user_name: 'papajdo@gmail.com'
>>> password: ’noyb'
>>> authentication: plain
>>> enable_starttls_auto: true
>>>
>>>
>>>> On Aug 23, 2016, at 4:36 AM, Sam Ruby <ru...@intertwingly.net> wrote:
>>>>
>>>> On Mon, Aug 22, 2016 at 11:20 PM, Craig Russell
>>>> <cr...@oracle.com> wrote:
>>>>> I don’t understand why it’s trying localhost 25 when I specifically asked for smtp.gmail.com 587.
>>>>
>>>> Sorry about that. I know what is going on.
>>>>
>>>> Create a ~/.whimsy file and put in it:
>>>>
>>>> :sendmail:
>>>> delivery_method: smtp
>>>> address: smtp.gmail.com
>>>> port: 587
>>>> domain: apache.org
>>>> user_name: username
>>>> password: password
>>>> authentication: plain
>>>> enable_starttls_auto: true
>>>>
>>>> Background: secretary/workbench is the oldest whimsy tool and has its
>>>> own configuration (~/.secassist, ~/.secmail). Over time, I saw a lot
>>>> of commonality in configuration and made that common (~/.whimsy) but
>>>> didn't update secretary/workbench. Then when mail wasn't working on
>>>> whimsy-vm3, I made a fix to the common code and instead of making a
>>>> separate fix to the workbench, I updated it to use the common mail
>>>> configuration.
>>>>
>>>> So: same information, different place, slightly different format; but
>>>> on the brighter side this same information will be used by all of the
>>>> whimsy tools that send email.
>>>>
>>>> - Sam Ruby
>>>
>>> Craig L Russell
>>> Architect
>>> craig.russell@oracle.com
>>> P.S. A good JDO? O, Gasp!
>>>
>>>
>>>
>>>
>>>
>>
>> Craig L Russell
>> Architect
>> craig.russell@oracle.com
>> P.S. A good JDO? O, Gasp!
>>
>>
>>
>>
>>
Craig L Russell
Architect
craig.russell@oracle.com
P.S. A good JDO? O, Gasp!
Re: Work still to do on incomplete and unsigned
Posted by Sam Ruby <ru...@intertwingly.net>.
On Tue, Aug 23, 2016 at 10:18 AM, Craig Russell
<cr...@oracle.com> wrote:
> Working now. Google second level security wanted me to approve “less secure application”.
>
> Seems to work now.
>
> W00t.
Cool. I'd lick to rip out some dead code then. You might want to
delete ~/.secmail ... it will fall back to secmail.rb, meaning that
any changes to signatures and the like will get checked in and remain
consistent
> Craig
- Sam Ruby
>> On Aug 23, 2016, at 7:14 AM, Craig Russell <cr...@oracle.com> wrote:
>>
>> _ERROR #<Net::SMTPAuthenticationError: 534-5.7.14 <https://accounts.google.com/signin/continue?sarp=1&scc=1&plt=AKgnsbsw: /Users/clr/apache/git/whimsy/www/secretary/workbench/file.cgi, referer: http://whimsy.local/secretary/workbench/file.cgi
>>
>> ---
>> :svn:
>> - /Users/clr/apache/foundation
>> - /Users/clr/apache/documents
>> - /Users/clr/apache/committers
>>
>> :sendmail:
>> delivery_method: smtp
>> address: smtp.gmail.com
>> port: 587
>> domain: apache.org
>> user_name: 'papajdo@gmail.com'
>> password: ’noyb'
>> authentication: plain
>> enable_starttls_auto: true
>>
>>
>>> On Aug 23, 2016, at 4:36 AM, Sam Ruby <ru...@intertwingly.net> wrote:
>>>
>>> On Mon, Aug 22, 2016 at 11:20 PM, Craig Russell
>>> <cr...@oracle.com> wrote:
>>>> I don’t understand why it’s trying localhost 25 when I specifically asked for smtp.gmail.com 587.
>>>
>>> Sorry about that. I know what is going on.
>>>
>>> Create a ~/.whimsy file and put in it:
>>>
>>> :sendmail:
>>> delivery_method: smtp
>>> address: smtp.gmail.com
>>> port: 587
>>> domain: apache.org
>>> user_name: username
>>> password: password
>>> authentication: plain
>>> enable_starttls_auto: true
>>>
>>> Background: secretary/workbench is the oldest whimsy tool and has its
>>> own configuration (~/.secassist, ~/.secmail). Over time, I saw a lot
>>> of commonality in configuration and made that common (~/.whimsy) but
>>> didn't update secretary/workbench. Then when mail wasn't working on
>>> whimsy-vm3, I made a fix to the common code and instead of making a
>>> separate fix to the workbench, I updated it to use the common mail
>>> configuration.
>>>
>>> So: same information, different place, slightly different format; but
>>> on the brighter side this same information will be used by all of the
>>> whimsy tools that send email.
>>>
>>> - Sam Ruby
>>
>> Craig L Russell
>> Architect
>> craig.russell@oracle.com
>> P.S. A good JDO? O, Gasp!
>>
>>
>>
>>
>>
>
> Craig L Russell
> Architect
> craig.russell@oracle.com
> P.S. A good JDO? O, Gasp!
>
>
>
>
>
Re: Work still to do on incomplete and unsigned
Posted by Craig Russell <cr...@oracle.com>.
Working now. Google second level security wanted me to approve “less secure application”.
Seems to work now.
W00t.
Craig
> On Aug 23, 2016, at 7:14 AM, Craig Russell <cr...@oracle.com> wrote:
>
> _ERROR #<Net::SMTPAuthenticationError: 534-5.7.14 <https://accounts.google.com/signin/continue?sarp=1&scc=1&plt=AKgnsbsw: /Users/clr/apache/git/whimsy/www/secretary/workbench/file.cgi, referer: http://whimsy.local/secretary/workbench/file.cgi
>
> ---
> :svn:
> - /Users/clr/apache/foundation
> - /Users/clr/apache/documents
> - /Users/clr/apache/committers
>
> :sendmail:
> delivery_method: smtp
> address: smtp.gmail.com
> port: 587
> domain: apache.org
> user_name: 'papajdo@gmail.com'
> password: ’noyb'
> authentication: plain
> enable_starttls_auto: true
>
>
>> On Aug 23, 2016, at 4:36 AM, Sam Ruby <ru...@intertwingly.net> wrote:
>>
>> On Mon, Aug 22, 2016 at 11:20 PM, Craig Russell
>> <cr...@oracle.com> wrote:
>>> I don’t understand why it’s trying localhost 25 when I specifically asked for smtp.gmail.com 587.
>>
>> Sorry about that. I know what is going on.
>>
>> Create a ~/.whimsy file and put in it:
>>
>> :sendmail:
>> delivery_method: smtp
>> address: smtp.gmail.com
>> port: 587
>> domain: apache.org
>> user_name: username
>> password: password
>> authentication: plain
>> enable_starttls_auto: true
>>
>> Background: secretary/workbench is the oldest whimsy tool and has its
>> own configuration (~/.secassist, ~/.secmail). Over time, I saw a lot
>> of commonality in configuration and made that common (~/.whimsy) but
>> didn't update secretary/workbench. Then when mail wasn't working on
>> whimsy-vm3, I made a fix to the common code and instead of making a
>> separate fix to the workbench, I updated it to use the common mail
>> configuration.
>>
>> So: same information, different place, slightly different format; but
>> on the brighter side this same information will be used by all of the
>> whimsy tools that send email.
>>
>> - Sam Ruby
>
> Craig L Russell
> Architect
> craig.russell@oracle.com
> P.S. A good JDO? O, Gasp!
>
>
>
>
>
Craig L Russell
Architect
craig.russell@oracle.com
P.S. A good JDO? O, Gasp!
Re: Work still to do on incomplete and unsigned
Posted by Craig Russell <cr...@oracle.com>.
_ERROR #<Net::SMTPAuthenticationError: 534-5.7.14 <https://accounts.google.com/signin/continue?sarp=1&scc=1&plt=AKgnsbsw: /Users/clr/apache/git/whimsy/www/secretary/workbench/file.cgi, referer: http://whimsy.local/secretary/workbench/file.cgi
---
:svn:
- /Users/clr/apache/foundation
- /Users/clr/apache/documents
- /Users/clr/apache/committers
:sendmail:
delivery_method: smtp
address: smtp.gmail.com
port: 587
domain: apache.org
user_name: 'papajdo@gmail.com'
password: ’noyb'
authentication: plain
enable_starttls_auto: true
> On Aug 23, 2016, at 4:36 AM, Sam Ruby <ru...@intertwingly.net> wrote:
>
> On Mon, Aug 22, 2016 at 11:20 PM, Craig Russell
> <cr...@oracle.com> wrote:
>> I don’t understand why it’s trying localhost 25 when I specifically asked for smtp.gmail.com 587.
>
> Sorry about that. I know what is going on.
>
> Create a ~/.whimsy file and put in it:
>
> :sendmail:
> delivery_method: smtp
> address: smtp.gmail.com
> port: 587
> domain: apache.org
> user_name: username
> password: password
> authentication: plain
> enable_starttls_auto: true
>
> Background: secretary/workbench is the oldest whimsy tool and has its
> own configuration (~/.secassist, ~/.secmail). Over time, I saw a lot
> of commonality in configuration and made that common (~/.whimsy) but
> didn't update secretary/workbench. Then when mail wasn't working on
> whimsy-vm3, I made a fix to the common code and instead of making a
> separate fix to the workbench, I updated it to use the common mail
> configuration.
>
> So: same information, different place, slightly different format; but
> on the brighter side this same information will be used by all of the
> whimsy tools that send email.
>
> - Sam Ruby
Craig L Russell
Architect
craig.russell@oracle.com
P.S. A good JDO? O, Gasp!
Re: Work still to do on incomplete and unsigned
Posted by Sam Ruby <ru...@intertwingly.net>.
On Mon, Aug 22, 2016 at 11:20 PM, Craig Russell
<cr...@oracle.com> wrote:
> I don’t understand why it’s trying localhost 25 when I specifically asked for smtp.gmail.com 587.
Sorry about that. I know what is going on.
Create a ~/.whimsy file and put in it:
:sendmail:
delivery_method: smtp
address: smtp.gmail.com
port: 587
domain: apache.org
user_name: username
password: password
authentication: plain
enable_starttls_auto: true
Background: secretary/workbench is the oldest whimsy tool and has its
own configuration (~/.secassist, ~/.secmail). Over time, I saw a lot
of commonality in configuration and made that common (~/.whimsy) but
didn't update secretary/workbench. Then when mail wasn't working on
whimsy-vm3, I made a fix to the common code and instead of making a
separate fix to the workbench, I updated it to use the common mail
configuration.
So: same information, different place, slightly different format; but
on the brighter side this same information will be used by all of the
whimsy tools that send email.
- Sam Ruby
Re: Work still to do on incomplete and unsigned
Posted by Craig Russell <cr...@oracle.com>.
I don’t understand why it’s trying localhost 25 when I specifically asked for smtp.gmail.com 587.
> On Aug 22, 2016, at 8:05 PM, Craig Russell <cr...@oracle.com> wrote:
>
> I don’t understand why it’s trying port 25 when I specifically asked for 587.
>
>> On Aug 22, 2016, at 7:55 PM, Craig Russell <cr...@oracle.com> wrote:
>>
>> Errno::ECONNREFUSED: Connection refused - connect(2) for "localhost" port 25
>
> Craig L Russell
> Architect
> craig.russell@oracle.com
> P.S. A good JDO? O, Gasp!
>
>
>
>
>
Craig L Russell
Architect
craig.russell@oracle.com
P.S. A good JDO? O, Gasp!
Re: Work still to do on incomplete and unsigned
Posted by Craig Russell <cr...@oracle.com>.
I don’t understand why it’s trying port 25 when I specifically asked for 587.
> On Aug 22, 2016, at 7:55 PM, Craig Russell <cr...@oracle.com> wrote:
>
> Errno::ECONNREFUSED: Connection refused - connect(2) for "localhost" port 25
Craig L Russell
Architect
craig.russell@oracle.com
P.S. A good JDO? O, Gasp!
Re: Work still to do on incomplete and unsigned
Posted by Craig Russell <cr...@oracle.com>.
Here’s the error log from commit with the pending.yml that I sent earlier.
/Users/clr/apache/git/whimsy/www/secretary/workbench/file.cgi, referer: http://whimsy.local/secretary/workbench/file.cgi
[Mon Aug 22 19:53:53.207352 2016] [cgi:error] [pid 12884] [client ::1:49514] AH01215: _ERROR #<Errno::ECONNREFUSED: Connection refused - connect(2) for "localhost" port 25>: /Users/clr/apache/git/whimsy/www/secretary/workbench/file.cgi, referer: http://whimsy.local/secretary/workbench/file.cgi
[Mon Aug 22 19:53:53.207546 2016] [cgi:error] [pid 12884] [client ::1:49514] AH01215: _WARN /usr/local/Cellar/ruby/2.3.1/lib/ruby/2.3.0/net/smtp.rb:542:in `initialize': /Users/clr/apache/git/whimsy/www/secretary/workbench/file.cgi, referer: http://whimsy.local/secretary/workbench/file.cgi
[Mon Aug 22 19:53:53.207607 2016] [cgi:error] [pid 12884] [client ::1:49514] AH01215: _WARN /usr/local/Cellar/ruby/2.3.1/lib/ruby/2.3.0/net/smtp.rb:542:in `open': /Users/clr/apache/git/whimsy/www/secretary/workbench/file.cgi, referer: http://whimsy.local/secretary/workbench/file.cgi
[Mon Aug 22 19:53:53.207644 2016] [cgi:error] [pid 12884] [client ::1:49514] AH01215: _WARN /usr/local/Cellar/ruby/2.3.1/lib/ruby/2.3.0/net/smtp.rb:542:in `tcp_socket': /Users/clr/apache/git/whimsy/www/secretary/workbench/file.cgi, referer: http://whimsy.local/secretary/workbench/file.cgi
[Mon Aug 22 19:53:53.207682 2016] [cgi:error] [pid 12884] [client ::1:49514] AH01215: _WARN /usr/local/Cellar/ruby/2.3.1/lib/ruby/2.3.0/net/smtp.rb:552:in `block in do_start': /Users/clr/apache/git/whimsy/www/secretary/workbench/file.cgi, referer: http://whimsy.local/secretary/workbench/file.cgi
[Mon Aug 22 19:53:53.207718 2016] [cgi:error] [pid 12884] [client ::1:49514] AH01215: _WARN /usr/local/Cellar/ruby/2.3.1/lib/ruby/2.3.0/timeout.rb:91:in `block in timeout': /Users/clr/apache/git/whimsy/www/secretary/workbench/file.cgi, referer: http://whimsy.local/secretary/workbench/file.cgi
[Mon Aug 22 19:53:53.207751 2016] [cgi:error] [pid 12884] [client ::1:49514] AH01215: _WARN /usr/local/Cellar/ruby/2.3.1/lib/ruby/2.3.0/timeout.rb:101:in `timeout': /Users/clr/apache/git/whimsy/www/secretary/workbench/file.cgi, referer: http://whimsy.local/secretary/workbench/file.cgi
[Mon Aug 22 19:53:53.207785 2016] [cgi:error] [pid 12884] [client ::1:49514] AH01215: _WARN /usr/local/Cellar/ruby/2.3.1/lib/ruby/2.3.0/net/smtp.rb:551:in `do_start': /Users/clr/apache/git/whimsy/www/secretary/workbench/file.cgi, referer: http://whimsy.local/secretary/workbench/file.cgi
[Mon Aug 22 19:53:53.207817 2016] [cgi:error] [pid 12884] [client ::1:49514] AH01215: _WARN /usr/local/Cellar/ruby/2.3.1/lib/ruby/2.3.0/net/smtp.rb:521:in `start': /Users/clr/apache/git/whimsy/www/secretary/workbench/file.cgi, referer: http://whimsy.local/secretary/workbench/file.cgi
[Mon Aug 22 19:53:53.207877 2016] [cgi:error] [pid 12884] [client ::1:49514] AH01215: _WARN /usr/local/lib/ruby/gems/2.3.0/gems/mail-2.6.4/lib/mail/network/delivery_methods/smtp.rb:113:in `deliver!': /Users/clr/apache/git/whimsy/www/secretary/workbench/file.cgi, referer: http://whimsy.local/secretary/workbench/file.cgi
[Mon Aug 22 19:53:53.207912 2016] [cgi:error] [pid 12884] [client ::1:49514] AH01215: _WARN /usr/local/lib/ruby/gems/2.3.0/gems/mail-2.6.4/lib/mail/message.rb:253:in `deliver!': /Users/clr/apache/git/whimsy/www/secretary/workbench/file.cgi, referer: http://whimsy.local/secretary/workbench/file.cgi
[Mon Aug 22 19:53:53.207959 2016] [cgi:error] [pid 12884] [client ::1:49514] AH01215: _WARN /Users/clr/apache/git/whimsy/www/secretary/workbench/file.cgi:317:in `block in send_email': /Users/clr/apache/git/whimsy/www/secretary/workbench/file.cgi, referer: http://whimsy.local/secretary/workbench/file.cgi
[Mon Aug 22 19:53:53.207991 2016] [cgi:error] [pid 12884] [client ::1:49514] AH01215: _WARN /Users/clr/apache/git/whimsy/www/secretary/workbench/file.cgi:215:in `each': /Users/clr/apache/git/whimsy/www/secretary/workbench/file.cgi, referer: http://whimsy.local/secretary/workbench/file.cgi
[Mon Aug 22 19:53:53.208025 2016] [cgi:error] [pid 12884] [client ::1:49514] AH01215: _WARN /Users/clr/apache/git/whimsy/www/secretary/workbench/file.cgi:215:in `send_email': /Users/clr/apache/git/whimsy/www/secretary/workbench/file.cgi, referer: http://whimsy.local/secretary/workbench/file.cgi
[Mon Aug 22 19:53:53.208061 2016] [cgi:error] [pid 12884] [client ::1:49514] AH01215: _WARN /Users/clr/apache/git/whimsy/www/secretary/workbench/file.cgi:358:in `block in <main>': /Users/clr/apache/git/whimsy/www/secretary/workbench/file.cgi, referer: http://whimsy.local/secretary/workbench/file.cgi
Any ideas?
Thanks,
Craig
> On Aug 22, 2016, at 6:25 PM, Sam Ruby <ru...@intertwingly.net> wrote:
>
> On Mon, Aug 22, 2016 at 9:03 PM, Craig Russell <cr...@oracle.com> wrote:
>> This last has me wondering.
>>
>>> On Aug 22, 2016, at 8:18 AM, Sam Ruby <ru...@intertwingly.net> wrote:
>>>
>>>> Then I want to see the email template for incomplete and unsigned filled from the form.
>>>
>>> Fair to assume that this should appear on the right pane? If so, that
>>> code would go here:
>>>
>>> https://github.com/apache/whimsy/blob/d186820f9d2e61ae81bd406b2fae8feca17c4d69/www/secretary/workbench/file.cgi#L783
>>
>> I don’t see anything about sending email here. Is it in the ajax part?
>
> Indeed. What the workbench does is show you what will be done (and
> that is here) and hidden in the display is a number of "data_"
> attributes containing parameters. Once that is shown, the "AJAX part"
> looks for todos and iterates over then, sending the parameters that
> are hidden. So define what you want to do here and it will be
> processed along with the other steps.
>
>> Anyway, I have this pending:
>> ---
>> - doctype: icla
>> source: apache-icla-prajwal.pdf
>> realname: Prajwal Rao
>> pubname: Prajwal Rao
>> email: prajwalrao@gmail.com
>> filename: prajwal-rao.pdf
>> nname: Prajwal Rao
>> nemail: prajwalrao@gmail.com
>> iname: Prajwal Rao
>> iemail: prajwalrao@gmail.com
>> uname: Prajwal Rao
>> uemail: prajwalrao@gmail.com
>> pname: Prajwal Rao
>> pemail: prajwalrao@gmail.com
>> memail: prajwalrao@gmail.com
>> gname: Prajwal Rao
>> gemail: prajwalrao@gmail.com
>> contact: Prajwal Rao
>> cemail: prajwalrao@gmail.com
>> ipodling: " "
>> email:addr: prajwalrao@gmail.com
>> email:id: "<CA...@mail.gmail.com>"
>> email:name: Prajwal Rao
>> email:subject: Signed Individual Contributor License Agreement - Prajwal Rao
>> svn:mime-type: application/pdf
>>
>> It’s failing with a 500 in file.cgi, I assume in the sending mail part.
>>
>> How do I debug this?
>
> Generally, when you see a 500, look in the logs:
>
> https://github.com/apache/whimsy/blob/master/MACOSX.md#debugging
>
>> Thanks,
>>
>> Craig
>>
>> Craig L Russell
>> Architect
>> craig.russell@oracle.com
>> P.S. A good JDO? O, Gasp!
>
> - Sam Ruby
Craig L Russell
Architect
craig.russell@oracle.com
P.S. A good JDO? O, Gasp!
Re: Work still to do on incomplete and unsigned
Posted by Sam Ruby <ru...@intertwingly.net>.
On Mon, Aug 22, 2016 at 9:03 PM, Craig Russell <cr...@oracle.com> wrote:
> This last has me wondering.
>
>> On Aug 22, 2016, at 8:18 AM, Sam Ruby <ru...@intertwingly.net> wrote:
>>
>>> Then I want to see the email template for incomplete and unsigned filled from the form.
>>
>> Fair to assume that this should appear on the right pane? If so, that
>> code would go here:
>>
>> https://github.com/apache/whimsy/blob/d186820f9d2e61ae81bd406b2fae8feca17c4d69/www/secretary/workbench/file.cgi#L783
>
> I don’t see anything about sending email here. Is it in the ajax part?
Indeed. What the workbench does is show you what will be done (and
that is here) and hidden in the display is a number of "data_"
attributes containing parameters. Once that is shown, the "AJAX part"
looks for todos and iterates over then, sending the parameters that
are hidden. So define what you want to do here and it will be
processed along with the other steps.
> Anyway, I have this pending:
> ---
> - doctype: icla
> source: apache-icla-prajwal.pdf
> realname: Prajwal Rao
> pubname: Prajwal Rao
> email: prajwalrao@gmail.com
> filename: prajwal-rao.pdf
> nname: Prajwal Rao
> nemail: prajwalrao@gmail.com
> iname: Prajwal Rao
> iemail: prajwalrao@gmail.com
> uname: Prajwal Rao
> uemail: prajwalrao@gmail.com
> pname: Prajwal Rao
> pemail: prajwalrao@gmail.com
> memail: prajwalrao@gmail.com
> gname: Prajwal Rao
> gemail: prajwalrao@gmail.com
> contact: Prajwal Rao
> cemail: prajwalrao@gmail.com
> ipodling: " "
> email:addr: prajwalrao@gmail.com
> email:id: "<CA...@mail.gmail.com>"
> email:name: Prajwal Rao
> email:subject: Signed Individual Contributor License Agreement - Prajwal Rao
> svn:mime-type: application/pdf
>
> It’s failing with a 500 in file.cgi, I assume in the sending mail part.
>
> How do I debug this?
Generally, when you see a 500, look in the logs:
https://github.com/apache/whimsy/blob/master/MACOSX.md#debugging
> Thanks,
>
> Craig
>
> Craig L Russell
> Architect
> craig.russell@oracle.com
> P.S. A good JDO? O, Gasp!
- Sam Ruby
Re: Work still to do on incomplete and unsigned
Posted by Craig Russell <cr...@oracle.com>.
This last has me wondering.
> On Aug 22, 2016, at 8:18 AM, Sam Ruby <ru...@intertwingly.net> wrote:
>
>> Then I want to see the email template for incomplete and unsigned filled from the form.
>
> Fair to assume that this should appear on the right pane? If so, that
> code would go here:
>
> https://github.com/apache/whimsy/blob/d186820f9d2e61ae81bd406b2fae8feca17c4d69/www/secretary/workbench/file.cgi#L783
I don’t see anything about sending email here. Is it in the ajax part?
Anyway, I have this pending:
---
- doctype: icla
source: apache-icla-prajwal.pdf
realname: Prajwal Rao
pubname: Prajwal Rao
email: prajwalrao@gmail.com
filename: prajwal-rao.pdf
nname: Prajwal Rao
nemail: prajwalrao@gmail.com
iname: Prajwal Rao
iemail: prajwalrao@gmail.com
uname: Prajwal Rao
uemail: prajwalrao@gmail.com
pname: Prajwal Rao
pemail: prajwalrao@gmail.com
memail: prajwalrao@gmail.com
gname: Prajwal Rao
gemail: prajwalrao@gmail.com
contact: Prajwal Rao
cemail: prajwalrao@gmail.com
ipodling: " "
email:addr: prajwalrao@gmail.com
email:id: "<CA...@mail.gmail.com>"
email:name: Prajwal Rao
email:subject: Signed Individual Contributor License Agreement - Prajwal Rao
svn:mime-type: application/pdf
It’s failing with a 500 in file.cgi, I assume in the sending mail part.
How do I debug this?
Thanks,
Craig
Craig L Russell
Architect
craig.russell@oracle.com
P.S. A good JDO? O, Gasp!
Re: Work still to do on incomplete and unsigned
Posted by Sam Ruby <ru...@intertwingly.net>.
On Mon, Aug 22, 2016 at 1:21 PM, Craig Russell <cr...@oracle.com> wrote:
> Still one more bit that I can’t figure out.
>
> How do I put the two new radio buttons incomplete and unsigned on the second row?
The following code produces a single table with two rows:
https://github.com/apache/whimsy/blob/d186820f9d2e61ae81bd406b2fae8feca17c4d69/www/secretary/workbench/worklist.cgi#L134
The first row contains radio buttons, the second row contains text.
If you want four rows (alternating buttons with text underneath), try
duplicating the lines 135-146.
Finally to make each row only show a subset of buttons, change DOCTYPE
to DOCTYPE[0..3] in the first two rows, and DOCTYPE[4..-1] in the last
two rows.
> Thanks,
>
> Craig
- Sam Ruby
>> On Aug 22, 2016, at 9:03 AM, Craig Russell <cr...@oracle.com> wrote:
>>
>> Exactly the feedback I was looking for.
>>
>> Thanks,
>>
>> Craig
>>
>
> Craig L Russell
> Architect
> craig.russell@oracle.com
> P.S. A good JDO? O, Gasp!
>
>
>
>
>
Re: Work still to do on incomplete and unsigned
Posted by Craig Russell <cr...@oracle.com>.
Still one more bit that I can’t figure out.
How do I put the two new radio buttons incomplete and unsigned on the second row?
Thanks,
Craig
> On Aug 22, 2016, at 9:03 AM, Craig Russell <cr...@oracle.com> wrote:
>
> Exactly the feedback I was looking for.
>
> Thanks,
>
> Craig
>
Craig L Russell
Architect
craig.russell@oracle.com
P.S. A good JDO? O, Gasp!
Re: Work still to do on incomplete and unsigned
Posted by Craig Russell <cr...@oracle.com>.
Exactly the feedback I was looking for.
Thanks,
Craig
> On Aug 22, 2016, at 8:18 AM, Sam Ruby <ru...@intertwingly.net> wrote:
>
> On Sun, Aug 21, 2016 at 10:53 PM, Craig Russell
> <cr...@oracle.com> wrote:
>> What still does not work is pre-populating the iname and iemail (uname and uemail) from the received document when selecting incomplete and unsigned. Just like icla, ccla, and grant do now.
>
> The place to look is here:
>
> https://github.com/apache/whimsy/blob/84b03760b311926c7f774a35dc85aaae8b87cc15/www/secretary/workbench/worklist.js#L112
>
>> Then I want to see the email template for incomplete and unsigned filled from the form.
>
> Fair to assume that this should appear on the right pane? If so, that
> code would go here:
>
> https://github.com/apache/whimsy/blob/d186820f9d2e61ae81bd406b2fae8feca17c4d69/www/secretary/workbench/file.cgi#L783
>
> I'll note that you are starting to hit the reason why I am not overly
> enthusiastic about adding new features to this code base. So many
> different places need to be changed in order to add one (even
> relatively simple) new feature. And the coupling between those
> changes is high. By contrast, newer codebases (like board agenda)
> changes tend to be localized and variables are local not global.
>
>> And of course svn mv documents/received/icla.pdf unsigned <== needs to be a complete path here.
>
> Add "Dir.chdir(RECEIVED) do"..."end" around the _.move @source, dest,
> and either change 'dest = "unsigned"' to `dest =
> DESTINATION['unsigned']` (to make use of your changes to DESTINATION)
> or `dest = ''deadletter/unsigned'`.
>
>> Craig
>
> - Sam Ruby
>
>>> On Aug 21, 2016, at 4:31 PM, clr@apache.org wrote:
>>>
>>> This is an automated email from the ASF dual-hosted git repository.
>>>
>>> clr pushed a commit to branch incomplete-unsigned
>>> in repository https://git-dual.apache.org/repos/asf/whimsy.git
>>>
>>> The following commit(s) were added to refs/heads/incomplete-unsigned by this push:
>>> new d186820 Change names for incomplete and unsigned
>>> d186820 is described below
>>>
>>> commit d186820f9d2e61ae81bd406b2fae8feca17c4d69
>>> Author: Craig L Russell <cr...@oracle.com>
>>> AuthorDate: Sun Aug 21 16:31:33 2016 -0700
>>>
>>> Change names for incomplete and unsigned
>>> ---
>>> www/secretary/workbench/file.cgi | 5 ++---
>>> www/secretary/workbench/worklist.cgi | 24 ++++++++++++------------
>>> 2 files changed, 14 insertions(+), 15 deletions(-)
>>>
>>> diff --git a/www/secretary/workbench/file.cgi b/www/secretary/workbench/file.cgi
>>> index cf70e1f..d27e8d6 100755
>>> --- a/www/secretary/workbench/file.cgi
>>> +++ b/www/secretary/workbench/file.cgi
>>> @@ -611,11 +611,10 @@ _html do
>>> update_pending params, dest
>>>
>>> when 'incomplete'
>>> - _.system "whoami"
>>> @realname ||= @iname
>>> dest = "incomplete"
>>>
>>> - _h1 "Incomplete from #{@iname}"
>>> + _h1 "Incomplete document received from #{@iname}"
>>> _.move @source, dest
>>>
>>> update_pending params, dest
>>> @@ -624,7 +623,7 @@ _html do
>>> @realname ||= @nname
>>> dest = "unsigned"
>>>
>>> - _h1 "Unsigned from #{@uname}"
>>> + _h1 "Unsigned document received from #{@uname}"
>>> _.move @source, dest
>>>
>>> update_pending params, dest
>>> diff --git a/www/secretary/workbench/worklist.cgi b/www/secretary/workbench/worklist.cgi
>>> index 7e01e81..f911239 100755
>>> --- a/www/secretary/workbench/worklist.cgi
>>> +++ b/www/secretary/workbench/worklist.cgi
>>> @@ -76,9 +76,9 @@ _html do
>>> elsif pending['doctype'] == 'nda'
>>> message = "NDA for #{pending['realname']}"
>>> elsif pending['doctype'] == 'incomplete'
>>> - message = "Incomplete for #{pending['nname']}"
>>> + message = "Incomplete document received from #{pending['iname']}"
>>> elsif pending['doctype'] == 'unsigned'
>>> - message = "Unsigned for #{pending['nname']}"
>>> + message = "Unsigned document received from #{pending['uname']}"
>>> end
>>> end
>>> end
>>> @@ -215,17 +215,17 @@ _html do
>>> _table do
>>> _tr do
>>> _td do
>>> - _label 'Name', for: 'nname'
>>> + _label 'Name', for: 'iname'
>>> end
>>> _td do
>>> - _input type: :text, name: 'nname', id: 'nname'
>>> + _input type: :text, name: 'iname', id: 'iname'
>>> end
>>> end
>>>
>>> _tr do
>>> _td.label 'EMail'
>>> _td.input do
>>> - _input name: 'nemail', id: 'nemail', type: 'email'
>>> + _input name: 'iemail', id: 'iemail', type: 'email'
>>> end
>>> end
>>> end
>>> @@ -235,17 +235,17 @@ _html do
>>> _table do
>>> _tr do
>>> _td do
>>> - _label 'Name', for: 'nname'
>>> + _label 'Name', for: 'uname'
>>> end
>>> _td do
>>> - _input type: :text, name: 'nname', id: 'nname'
>>> + _input type: :text, name: 'uname', id: 'uname'
>>> end
>>> end
>>>
>>> _tr do
>>> _td.label 'EMail'
>>> _td.input do
>>> - _input name: 'nemail', id: 'nemail', type: 'email'
>>> + _input name: 'uemail', id: 'uemail', type: 'email'
>>> end
>>> end
>>>
>>> @@ -503,13 +503,13 @@ _html do
>>> _tr do
>>> _td.label 'PMC'
>>> _td.input do
>>> - _input name: 'cpmc', id: 'cpmc', type: 'text'
>>> + _input name: 'ipmc', id: 'ipmc', type: 'text'
>>> end
>>> end
>>> _tr do
>>> _td.label 'Podling'
>>> _td.input do
>>> - _input name: 'cpodling', id: 'cpodling', type: 'text'
>>> + _input name: 'ipodling', id: 'ipodling', type: 'text'
>>> end
>>> end
>>> end
>>> @@ -517,13 +517,13 @@ _html do
>>> _tr do
>>> _td.label 'PMC'
>>> _td.input do
>>> - _input name: 'cpmc', id: 'cpmc', type: 'text'
>>> + _input name: 'upmc', id: 'upmc', type: 'text'
>>> end
>>> end
>>> _tr do
>>> _td.label 'Podling'
>>> _td.input do
>>> - _input name: 'cpodling', id: 'cpodling', type: 'text'
>>> + _input name: 'upodling', id: 'upodling', type: 'text'
>>> end
>>> end
>>> end
>>>
>>> --
>>> To stop receiving notification emails like this one, please contact
>>> ['"commits@whimsical.apache.org" <co...@whimsical.apache.org>'].
>>
>> Craig L Russell
>> Architect
>> craig.russell@oracle.com
>> P.S. A good JDO? O, Gasp!
>>
>>
>>
>>
>>
Craig L Russell
Architect
craig.russell@oracle.com
P.S. A good JDO? O, Gasp!
Re: Work still to do on incomplete and unsigned
Posted by Sam Ruby <ru...@intertwingly.net>.
On Sun, Aug 21, 2016 at 10:53 PM, Craig Russell
<cr...@oracle.com> wrote:
> What still does not work is pre-populating the iname and iemail (uname and uemail) from the received document when selecting incomplete and unsigned. Just like icla, ccla, and grant do now.
The place to look is here:
https://github.com/apache/whimsy/blob/84b03760b311926c7f774a35dc85aaae8b87cc15/www/secretary/workbench/worklist.js#L112
> Then I want to see the email template for incomplete and unsigned filled from the form.
Fair to assume that this should appear on the right pane? If so, that
code would go here:
https://github.com/apache/whimsy/blob/d186820f9d2e61ae81bd406b2fae8feca17c4d69/www/secretary/workbench/file.cgi#L783
I'll note that you are starting to hit the reason why I am not overly
enthusiastic about adding new features to this code base. So many
different places need to be changed in order to add one (even
relatively simple) new feature. And the coupling between those
changes is high. By contrast, newer codebases (like board agenda)
changes tend to be localized and variables are local not global.
> And of course svn mv documents/received/icla.pdf unsigned <== needs to be a complete path here.
Add "Dir.chdir(RECEIVED) do"..."end" around the _.move @source, dest,
and either change 'dest = "unsigned"' to `dest =
DESTINATION['unsigned']` (to make use of your changes to DESTINATION)
or `dest = ''deadletter/unsigned'`.
> Craig
- Sam Ruby
>> On Aug 21, 2016, at 4:31 PM, clr@apache.org wrote:
>>
>> This is an automated email from the ASF dual-hosted git repository.
>>
>> clr pushed a commit to branch incomplete-unsigned
>> in repository https://git-dual.apache.org/repos/asf/whimsy.git
>>
>> The following commit(s) were added to refs/heads/incomplete-unsigned by this push:
>> new d186820 Change names for incomplete and unsigned
>> d186820 is described below
>>
>> commit d186820f9d2e61ae81bd406b2fae8feca17c4d69
>> Author: Craig L Russell <cr...@oracle.com>
>> AuthorDate: Sun Aug 21 16:31:33 2016 -0700
>>
>> Change names for incomplete and unsigned
>> ---
>> www/secretary/workbench/file.cgi | 5 ++---
>> www/secretary/workbench/worklist.cgi | 24 ++++++++++++------------
>> 2 files changed, 14 insertions(+), 15 deletions(-)
>>
>> diff --git a/www/secretary/workbench/file.cgi b/www/secretary/workbench/file.cgi
>> index cf70e1f..d27e8d6 100755
>> --- a/www/secretary/workbench/file.cgi
>> +++ b/www/secretary/workbench/file.cgi
>> @@ -611,11 +611,10 @@ _html do
>> update_pending params, dest
>>
>> when 'incomplete'
>> - _.system "whoami"
>> @realname ||= @iname
>> dest = "incomplete"
>>
>> - _h1 "Incomplete from #{@iname}"
>> + _h1 "Incomplete document received from #{@iname}"
>> _.move @source, dest
>>
>> update_pending params, dest
>> @@ -624,7 +623,7 @@ _html do
>> @realname ||= @nname
>> dest = "unsigned"
>>
>> - _h1 "Unsigned from #{@uname}"
>> + _h1 "Unsigned document received from #{@uname}"
>> _.move @source, dest
>>
>> update_pending params, dest
>> diff --git a/www/secretary/workbench/worklist.cgi b/www/secretary/workbench/worklist.cgi
>> index 7e01e81..f911239 100755
>> --- a/www/secretary/workbench/worklist.cgi
>> +++ b/www/secretary/workbench/worklist.cgi
>> @@ -76,9 +76,9 @@ _html do
>> elsif pending['doctype'] == 'nda'
>> message = "NDA for #{pending['realname']}"
>> elsif pending['doctype'] == 'incomplete'
>> - message = "Incomplete for #{pending['nname']}"
>> + message = "Incomplete document received from #{pending['iname']}"
>> elsif pending['doctype'] == 'unsigned'
>> - message = "Unsigned for #{pending['nname']}"
>> + message = "Unsigned document received from #{pending['uname']}"
>> end
>> end
>> end
>> @@ -215,17 +215,17 @@ _html do
>> _table do
>> _tr do
>> _td do
>> - _label 'Name', for: 'nname'
>> + _label 'Name', for: 'iname'
>> end
>> _td do
>> - _input type: :text, name: 'nname', id: 'nname'
>> + _input type: :text, name: 'iname', id: 'iname'
>> end
>> end
>>
>> _tr do
>> _td.label 'EMail'
>> _td.input do
>> - _input name: 'nemail', id: 'nemail', type: 'email'
>> + _input name: 'iemail', id: 'iemail', type: 'email'
>> end
>> end
>> end
>> @@ -235,17 +235,17 @@ _html do
>> _table do
>> _tr do
>> _td do
>> - _label 'Name', for: 'nname'
>> + _label 'Name', for: 'uname'
>> end
>> _td do
>> - _input type: :text, name: 'nname', id: 'nname'
>> + _input type: :text, name: 'uname', id: 'uname'
>> end
>> end
>>
>> _tr do
>> _td.label 'EMail'
>> _td.input do
>> - _input name: 'nemail', id: 'nemail', type: 'email'
>> + _input name: 'uemail', id: 'uemail', type: 'email'
>> end
>> end
>>
>> @@ -503,13 +503,13 @@ _html do
>> _tr do
>> _td.label 'PMC'
>> _td.input do
>> - _input name: 'cpmc', id: 'cpmc', type: 'text'
>> + _input name: 'ipmc', id: 'ipmc', type: 'text'
>> end
>> end
>> _tr do
>> _td.label 'Podling'
>> _td.input do
>> - _input name: 'cpodling', id: 'cpodling', type: 'text'
>> + _input name: 'ipodling', id: 'ipodling', type: 'text'
>> end
>> end
>> end
>> @@ -517,13 +517,13 @@ _html do
>> _tr do
>> _td.label 'PMC'
>> _td.input do
>> - _input name: 'cpmc', id: 'cpmc', type: 'text'
>> + _input name: 'upmc', id: 'upmc', type: 'text'
>> end
>> end
>> _tr do
>> _td.label 'Podling'
>> _td.input do
>> - _input name: 'cpodling', id: 'cpodling', type: 'text'
>> + _input name: 'upodling', id: 'upodling', type: 'text'
>> end
>> end
>> end
>>
>> --
>> To stop receiving notification emails like this one, please contact
>> ['"commits@whimsical.apache.org" <co...@whimsical.apache.org>'].
>
> Craig L Russell
> Architect
> craig.russell@oracle.com
> P.S. A good JDO? O, Gasp!
>
>
>
>
>
Work still to do on incomplete and unsigned
Posted by Craig Russell <cr...@oracle.com>.
What still does not work is pre-populating the iname and iemail (uname and uemail) from the received document when selecting incomplete and unsigned. Just like icla, ccla, and grant do now.
Then I want to see the email template for incomplete and unsigned filled from the form.
And of course svn mv documents/received/icla.pdf unsigned <== needs to be a complete path here.
Craig
> On Aug 21, 2016, at 4:31 PM, clr@apache.org wrote:
>
> This is an automated email from the ASF dual-hosted git repository.
>
> clr pushed a commit to branch incomplete-unsigned
> in repository https://git-dual.apache.org/repos/asf/whimsy.git
>
> The following commit(s) were added to refs/heads/incomplete-unsigned by this push:
> new d186820 Change names for incomplete and unsigned
> d186820 is described below
>
> commit d186820f9d2e61ae81bd406b2fae8feca17c4d69
> Author: Craig L Russell <cr...@oracle.com>
> AuthorDate: Sun Aug 21 16:31:33 2016 -0700
>
> Change names for incomplete and unsigned
> ---
> www/secretary/workbench/file.cgi | 5 ++---
> www/secretary/workbench/worklist.cgi | 24 ++++++++++++------------
> 2 files changed, 14 insertions(+), 15 deletions(-)
>
> diff --git a/www/secretary/workbench/file.cgi b/www/secretary/workbench/file.cgi
> index cf70e1f..d27e8d6 100755
> --- a/www/secretary/workbench/file.cgi
> +++ b/www/secretary/workbench/file.cgi
> @@ -611,11 +611,10 @@ _html do
> update_pending params, dest
>
> when 'incomplete'
> - _.system "whoami"
> @realname ||= @iname
> dest = "incomplete"
>
> - _h1 "Incomplete from #{@iname}"
> + _h1 "Incomplete document received from #{@iname}"
> _.move @source, dest
>
> update_pending params, dest
> @@ -624,7 +623,7 @@ _html do
> @realname ||= @nname
> dest = "unsigned"
>
> - _h1 "Unsigned from #{@uname}"
> + _h1 "Unsigned document received from #{@uname}"
> _.move @source, dest
>
> update_pending params, dest
> diff --git a/www/secretary/workbench/worklist.cgi b/www/secretary/workbench/worklist.cgi
> index 7e01e81..f911239 100755
> --- a/www/secretary/workbench/worklist.cgi
> +++ b/www/secretary/workbench/worklist.cgi
> @@ -76,9 +76,9 @@ _html do
> elsif pending['doctype'] == 'nda'
> message = "NDA for #{pending['realname']}"
> elsif pending['doctype'] == 'incomplete'
> - message = "Incomplete for #{pending['nname']}"
> + message = "Incomplete document received from #{pending['iname']}"
> elsif pending['doctype'] == 'unsigned'
> - message = "Unsigned for #{pending['nname']}"
> + message = "Unsigned document received from #{pending['uname']}"
> end
> end
> end
> @@ -215,17 +215,17 @@ _html do
> _table do
> _tr do
> _td do
> - _label 'Name', for: 'nname'
> + _label 'Name', for: 'iname'
> end
> _td do
> - _input type: :text, name: 'nname', id: 'nname'
> + _input type: :text, name: 'iname', id: 'iname'
> end
> end
>
> _tr do
> _td.label 'EMail'
> _td.input do
> - _input name: 'nemail', id: 'nemail', type: 'email'
> + _input name: 'iemail', id: 'iemail', type: 'email'
> end
> end
> end
> @@ -235,17 +235,17 @@ _html do
> _table do
> _tr do
> _td do
> - _label 'Name', for: 'nname'
> + _label 'Name', for: 'uname'
> end
> _td do
> - _input type: :text, name: 'nname', id: 'nname'
> + _input type: :text, name: 'uname', id: 'uname'
> end
> end
>
> _tr do
> _td.label 'EMail'
> _td.input do
> - _input name: 'nemail', id: 'nemail', type: 'email'
> + _input name: 'uemail', id: 'uemail', type: 'email'
> end
> end
>
> @@ -503,13 +503,13 @@ _html do
> _tr do
> _td.label 'PMC'
> _td.input do
> - _input name: 'cpmc', id: 'cpmc', type: 'text'
> + _input name: 'ipmc', id: 'ipmc', type: 'text'
> end
> end
> _tr do
> _td.label 'Podling'
> _td.input do
> - _input name: 'cpodling', id: 'cpodling', type: 'text'
> + _input name: 'ipodling', id: 'ipodling', type: 'text'
> end
> end
> end
> @@ -517,13 +517,13 @@ _html do
> _tr do
> _td.label 'PMC'
> _td.input do
> - _input name: 'cpmc', id: 'cpmc', type: 'text'
> + _input name: 'upmc', id: 'upmc', type: 'text'
> end
> end
> _tr do
> _td.label 'Podling'
> _td.input do
> - _input name: 'cpodling', id: 'cpodling', type: 'text'
> + _input name: 'upodling', id: 'upodling', type: 'text'
> end
> end
> end
>
> --
> To stop receiving notification emails like this one, please contact
> ['"commits@whimsical.apache.org" <co...@whimsical.apache.org>'].
Craig L Russell
Architect
craig.russell@oracle.com
P.S. A good JDO? O, Gasp!