[GitHub] [apisix] spacewander commented on a diff in pull request #8718: fix(proxy-mirror): use with uri rewrite

["spacewander (via GitHub)" <gi...@apache.org>]

spacewander commented on code in PR #8718:
URL: https://github.com/apache/apisix/pull/8718#discussion_r1089652194


##########
t/plugin/proxy-mirror.t:
##########
@@ -838,3 +838,66 @@ GET /hello?a=1
 hello world
 --- error_log
 uri: /a/hello?a=1
+
+
+
+=== TEST 30: use proxy-rewrite to change uri before mirror

Review Comment:
   Let's move it to a new file.
   
   > When the test file is too large, for example > 800 lines, you should split it to a new file. Please take a look at t/plugin/limit-conn.t and t/plugin/limit-conn2.t.
   
   https://github.com/apache/apisix/blob/master/CONTRIBUTING.md#check-code-style-and-test-case-style



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org